bckelley/cgm-remote-monitor
1
0
Fork 0
mirror of https://github.com/bckelley/cgm-remote-monitor.git synced 2026-08-24 03:14:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

ensure obfuscation only affects rendered values

Browse Source 
The results to render may come from an in-memory cache, or from the database.
If they came from the in-memory cache, it's possible that obscurring the device
field could actually change the values in memory.  When obscurring, the device
field, this patch copies all of the values in order to ensure that the
in-memory copies are unaffected.  With this patch, cached objects should not be
affected.
This commit is contained in:
Ben West
2021-12-15 10:10:51 -08:00
parent a2f27514f1
commit 6b98e012bb
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/middleware/obscure-provenance.js
+5 -2
View File
@@ -1,10 +1,13 @@
var _ = require('lodash');
module.exports = function create_device_obscurity (env) { module.exports = function create_device_obscurity (env) {
function obscure_device (req, res, next) { function obscure_device (req, res, next) {
if (res.entries && env.settings.obscureDeviceProvenance) { if (res.entries && env.settings.obscureDeviceProvenance) {
for (var i = 0; i < res.entries.length; i++) { var entries = _.cloneDeep(res.entries);
res.entries[i].device = env.settings.obscureDeviceProvenance; for (var i = 0; i < entries.length; i++) {
entries[i].device = env.settings.obscureDeviceProvenance;
} }
res.entries = entries;
} }
next( ); next( );
} }