Files
cgm-remote-monitor/lib/server/cache.js
T
Ben WestandCopilot f4e686c1fb fix: cache filterForAge rejects ObjectId _id on MongoDB driver 5.x
_.isEmpty(new ObjectId()) returns true on driver 5.x because ObjectId
no longer has enumerable own properties (Object.keys returns []).
This caused filterForAge() to silently drop all entries with ObjectId
_id from the server cache.

check. This correctly accepts ObjectId instances and strings while
still rejecting null, undefined, and empty string.

16 tests confirm the fix:
- 3 root cause tests (_.isEmpty regression)
- 7 filterForAge logic tests (old vs fixed behavior)
- 6 integration tests (actual cache.js with data-update events)

Fixes AAPS backfill display bug where entries were in MongoDB but
invisible on the chart when using API V3 (mongoCachedCollection
emits data-update with raw ObjectId _id).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-25 14:05:28 -07:00

112 lines
3.1 KiB
JavaScript

'use strict';
/* This is a simple cache intended to reduce the amount of load
* Nightscout puts on MongoDB. The cache is based on identifying
* elements based on the MongoDB _id field and implements simple
* semantics for adding data to the cache in the runtime, intended
* to be accessed by the persistence layer as data is inserted, updated
* or deleted, as well as the periodic dataloader, which polls Mongo
* for new inserts.
*
* Longer term, the cache is planned to allow skipping the Mongo polls
* altogether.
*/
const _ = require('lodash');
const constants = require('../constants');
function cache (env, ctx) {
const data = {
treatments: []
, devicestatus: []
, entries: []
};
const retentionPeriods = {
treatments: constants.ONE_HOUR * 60
, devicestatus: env.extendedSettings.devicestatus && env.extendedSettings.devicestatus.days && env.extendedSettings.devicestatus.days == 2 ? constants.TWO_DAYS : constants.ONE_DAY
, entries: constants.TWO_DAYS
};
function getObjectAge(object) {
let age = object.mills || object.date;
if (isNaN(age) && object.created_at) age = Date.parse(object.created_at).valueOf();
return age;
}
function mergeCacheArrays (oldData, newData, retentionPeriod) {
const ageLimit = Date.now() - retentionPeriod;
var filteredOld = filterForAge(oldData, ageLimit);
var filteredNew = filterForAge(newData, ageLimit);
const merged = ctx.ddata.idMergePreferNew(filteredOld, filteredNew);
return _.sortBy(merged, function(item) {
const age = getObjectAge(item);
return -age;
});
function filterForAge(data, ageLimit) {
return _.filter(data, function hasId(object) {
const hasId = object._id != null && object._id !== '';
const age = getObjectAge(object);
const isFresh = age >= ageLimit;
return isFresh && hasId;
});
}
}
data.isEmpty = (datatype) => {
return data[datatype].length < 20;
}
data.getData = (datatype) => {
return _.cloneDeep(data[datatype]);
}
data.insertData = (datatype, newData) => {
data[datatype] = mergeCacheArrays(data[datatype], newData, retentionPeriods[datatype]);
return data.getData(datatype);
}
function dataChanged (operation) {
if (!data[operation.type]) return;
if (operation.op == 'remove') {
// if multiple items were deleted, flush entire cache
if (!operation.changes) {
data.treatments = [];
data.devicestatus = [];
data.entries = [];
} else {
removeFromArray(data[operation.type], operation.changes);
}
}
if (operation.op == 'update') {
data[operation.type] = mergeCacheArrays(data[operation.type], operation.changes, retentionPeriods[operation.type]);
}
}
ctx.bus.on('data-update', dataChanged);
function removeFromArray (array, id) {
for (let i = 0; i < array.length; i++) {
const o = array[i];
if (o._id == id) {
//console.log('Deleting object from cache', id);
array.splice(i, 1);
break;
}
}
}
return data;
}
module.exports = cache;