mirror of
https://github.com/bckelley/cgm-remote-monitor.git
synced 2026-08-24 03:14:12 -05:00
Add validation for _id field in activity and food APIs: - activity: POST, PUT, DELETE now validate _id format - food: POST, PUT, DELETE now validate _id format Accepts: undefined, null, or 24-character hex string Rejects: UUIDs, short strings, numbers, objects with 400 Bad Request Previously: - activity: 500 crash on invalid _id in save/remove - food: silently replaced invalid _id with new ObjectId (data loss) Tests added covering all validation cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
119 lines
3.7 KiB
JavaScript
119 lines
3.7 KiB
JavaScript
'use strict';
|
|
|
|
var consts = require('../../constants');
|
|
|
|
/**
|
|
* Validate MongoDB ObjectId format.
|
|
* Accepts: undefined, null, or 24-character hex string.
|
|
* Rejects: anything else (UUIDs, short strings, numbers, objects).
|
|
*/
|
|
function isValidObjectId(id) {
|
|
if (id === undefined || id === null) return true;
|
|
if (typeof id !== 'string') return false;
|
|
return /^[a-fA-F0-9]{24}$/.test(id);
|
|
}
|
|
|
|
function configure (app, wares, ctx) {
|
|
var express = require('express'),
|
|
api = express.Router( );
|
|
|
|
// invoke common middleware
|
|
api.use(wares.sendJSONStatus);
|
|
// text body types get handled as raw buffer stream
|
|
api.use(wares.rawParser);
|
|
// json body types get handled as parsed json
|
|
api.use(wares.jsonParser);
|
|
// also support url-encoded content-type
|
|
api.use(wares.urlencodedParser);
|
|
// text body types get handled as raw buffer stream
|
|
// shortcut to use extension to specify output content-type
|
|
|
|
api.use(ctx.authorization.isPermitted('api:food:read'));
|
|
|
|
// List foods available
|
|
api.get('/food/', function(req, res) {
|
|
ctx.food.list(function (err, attribute) {
|
|
return res.json(attribute);
|
|
});
|
|
});
|
|
|
|
api.get('/food/quickpicks', function(req, res) {
|
|
ctx.food.listquickpicks(function (err, attribute) {
|
|
return res.json(attribute);
|
|
});
|
|
});
|
|
|
|
api.get('/food/regular', function(req, res) {
|
|
ctx.food.listregular(function (err, attribute) {
|
|
return res.json(attribute);
|
|
});
|
|
});
|
|
|
|
function config_authed (app, api, wares, ctx) {
|
|
|
|
// create new record
|
|
api.post('/food/', ctx.authorization.isPermitted('api:food:create'), function(req, res) {
|
|
var data = req.body;
|
|
|
|
// Validate _id if provided
|
|
if (!isValidObjectId(data._id)) {
|
|
return res.sendJSONStatus(res, consts.HTTP_BAD_REQUEST,
|
|
'Invalid _id format', 'Must be 24-character hex string or omit for auto-generation. Got: ' + String(data._id));
|
|
}
|
|
|
|
ctx.food.create(data, function (err, created) {
|
|
if (err) {
|
|
res.sendJSONStatus(res, consts.HTTP_INTERNAL_ERROR, 'Mongo Error', err);
|
|
console.log('Error creating food');
|
|
console.log(err);
|
|
} else {
|
|
res.json(created);
|
|
console.log('food created',created);
|
|
}
|
|
});
|
|
});
|
|
|
|
// update record
|
|
api.put('/food/', ctx.authorization.isPermitted('api:food:update'), function(req, res) {
|
|
var data = req.body;
|
|
|
|
// Validate _id if provided
|
|
if (!isValidObjectId(data._id)) {
|
|
return res.sendJSONStatus(res, consts.HTTP_BAD_REQUEST,
|
|
'Invalid _id format', 'Must be 24-character hex string. Got: ' + String(data._id));
|
|
}
|
|
|
|
ctx.food.save(data, function (err, created) {
|
|
if (err) {
|
|
res.sendJSONStatus(res, consts.HTTP_INTERNAL_ERROR, 'Mongo Error', err);
|
|
console.log('Error saving food');
|
|
console.log(err);
|
|
} else {
|
|
res.json(created);
|
|
console.log('food saved');
|
|
}
|
|
});
|
|
});
|
|
// delete record
|
|
api.delete('/food/:_id', ctx.authorization.isPermitted('api:food:delete'), function(req, res) {
|
|
// Validate _id parameter
|
|
if (!isValidObjectId(req.params._id)) {
|
|
return res.sendJSONStatus(res, consts.HTTP_BAD_REQUEST,
|
|
'Invalid _id format', 'Must be 24-character hex string. Got: ' + String(req.params._id));
|
|
}
|
|
ctx.food.remove(req.params._id, function ( ) {
|
|
res.json({ });
|
|
});
|
|
});
|
|
}
|
|
|
|
if (app.enabled('api')) {
|
|
config_authed(app, api, wares, ctx);
|
|
}
|
|
|
|
return api;
|
|
}
|
|
|
|
module.exports = configure;
|
|
|