mirror of
https://github.com/bckelley/tconnectsync.git
synced 2026-08-24 03:34:12 -05:00
ClaudeandJames Woglom
ddeaa79ded
ProcessAlarm.skip_event() read event.alarmId on every EventClass.ALARM event, but LidMalfunctionActivated (a sibling of LidAlarmActivated in that class) has no alarmId, so a malfunction alarm crashed the sync with AttributeError. - Narrow with isinstance before reading alarmId; malfunction events now upload as "Malfunction" as intended, and sync continues. - Type the alarm handlers against an explicit AlarmEvent union and add an assert_never exhaustiveness guard, so a type checker rejects unguarded subtype attribute access and flags any newly added ALARM event type. - Fix a latent None-leak: alarm_to_nsentry now always returns a dict. - Add mypy as a gradual-typing beachhead (setup.cfg [mypy], CI step, Pipfile typecheck script), scoped to process_alarm.py. This configuration fails on exactly the #156 class of bug. - Add regression tests: malfunction processing, mixed alarm batches, the event shape, and an AlarmEvent/EventClass.ALARM sync guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpMTd5LzkqFLZTUKd3H8em
80 lines
2.8 KiB
YAML
80 lines
2.8 KiB
YAML
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
|
|
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
|
|
|
|
name: Python package
|
|
|
|
on:
|
|
push:
|
|
branches: [ master, dev ]
|
|
pull_request:
|
|
branches: [ master, dev ]
|
|
|
|
jobs:
|
|
build:
|
|
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
matrix:
|
|
python-version: ['3.8', '3.9', '3.10', '3.11']
|
|
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
- name: Set up Python ${{ matrix.python-version }}
|
|
uses: actions/setup-python@v2
|
|
with:
|
|
python-version: ${{ matrix.python-version }}
|
|
- name: Install dependencies
|
|
run: |
|
|
python -m venv .venv
|
|
.venv/bin/python -m pip install --upgrade pip
|
|
.venv/bin/python -m pip install -e . flake8 pytest coverage mypy
|
|
# - name: Run pipenv check
|
|
# run: |
|
|
# # DDoS attacks in wheel and setuptools packages, not relevant
|
|
# # root certificate store, not relevant
|
|
# pipenv check \
|
|
# --ignore 51499 \
|
|
# --ignore 52495 \
|
|
# --ignore 52365 \
|
|
# --ignore 59956 \
|
|
# --ignore 58755 \
|
|
# --ignore 67895 \
|
|
# --ignore 61893 \
|
|
# --ignore 61601 \
|
|
# --ignore 62044 \
|
|
# --ignore 67599 \
|
|
# --ignore 72083 \
|
|
# --ignore 71064 \
|
|
# --ignore 71608 \
|
|
# --ignore 72236
|
|
- name: Lint with flake8
|
|
run: |
|
|
# stop the build if there are Python syntax errors or undefined names
|
|
.venv/bin/flake8 . --exclude=.venv --count --select=E9,F63,F7,F82 --ignore=F824 --show-source --statistics
|
|
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
|
|
.venv/bin/flake8 . --exclude=.venv --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
|
|
- name: Type-check annotated modules with mypy
|
|
run: |
|
|
.venv/bin/mypy
|
|
- name: Run tconnectsync --help
|
|
run: |
|
|
.venv/bin/tconnectsync --help
|
|
- name: Test with pytest
|
|
run: |
|
|
.venv/bin/pytest
|
|
- name: Check codecov configuration
|
|
run: |
|
|
curl -X POST --data-binary @.codecov.yml https://codecov.io/validate
|
|
|
|
if [[ "$(curl -s -o /dev/null -w "%{http_code}" -X POST --data-binary @.codecov.yml https://codecov.io/validate)" != "200" ]]; then
|
|
echo Error parsing codecov file
|
|
exit 1
|
|
fi
|
|
- name: Generate Coverage Report
|
|
run: |
|
|
.venv/bin/coverage run -m unittest
|
|
- name: Upload Coverage to Codecov
|
|
uses: codecov/codecov-action@v1
|
|
with:
|
|
fail_ci_if_error: false
|