starred/Hyprland
1
0
Fork 0
mirror of https://github.com/hyprwm/Hyprland.git synced 2026-08-24 10:04:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

internal: silence compiler warnings about unused return values (#13997)

Browse Source 
* misc: silence warnings about ignoring return value on reads

silence warnings on ignored return values on read() and print an error
if it occurs.

* misc: silence warnings about ignoring return value on writes

silence warnings on ignored return values on write() and print an error
where we can, or pass them the maybe_unused attribute.

* misc: silence warnings about ignoring return value on pipe

silence warnings on ignored return value on pipe(), print an error and
exit on failure.
This commit is contained in:
Tom Englund
2026-04-05 14:45:27 +01:00
committed by GitHub
parent 3a7bd8fea2
commit 3af9b10890
6 changed files with 36 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
start/src/core/Instance.cpp
+17 -4
View File
@@ -81,7 +81,8 @@ void CHyprlandInstance::runHyprlandThread(bool safeMode) {
break;
}
write(m_wakeupWrite.get(), "vax", 3);
if (write(m_wakeupWrite.get(), "vax", 3) < 0)
g_logger->log(Hyprutils::CLI::LOG_ERR, "Failed to write to wakeup fd {}: {}", m_wakeupWrite.get(), strerror(errno));
std::fflush(stdout);
std::fflush(stderr);
@@ -96,8 +97,14 @@ void CHyprlandInstance::forceQuit() {
}
void CHyprlandInstance::clearFd(const Hyprutils::OS::CFileDescriptor& fd) {
if (!fd.isReadable()) {
g_logger->log(Hyprutils::CLI::LOG_ERR, "Can't clear a unreadable fd");
return;
}
static std::array<char, 1024> buf;
read(fd.get(), buf.data(), 1023);
if (read(fd.get(), buf.data(), 1023) < 0)
g_logger->log(Hyprutils::CLI::LOG_ERR, "Failed clearing fd {}: {}", fd.get(), strerror(errno));
}
void CHyprlandInstance::dispatchHyprlandEvent() {
@@ -132,12 +139,18 @@ void CHyprlandInstance::dispatchHyprlandEvent() {
bool CHyprlandInstance::run(bool safeMode) {
int pipefds[2];
pipe(pipefds);
if (pipe(pipefds) != 0) {
g_logger->log(Hyprutils::CLI::LOG_ERR, "pipe() failed, exiting");
exit(1);
}
m_fromHlPid = CFileDescriptor{pipefds[0]};
m_toHlPid = CFileDescriptor{pipefds[1]};
pipe(pipefds);
if (pipe(pipefds) != 0) {
g_logger->log(Hyprutils::CLI::LOG_ERR, "pipe() failed, exiting");
exit(1);
}
m_wakeupRead = CFileDescriptor{pipefds[0]};
m_wakeupWrite = CFileDescriptor{pipefds[1]};