diff --git a/fyo/models/SerialNumberSeries.ts b/fyo/models/SerialNumberSeries.ts index 47304692..f5ac78d3 100644 --- a/fyo/models/SerialNumberSeries.ts +++ b/fyo/models/SerialNumberSeries.ts @@ -27,11 +27,6 @@ export default class SerialNumberSeries extends Doc { setCurrent() { let current = this.get('current') as number | null; - /** - * Increment current if it isn't the first entry. This - * is to prevent reassignment of NumberSeries document ids. - */ - if (!current) { current = this.get('start') as number; } else { diff --git a/models/inventory/StockMovementItem.ts b/models/inventory/StockMovementItem.ts index 74dc5d7f..9ba57bbb 100644 --- a/models/inventory/StockMovementItem.ts +++ b/models/inventory/StockMovementItem.ts @@ -357,18 +357,14 @@ export class StockMovementItem extends TransferItem { return; } - try { - const serialNumbers = await generateSerialNumbersForItem( - this.fyo, - this.item, - Math.abs(this.quantity) - ); + const serialNumbers = await generateSerialNumbersForItem( + this.fyo, + this.item, + Math.abs(this.quantity) + ); - if (serialNumbers) { - await this.set('serialNumber', serialNumbers); - } - } catch (error) { - // Don't throw - allow the user to manually enter serial numbers if auto-generation fails + if (serialNumbers) { + await this.set('serialNumber', serialNumbers); } } }