From 6163f58392a02564989629a1e6fb0698c107690b Mon Sep 17 00:00:00 2001 From: AbleKSaju <126228406+AbleKSaju@users.noreply.github.com> Date: Sat, 13 Sep 2025 09:56:11 +0530 Subject: [PATCH 1/2] build: improve artifact naming for clarity --- electron-builder-config.mjs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/electron-builder-config.mjs b/electron-builder-config.mjs index 6c355d69..08d17973 100644 --- a/electron-builder-config.mjs +++ b/electron-builder-config.mjs @@ -17,6 +17,7 @@ const packageDirPath = path.join(root, 'dist_electron', 'bundled'); const frappeBooksConfig = { productName: 'Frappe Books', appId: 'io.frappe.books', + artifactName: '${productName}-v${version}-${os}-${arch}.${ext}', asarUnpack: '**/*.node', extraResources: [ { from: 'log_creds.txt', to: '../creds/log_creds.txt' }, @@ -31,6 +32,7 @@ const frappeBooksConfig = { }, mac: { type: 'distribution', + artifactName: '${productName}-v${version}-mac-${arch}.${ext}', category: 'public.app-category.finance', icon: 'build/icon.icns', notarize: { @@ -45,6 +47,7 @@ const frappeBooksConfig = { }, win: { publisherName: 'Frappe Technologies Pvt. Ltd.', + artifactName: '${productName}-v${version}-windows-${arch}-installer.${ext}', signDlls: true, icon: 'build/icon.ico', publish: ['github'], @@ -56,6 +59,8 @@ const frappeBooksConfig = { { target: 'portable', arch: ['x64', 'ia32'], + artifactName: + '${productName}-v${version}-windows-${arch}-portable.${ext}', }, ], }, @@ -69,6 +74,7 @@ const frappeBooksConfig = { }, linux: { icon: 'build/icons', + artifactName: '${productName}-v${version}-linux-${arch}-${ext}', category: 'Finance', publish: ['github'], target: [ From 95493b42ed52c43633eb24f481036a909997e417 Mon Sep 17 00:00:00 2001 From: AbleKSaju <126228406+AbleKSaju@users.noreply.github.com> Date: Sat, 13 Sep 2025 10:12:20 +0530 Subject: [PATCH 2/2] fix: artifact naming --- electron-builder-config.mjs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/electron-builder-config.mjs b/electron-builder-config.mjs index 08d17973..1cab0019 100644 --- a/electron-builder-config.mjs +++ b/electron-builder-config.mjs @@ -47,7 +47,7 @@ const frappeBooksConfig = { }, win: { publisherName: 'Frappe Technologies Pvt. Ltd.', - artifactName: '${productName}-v${version}-windows-${arch}-installer.${ext}', + artifactName: '${productName}-v${version}-windows-${arch}.${ext}', signDlls: true, icon: 'build/icon.ico', publish: ['github'], @@ -59,8 +59,6 @@ const frappeBooksConfig = { { target: 'portable', arch: ['x64', 'ia32'], - artifactName: - '${productName}-v${version}-windows-${arch}-portable.${ext}', }, ], }, @@ -74,7 +72,7 @@ const frappeBooksConfig = { }, linux: { icon: 'build/icons', - artifactName: '${productName}-v${version}-linux-${arch}-${ext}', + artifactName: '${productName}-v${version}-linux-${arch}.${ext}', category: 'Finance', publish: ['github'], target: [