starred/cli
1
0
Fork 0
mirror of https://github.com/docker/cli.git synced 2026-11-06 13:10:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7408 from GitNimay/3833-unknown-command-version-flag

Browse Source 
cmd/docker: fail on unknown command with --version
This commit is contained in:
Paweł Gronowski
2026-10-19 17:06:27 +02:00
committed by GitHub
parent f522fffe52 e08aa72569
commit 6f8369014a
2 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/docker/docker.go
+9
View File
@@ -580,6 +580,15 @@ func runDocker(ctx context.Context, dockerCli *command.DockerCli) error {
}
// Other missing or invalid plugins fall through to cmd.ExecuteContext(),
// which reports the standard unknown-command error.
//
// Cobra handles "--version" before it checks for unknown commands,
// so unset it to make "docker nonexistent --version" fail instead
// of printing the version. A global "--version" flag (as in
// "docker --version nonexistent") was already parsed, and still
// prints the version.
if !cmd.Flags().Changed("version") {
cmd.Version = ""
}
}
}