From b9312b9d889d081b4dc419ecc93a8c99c885b307 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 29 Oct 2026 18:29:37 +0100 Subject: [PATCH] scripts/build: suppress shellcheck linting Signed-off-by: Sebastiaan van Stijn --- scripts/build/.variables | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/scripts/build/.variables b/scripts/build/.variables index cb1324f49e..f6ebfbe971 100755 --- a/scripts/build/.variables +++ b/scripts/build/.variables @@ -89,12 +89,17 @@ fi export GO_BUILDMODE GO_LDFLAGS="${GO_LDFLAGS:-}" -GO_LDFLAGS="$GO_LDFLAGS -X \"github.com/docker/cli/cli/version.GitCommit=${GITCOMMIT}\"" -GO_LDFLAGS="$GO_LDFLAGS -X \"github.com/docker/cli/cli/version.BuildTime=${BUILDTIME}\"" -GO_LDFLAGS="$GO_LDFLAGS -X \"github.com/docker/cli/cli/version.Version=${VERSION}\"" -if test -n "${PLATFORM}"; then - GO_LDFLAGS="$GO_LDFLAGS -X \"github.com/docker/cli/cli/version.PlatformName=${PLATFORM}\"" -fi + +# Quotes are interpreted by Go's -ldflags parser, not the shell. +# shellcheck disable=SC2089 +{ + GO_LDFLAGS="$GO_LDFLAGS -X \"github.com/docker/cli/cli/version.GitCommit=${GITCOMMIT}\"" + GO_LDFLAGS="$GO_LDFLAGS -X \"github.com/docker/cli/cli/version.BuildTime=${BUILDTIME}\"" + GO_LDFLAGS="$GO_LDFLAGS -X \"github.com/docker/cli/cli/version.Version=${VERSION}\"" + if test -n "${PLATFORM}"; then + GO_LDFLAGS="$GO_LDFLAGS -X \"github.com/docker/cli/cli/version.PlatformName=${PLATFORM}\"" + fi +} if [ "$CGO_ENABLED" = "1" ] && [ "$GO_LINKMODE" = "static" ] && [ "$(go env GOOS)" = "linux" ]; then GO_LDFLAGS="$GO_LDFLAGS -linkmode external -extldflags -static" fi