starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-09-26 17:30:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(service): write compose .env files atomically via temp rename

Browse Source 
Replace direct .env overwrite with a unique temp file and mv so a
partial write cannot leave a truncated environment file on disk.
This commit is contained in:
Andras Bacsai
2026-09-10 09:24:37 +02:00
parent d85a7800fa
commit 0134401f7c
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/ServiceComposeConfigAtomicWriteTest.php
+14
View File
@@ -0,0 +1,14 @@
<?php
it('publishes the service environment file atomically', function () {
$source = file_get_contents(__DIR__.'/../../app/Models/Service.php');
$methodStart = strpos($source, 'public function saveComposeConfigs()');
$methodEnd = strpos($source, 'public function parse(', $methodStart);
$method = substr($source, $methodStart, $methodEnd - $methodStart);
expect($method)
->not->toContain("'rm -f .env || true'")
->toContain("new_public_id().'.env.tmp'")
->toContain('tee {$environmentFilename} > /dev/null && mv {$environmentFilename} .env')
->toContain('touch {$environmentFilename} && mv {$environmentFilename} .env');
});