starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-09-28 10:16:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove redundant process termination logic from deployment methods

Browse Source
This commit is contained in:
Andras Bacsai
2025-11-10 14:46:02 +01:00
parent 9507f602df
commit 0b8d3d395e
2 changed files with 0 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Webhook/Github.php
-19
View File
@@ -275,16 +275,6 @@ class Github extends Controller
instant_remote_process(["docker rm -f {$deployment_uuid}"], $server); instant_remote_process(["docker rm -f {$deployment_uuid}"], $server);
$activeDeployment->addLogEntry('Deployment container stopped.'); $activeDeployment->addLogEntry('Deployment container stopped.');
} }
// Kill running process if process ID exists
if ($activeDeployment->current_process_id) {
try {
$processKillCommand = "kill -9 {$activeDeployment->current_process_id}";
instant_remote_process([$processKillCommand], $server);
} catch (\Throwable $e) {
// Process might already be gone
}
}
} catch (\Throwable $e) { } catch (\Throwable $e) {
// Silently handle errors during deployment cancellation // Silently handle errors during deployment cancellation
} }
@@ -555,15 +545,6 @@ class Github extends Controller
$activeDeployment->addLogEntry('Deployment container stopped.'); $activeDeployment->addLogEntry('Deployment container stopped.');
} }
// Kill running process if process ID exists
if ($activeDeployment->current_process_id) {
try {
$processKillCommand = "kill -9 {$activeDeployment->current_process_id}";
instant_remote_process([$processKillCommand], $server);
} catch (\Throwable $e) {
// Process might already be gone
}
}
} catch (\Throwable $e) { } catch (\Throwable $e) {
// Silently handle errors during deployment cancellation // Silently handle errors during deployment cancellation
} }
app/Jobs/DeleteResourceJob.php
-9
View File
@@ -155,15 +155,6 @@ class DeleteResourceJob implements ShouldBeEncrypted, ShouldQueue
$activeDeployment->addLogEntry('Helper container not yet started. Deployment will be cancelled when job checks status.'); $activeDeployment->addLogEntry('Helper container not yet started. Deployment will be cancelled when job checks status.');
} }
// Kill running process if process ID exists
if ($activeDeployment->current_process_id) {
try {
$processKillCommand = "kill -9 {$activeDeployment->current_process_id}";
instant_remote_process([$processKillCommand], $server);
} catch (\Throwable $e) {
// Process might already be gone
}
}
} catch (\Throwable $e) { } catch (\Throwable $e) {
// Silently handle errors during deployment cancellation // Silently handle errors during deployment cancellation
} }