Mount a Docker volume inside the container.
- @if ($isSwarm)
- Swarm Mode detected: You need to set a shared
- volume
- (EFS/NFS/etc) on all the worker nodes if you would like to use a
- persistent
- volumes.
- @endif
- @if ($isSwarm)
-
- @else
-
- @endif
diff --git a/resources/views/livewire/project/shared/storages/all.blade.php b/resources/views/livewire/project/shared/storages/all.blade.php
index 17288910c9..c5e0953ac9 100644
--- a/resources/views/livewire/project/shared/storages/all.blade.php
+++ b/resources/views/livewire/project/shared/storages/all.blade.php
@@ -18,7 +18,6 @@
-
- Source Path
- {{ $displayHostPath }}
-
-
Destination Path
-
- Source Path
-
-
-
Destination Path
user()?->can('update', $resource) ?? false;
$inputsReadonly = $isReadOnly || ! $canUpdate;
- $displayHostPath = filled($hostPath) ? $hostPath : '—';
@endphp
@if ($inputsReadonly)
@@ -35,13 +34,6 @@
-
- Source Path
-
- {{ $displayHostPath }}
-
-
-
Destination Path
-
- Source Path
-
-
-
Destination Path
diff --git a/tests/Feature/Mcp/McpEndpointTest.php b/tests/Feature/Mcp/McpEndpointTest.php
index 01ba0ecf16..450dd5023f 100644
--- a/tests/Feature/Mcp/McpEndpointTest.php
+++ b/tests/Feature/Mcp/McpEndpointTest.php
@@ -12,6 +12,7 @@ use Illuminate\Support\Once;
uses(RefreshDatabase::class);
beforeEach(function () {
+ config()->set('app.maintenance.store', 'array');
InstanceSettings::query()->where('id', 0)->delete();
InstanceSettings::query()->delete();
$settings = new InstanceSettings(['is_mcp_server_enabled' => true]);
@@ -123,6 +124,7 @@ test('MCP endpoint lists tools for an authenticated token', function () {
$response->assertOk();
$toolNames = collect($response->json('result.tools'))->pluck('name')->all();
+ expect(json_encode($response->json('result.tools')))->not->toContain('host_path');
expect($toolNames)->toContain(
'get_infrastructure_overview',
'list_servers',
@@ -139,7 +141,11 @@ test('MCP endpoint lists tools for an authenticated token', function () {
'get_logs',
'list_env_keys',
);
- expect($toolNames)->not->toContain('get_resource_status');
+ expect($toolNames)->not->toContain(
+ 'get_resource_status',
+ 'create_storage',
+ 'update_storage',
+ );
expect($toolNames)->toContain('coolify_help', 'control', 'deploy');
});
diff --git a/tests/Feature/PersistentStorageVolumesLayoutTest.php b/tests/Feature/PersistentStorageVolumesLayoutTest.php
index fb00590df2..2d89d14486 100644
--- a/tests/Feature/PersistentStorageVolumesLayoutTest.php
+++ b/tests/Feature/PersistentStorageVolumesLayoutTest.php
@@ -43,6 +43,7 @@ it('keeps nested storage component keys stable when mounts are added or deleted'
->not->toContain('wire:key="svc-volumes-{{ $resource->id }}-{{ $this->volumeCount }}"');
});
+use App\Livewire\Project\Service\Storage;
use App\Livewire\Project\Service\VolumeBackup\Create as CreateServiceVolumeBackup;
use App\Livewire\Project\Shared\Storages\All;
use App\Models\Application;
@@ -147,7 +148,7 @@ it('renders volumes as a data table with shared column headers', function () {
->toContain('volumes-table-grid')
->toContain('volumes-table-grid-readonly')
->toContain('Volume Name')
- ->toContain('Source Path')
+ ->not->toContain('Source Path')
->toContain('Destination Path')
->toContain('volumes-col-backup')
->toContain('supportsPreviewSuffix')
@@ -222,6 +223,43 @@ it('renders volumes as a data table with shared column headers', function () {
->toMatch('/\.application-settings-form label\s*\{[^}]*font-size:\s*13px/s');
});
+it('keeps source paths out of the Docker volume creation form', function () {
+ $view = file_get_contents(resource_path('views/livewire/project/service/storage.blade.php'));
+
+ expect($view)
+ ->not->toContain('id="host_path"')
+ ->not->toContain('label="Source Path"')
+ ->not->toContain('Swarm Mode detected');
+});
+
+it('creates named Docker volumes without a source path in swarm mode', function () {
+ [$application] = createApplicationWithVolume();
+ $application->persistentStorages()->delete();
+
+ Livewire::test(Storage::class, ['resource' => $application])
+ ->set('isSwarm', true)
+ ->set('name', 'storage-app-data')
+ ->set('mount_path', '/data')
+ ->call('submitPersistentVolume')
+ ->assertHasNoErrors();
+
+ expect($application->persistentStorages()->first()->host_path)->toBeNull();
+});
+
+it('removes the source path column from Docker volume views', function () {
+ $allView = file_get_contents(resource_path('views/livewire/project/shared/storages/all.blade.php'));
+ $showView = file_get_contents(resource_path('views/livewire/project/shared/storages/show.blade.php'));
+
+ expect($allView)
+ ->not->toContain('Source Path')
+ ->not->toContain('volumes-col-source')
+ ->not->toContain('forms.{{ $id }}.hostPath')
+ ->and($showView)
+ ->not->toContain('Source Path')
+ ->not->toContain('volumes-col-source')
+ ->not->toContain('id="hostPath"');
+});
+
it('renders volume actions and PR suffix controls as valid markup', function () {
[$application] = createApplicationWithVolume();
LocalPersistentVolume::create([
diff --git a/tests/Feature/StorageApiTest.php b/tests/Feature/StorageApiTest.php
index 2f5a823749..aadcd163b5 100644
--- a/tests/Feature/StorageApiTest.php
+++ b/tests/Feature/StorageApiTest.php
@@ -621,3 +621,70 @@ describe('DELETE /api/v1/databases/{uuid}/storages/{storage_uuid}', function ()
expect(LocalPersistentVolume::find($vol->id))->toBeNull();
});
});
+
+test('rejects host paths when creating persistent storage through the API', function (string $resourceType) {
+ if ($resourceType === 'application') {
+ $resource = createTestApplication($this);
+ $url = "/api/v1/applications/{$resource->uuid}/storages";
+ $payload = [];
+ } elseif ($resourceType === 'database') {
+ $resource = createTestDatabase($this);
+ $url = "/api/v1/databases/{$resource->uuid}/storages";
+ $payload = [];
+ } else {
+ [$service, $resource] = createTestServiceApplication($this);
+ $url = "/api/v1/services/{$service->uuid}/storages";
+ $payload = ['resource_uuid' => $resource->uuid];
+ }
+
+ $storageCountBefore = $resource->persistentStorages()->count();
+
+ $response = $this->withHeaders([
+ 'Authorization' => 'Bearer '.$this->bearerToken,
+ 'Content-Type' => 'application/json',
+ ])->postJson($url, array_merge($payload, [
+ 'type' => 'persistent',
+ 'name' => 'blocked-bind-mount',
+ 'mount_path' => '/data',
+ 'host_path' => '/srv/data',
+ ]));
+
+ $response->assertUnprocessable()
+ ->assertJsonPath('errors.host_path.0', 'This field is not allowed.');
+
+ expect($resource->persistentStorages()->count())->toBe($storageCountBefore);
+})->with(['application', 'database', 'service']);
+
+test('rejects host paths when updating persistent storage through the API', function (string $resourceType) {
+ if ($resourceType === 'application') {
+ $resource = createTestApplication($this);
+ $url = "/api/v1/applications/{$resource->uuid}/storages";
+ } elseif ($resourceType === 'database') {
+ $resource = createTestDatabase($this);
+ $url = "/api/v1/databases/{$resource->uuid}/storages";
+ } else {
+ [$service, $resource] = createTestServiceApplication($this);
+ $url = "/api/v1/services/{$service->uuid}/storages";
+ }
+
+ $storage = LocalPersistentVolume::create([
+ 'name' => $resource->uuid.'-data',
+ 'mount_path' => '/data',
+ 'resource_id' => $resource->id,
+ 'resource_type' => $resource->getMorphClass(),
+ ]);
+
+ $response = $this->withHeaders([
+ 'Authorization' => 'Bearer '.$this->bearerToken,
+ 'Content-Type' => 'application/json',
+ ])->patchJson($url, [
+ 'uuid' => $storage->uuid,
+ 'type' => 'persistent',
+ 'host_path' => '/srv/data',
+ ]);
+
+ $response->assertUnprocessable()
+ ->assertJsonPath('errors.host_path.0', 'This field is not allowed.');
+
+ expect($storage->refresh()->host_path)->toBeNull();
+})->with(['application', 'database', 'service']);