From 29b93c7ef01b1412a6ee93a73a5c9021f9a503d7 Mon Sep 17 00:00:00 2001 From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com> Date: Mon, 21 Sep 2026 22:59:20 +0200 Subject: [PATCH] fix(reverb): always start Reverb service in containers --- docker/development/etc/s6-overlay/s6-rc.d/reverb/run | 7 +------ docker/production/etc/s6-overlay/s6-rc.d/reverb/run | 7 +------ tests/Feature/ReverbAndTerminalPackagingTest.php | 2 ++ 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/docker/development/etc/s6-overlay/s6-rc.d/reverb/run b/docker/development/etc/s6-overlay/s6-rc.d/reverb/run index c189a24057..e35e88a6cb 100755 --- a/docker/development/etc/s6-overlay/s6-rc.d/reverb/run +++ b/docker/development/etc/s6-overlay/s6-rc.d/reverb/run @@ -2,10 +2,5 @@ cd /var/www/html -if grep -qE '^PUSHER_ENABLED=false' .env 2>/dev/null; then - echo " INFO Reverb is disabled, sleeping." - exec sleep infinity -fi - -echo " INFO Reverb is enabled, starting..." +echo " INFO Reverb is starting..." exec php artisan reverb:start --host=0.0.0.0 --port=${PUSHER_BACKEND_PORT:-6001} diff --git a/docker/production/etc/s6-overlay/s6-rc.d/reverb/run b/docker/production/etc/s6-overlay/s6-rc.d/reverb/run index c189a24057..e35e88a6cb 100755 --- a/docker/production/etc/s6-overlay/s6-rc.d/reverb/run +++ b/docker/production/etc/s6-overlay/s6-rc.d/reverb/run @@ -2,10 +2,5 @@ cd /var/www/html -if grep -qE '^PUSHER_ENABLED=false' .env 2>/dev/null; then - echo " INFO Reverb is disabled, sleeping." - exec sleep infinity -fi - -echo " INFO Reverb is enabled, starting..." +echo " INFO Reverb is starting..." exec php artisan reverb:start --host=0.0.0.0 --port=${PUSHER_BACKEND_PORT:-6001} diff --git a/tests/Feature/ReverbAndTerminalPackagingTest.php b/tests/Feature/ReverbAndTerminalPackagingTest.php index 9be07c046f..1461ec9707 100644 --- a/tests/Feature/ReverbAndTerminalPackagingTest.php +++ b/tests/Feature/ReverbAndTerminalPackagingTest.php @@ -26,6 +26,8 @@ it('runs Reverb and terminal websocket services inside the Coolify containers', ->toContain('npm ci --prefix /terminal') ->and(file_get_contents(base_path(dirname($dockerfile).'/etc/s6-overlay/s6-rc.d/reverb/run'))) ->toContain('exec php artisan reverb:start --host=0.0.0.0 --port=${PUSHER_BACKEND_PORT:-6001}') + ->not->toContain('PUSHER_ENABLED') + ->not->toContain('Reverb is disabled') ->and(file_get_contents(base_path(dirname($dockerfile).'/etc/s6-overlay/s6-rc.d/terminal-server/run'))) ->toContain('exec node /terminal/terminal-server.js') ->and(file_exists(base_path(dirname($dockerfile)."/etc/s6-overlay/s6-rc.d/reverb/dependencies.d/{$dependencyService}")))->toBeTrue()