starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-11-06 13:10:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(github): paginate PR files for watch paths and reuse installation tokens

Browse Source 
- Fetch every page of pull request files so watch paths match PRs with more than 30 files.
- Deploy the preview and log a warning when the changed-file list is unknown (API error or truncated compare list).
- Log when watch paths decline a preview deployment.
- Keep the GitHub App installation token in memory per instance, so a deployment requests one token instead of 3-5.

Closes #12169
This commit is contained in:
Andras Bacsai
2026-10-15 14:45:45 +02:00
parent 5f78e3dfb3
commit 2c973d68c4
6 changed files with 384 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Jobs/ProcessGithubPullRequestWebhook.php
+21 -7
View File
@@ -14,6 +14,7 @@ use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Facades\Log;
use Throwable;
class ProcessGithubPullRequestWebhook implements ShouldBeEncrypted, ShouldQueue
@@ -127,21 +128,34 @@ class ProcessGithubPullRequestWebhook implements ShouldBeEncrypted, ShouldQueue
}
}
// Get changed files for watch path filtering
$changed_files = collect();
// Get changed files for watch path filtering (null means the full list is unknown)
$changed_files = [];
if ($this->action === 'synchronize' && $this->beforeSha && $this->afterSha) {
// For synchronize events, get files changed between before and after commits
$changed_files = collect(getGithubCommitRangeFiles($githubApp, $owner, $repo, $this->beforeSha, $this->afterSha));
$changed_files = getGithubCommitRangeFiles($githubApp, $owner, $repo, $this->beforeSha, $this->afterSha);
} elseif ($this->action === 'opened' || $this->action === 'reopened') {
// For opened/reopened events, get all files in the PR
$changed_files = collect(getGithubPullRequestFiles($githubApp, $owner, $repo, $this->pullRequestId));
$changed_files = getGithubPullRequestFiles($githubApp, $owner, $repo, $this->pullRequestId);
}
// Apply watch path filtering
$is_watch_path_triggered = $application->isWatchPathsTriggered($changed_files);
if (! $is_watch_path_triggered && ! blank($application->watch_paths)) {
return;
if (! blank($application->watch_paths)) {
$logContext = [
'application_uuid' => $application->uuid,
'pull_request_id' => $this->pullRequestId,
'action' => $this->action,
];
if (is_null($changed_files)) {
Log::warning('Could not get the full list of changed files from GitHub. Deploying the pull request preview without the watch paths check.', $logContext);
} elseif (! $application->isWatchPathsTriggered(collect($changed_files))) {
Log::info('Skipped GitHub pull request preview deployment because no changed file matches the watch paths.', $logContext + [
'changed_files_count' => count($changed_files),
]);
return;
}
}
// Create ApplicationPreview if not exists