From 344b0dff5e5587e86a2c648669311be832fb97c5 Mon Sep 17 00:00:00 2001 From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com> Date: Wed, 9 Sep 2026 13:04:00 +0200 Subject: [PATCH] test(api): assert abilities on all database import routes --- tests/Feature/Api/DatabaseImportRoutesTest.php | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/tests/Feature/Api/DatabaseImportRoutesTest.php b/tests/Feature/Api/DatabaseImportRoutesTest.php index db62b9af19..a91e160356 100644 --- a/tests/Feature/Api/DatabaseImportRoutesTest.php +++ b/tests/Feature/Api/DatabaseImportRoutesTest.php @@ -3,12 +3,19 @@ use Illuminate\Support\Facades\Route; test('registers standalone and service database import routes with abilities', function () { - $routes = collect(Route::getRoutes()->getRoutes())->keyBy(fn ($route) => $route->getName()); + $routes = collect(Route::getRoutes()->getRoutesByName()); - foreach (['api.databases.imports.upload', 'api.databases.imports.store', 'api.databases.imports.show', 'api.service-databases.imports.upload', 'api.service-databases.imports.store', 'api.service-databases.imports.show'] as $name) { + $expected = [ + 'api.databases.imports.upload' => 'api.ability:deploy', + 'api.databases.imports.store' => 'api.ability:deploy', + 'api.databases.imports.show' => 'api.ability:read', + 'api.service-databases.imports.upload' => 'api.ability:deploy', + 'api.service-databases.imports.store' => 'api.ability:deploy', + 'api.service-databases.imports.show' => 'api.ability:read', + ]; + + foreach ($expected as $name => $ability) { expect($routes)->toHaveKey($name); + expect($routes[$name]->gatherMiddleware())->toContain($ability); } - - expect($routes['api.databases.imports.store']->gatherMiddleware())->toContain('api.ability:deploy') - ->and($routes['api.databases.imports.show']->gatherMiddleware())->toContain('api.ability:read'); });