starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-09-26 17:30:46 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(service): avoid storing inherited ports as overrides

Browse Source
This commit is contained in:
Andras Bacsai
2026-09-10 12:08:06 +02:00
parent 0134401f7c
commit 36befcfecd
4 changed files with 27 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Livewire/Project/Service/Domains.php
+13 -7
View File
@@ -1180,11 +1180,9 @@ class Domains extends Component
$this->editingIndex = $index;
$this->editingDomain = $this->domainRows[$index]['url'];
$this->editingDomainParts = DomainUrlParts::split($this->editingDomain);
$app = $this->findServiceApp((int) $this->domainRows[$index]['service_application_id']);
$canonical = DomainPortOverrides::withoutPort($this->editingDomain);
$savedPort = ($app?->domain_port_overrides ?? [])[$canonical] ?? null;
if (filled($savedPort)) {
$this->editingDomainParts['port'] = (string) $savedPort;
$internalPort = $this->domainRows[$index]['internal_port'] ?? null;
if (filled($internalPort)) {
$this->editingDomainParts['port'] = (string) $internalPort;
}
$this->editingDomainPartsChanged = false;
$this->editingServiceApplicationId = (int) $this->domainRows[$index]['service_application_id'];
@@ -1219,8 +1217,16 @@ class Domains extends Component
return;
}
if ($this->editingDomainPartsChanged || filled($this->editingDomainParts['host'] ?? null)) {
$this->editingDomain = DomainUrlParts::compose(...$this->editingDomainParts);
$editingDomainParts = $this->editingDomainParts;
$editingRow = $this->domainRows[$this->editingIndex];
if (
! ($editingRow['has_port_override'] ?? false)
&& (string) ($editingDomainParts['port'] ?? '') === (string) ($editingRow['internal_port'] ?? '')
) {
$editingDomainParts['port'] = '';
}
if ($this->editingDomainPartsChanged || filled($editingDomainParts['host'] ?? null)) {
$this->editingDomain = DomainUrlParts::compose(...$editingDomainParts);
}
$this->validateOnly('editingDomain');