starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-11-06 13:10:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): load no favicon from domains behind HTTP basic auth

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Andras Bacsai
2026-10-24 10:23:49 +02:00
co-authored by Claude Opus 5.5
parent 6c270a42db
commit 465344f1bc
7 changed files with 70 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bootstrap/helpers/services.php
+5 -2
View File
@@ -55,7 +55,8 @@ function resource_logo_url(string $name): string
* the service template, or how the application is built. Null when there is no specific logo.
*
* Applications with a domain also get the favicon URL of their first domain. The browser loads it
* and shows it in place of the logo when it loads. Coolify itself never requests it.
* and shows it in place of the logo when it loads. Coolify itself never requests it. Applications
* behind HTTP basic auth get no favicon: the request makes the browser ask for the credentials.
*
* @return array{src: string, dark: ?string, fallback: ?string, padded: bool, favicon: ?string}|null
*/
@@ -93,7 +94,9 @@ function resource_logo(Model $resource): ?array
default => $resourceLogo('public-repo'),
};
return [...$logo, 'favicon' => resource_favicon_url($resource->fqdn)];
$favicon = $resource->is_http_basic_auth_enabled ? null : resource_favicon_url($resource->fqdn);
return [...$logo, 'favicon' => $favicon];
}
if (! method_exists($resource, 'type')) {