starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-11-06 13:10:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(previews): isolate NFS and CIFS volumes from production

Browse Source
This commit is contained in:
Andras Bacsai
2026-10-05 22:27:49 +02:00
parent b08383805c
commit 9a11407e2f
2 changed files with 36 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Feature/ComposeVolumeDriverOptionsTest.php
+20
View File
@@ -288,6 +288,26 @@ describe('applicationParser', function () {
expect($parsed['services']['web']['volumes'])->toBe(['nfs-data:/nfs', "{$uuid}_app-data:/app"])
->and($parsed['volumes']['nfs-data']['driver_opts']['type'])->toBe('nfs');
});
it('gives the preview its own volume instead of the network volume of production', function (string $type, string $device) {
// The preview must not mount the network share of production: two deployments that write into the
// same data directory (for example two databases) can corrupt it.
$compose = str_replace(['type: nfs', "':/exports/data'"], ["type: {$type}", "'{$device}'"], DRIVER_OPTIONS_NFS_MIXED_COMPOSE);
$application = driverOptionsApplication($compose);
$uuid = $application->uuid;
$preview = driverOptionsPreview($application);
$name = addPreviewDeploymentSuffix("{$uuid}_nfs-data", 42);
$parsed = applicationParser($application, 42, $preview->id)->toArray();
expect($parsed['services']['web-pr-42']['volumes'])->toBe(["{$name}:/nfs", addPreviewDeploymentSuffix("{$uuid}_app-data", 42).':/app'])
->and($parsed['volumes'])->not->toHaveKey('nfs-data')
->and($parsed['volumes'][$name])->toBe(['name' => $name])
->and(LocalPersistentVolume::where('resource_id', $application->id)->where('name', $name)->exists())->toBeTrue();
})->with([
'nfs' => ['nfs', ':/exports/data'],
'cifs' => ['cifs', '//10.0.0.1/share'],
]);
});
describe('serviceParser', function () {