starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-11-06 21:18:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(application): reject Docker image names shared by building applications

Browse Source 
Two applications that build the same Docker image name push the same
tags (commit SHA, latest, pr-<id>), so one can run the image of the
other. Deployments, the General form, and the API now reject such a
name for applications of the same team.

Closes #9834
This commit is contained in:
Andras Bacsai
2026-10-29 11:30:25 +01:00
parent 3048e9948c
commit b41ba87fff
5 changed files with 254 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Api/ApplicationsController.php
+29
View File
@@ -222,6 +222,19 @@ class ApplicationsController extends Controller
], 422);
}
private function sharedImageNameValidationResponse(Application $application): ?JsonResponse
{
$otherApplication = $application->otherApplicationBuildingSameImage();
if (! $otherApplication) {
return null;
}
return response()->json([
'message' => 'Validation failed.',
'errors' => ['docker_registry_image_name' => [$application->sharedImageNameMessage($otherApplication)]],
], 422);
}
private function applyApplicationSettings(Application $application, array $settings): void
{
if ($settings === []) {
@@ -1665,6 +1678,9 @@ class ApplicationsController extends Controller
$application->destination_id = $destination->id;
$application->destination_type = $destination->getMorphClass();
$application->environment_id = $environment->id;
if ($imageNameValidation = $this->sharedImageNameValidationResponse($application)) {
return $imageNameValidation;
}
$application->save();
$this->applyApplicationSettings($application, $applicationSettings);
if (isset($isStatic)) {
@@ -1925,6 +1941,9 @@ class ApplicationsController extends Controller
$application->source_id = $githubApp->id;
$application->repository_project_id = $repository_project_id;
if ($imageNameValidation = $this->sharedImageNameValidationResponse($application)) {
return $imageNameValidation;
}
$application->save();
$this->applyApplicationSettings($application, $applicationSettings);
$application->refresh();
@@ -2154,6 +2173,9 @@ class ApplicationsController extends Controller
$application->destination_id = $destination->id;
$application->destination_type = $destination->getMorphClass();
$application->environment_id = $environment->id;
if ($imageNameValidation = $this->sharedImageNameValidationResponse($application)) {
return $imageNameValidation;
}
$application->save();
$this->applyApplicationSettings($application, $applicationSettings);
$application->refresh();
@@ -2302,6 +2324,9 @@ class ApplicationsController extends Controller
$application->git_repository = 'coollabsio/coolify';
$application->git_branch = 'main';
if ($imageNameValidation = $this->sharedImageNameValidationResponse($application)) {
return $imageNameValidation;
}
$application->save();
$this->applyApplicationSettings($application, $applicationSettings);
$application->refresh();
@@ -3525,6 +3550,10 @@ class ApplicationsController extends Controller
if ($prefixValidation = $this->containerNamePrefixValidationResponse($applicationSettings, $application->destination->server, $application)) {
return $prefixValidation;
}
$requestedImage = (clone $application)->fill($request->only(['docker_registry_image_name', 'build_pack']));
if ($requestedImage->isDirty(['docker_registry_image_name', 'build_pack']) && $imageNameValidation = $this->sharedImageNameValidationResponse($requestedImage)) {
return $imageNameValidation;
}
if ($internalNameValidation = $this->customInternalNameValidationResponse($applicationSettings)) {
return $internalNameValidation;
}