starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-08-24 02:24:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(upgrade): persist target image before container recreation (#11401)

Browse Source
This commit is contained in:
Andras Bacsai
2026-08-19 12:18:05 +02:00
committed by GitHub
parent 534f22a0df
commit c3a86b054a
3 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
other/nightly/upgrade.sh
+3
View File
@@ -216,6 +216,9 @@ done
log "All images pulled successfully"
echo " All images pulled successfully."
set_env_var "LATEST_IMAGE" "$LATEST_IMAGE"
set_env_var "COOLIFY_VERSION" "$LATEST_IMAGE"
log_section "Step 4/6: Stopping and restarting containers"
write_status "4" "Stopping containers"
echo ""
scripts/upgrade.sh
+3
View File
@@ -229,6 +229,9 @@ done
log "All images pulled successfully"
echo " All images pulled successfully."
set_env_var "LATEST_IMAGE" "$LATEST_IMAGE"
set_env_var "COOLIFY_VERSION" "$LATEST_IMAGE"
log_section "Step 4/6: Stopping and restarting containers"
write_status "4" "Stopping containers"
echo ""
tests/Unit/UpgradePostgresScriptTest.php
+29
View File
@@ -62,6 +62,35 @@ it('persists the selected registry url during upgrades', function (string $path)
'nightly upgrade' => 'other/nightly/upgrade.sh',
]);
it('persists the target image and runtime version before recreating containers', function (string $path) {
$script = file_get_contents(getcwd().'/'.$path);
if ($script === false) {
throw new RuntimeException("Unable to read {$path}");
}
$position = static function (string $needle) use ($script): int {
$offset = strpos($script, $needle);
if ($offset === false) {
throw new RuntimeException("Missing marker: {$needle}");
}
return $offset;
};
$latestImagePosition = $position('set_env_var "LATEST_IMAGE" "$LATEST_IMAGE"');
$coolifyVersionPosition = $position('set_env_var "COOLIFY_VERSION" "$LATEST_IMAGE"');
$imagesPulledPosition = $position('log "All images pulled successfully"');
$composeUpPosition = $position('docker compose --env-file /data/coolify/source/.env');
expect($latestImagePosition)->toBeGreaterThan($imagesPulledPosition)
->and($coolifyVersionPosition)->toBeGreaterThan($imagesPulledPosition)
->and($latestImagePosition)->toBeLessThan($composeUpPosition)
->and($coolifyVersionPosition)->toBeLessThan($composeUpPosition);
})->with([
'stable upgrade' => 'scripts/upgrade.sh',
'nightly upgrade' => 'other/nightly/upgrade.sh',
]);
it('uses the existing env registry url when old callers do not pass a registry argument', function (string $path) {
$script = file_get_contents(getcwd().'/'.$path);