fix(deploy): keep start-time buildpack vars in runtime env (#12025)

2026-11-06 13:10:37 -04:00 · 2026-10-14 09:43:55 +02:00
parent dc6777a71d
commit d196dd322f
4 changed files with 110 additions and 2 deletions
@@ -943,6 +943,93 @@ it('filters buildpack control vars from preview runtime env fallback', function
    expect($runtimeEnvs->contains(fn (string $env) => str($env)->startsWith('RAILPACK_NODE_VERSION=')))->toBeFalse();
 });

+it('keeps buildpack variables read at container start in the runtime env', function (int $pullRequestId, bool $isPreview) {
+    [$application, $server] = makeDeploymentControlVarFixture(['build_pack' => 'nixpacks']);
+
+    foreach ([
+        'APP_NAME' => 'coolify',
+        'NIXPACKS_PHP_ROOT_DIR' => '/app/public',
+        'NIXPACKS_PHP_FALLBACK_PATH' => '/index.php',
+        'NIXPACKS_SPA_OUTPUT_DIR' => 'dist',
+        'RAILPACK_SKIP_MIGRATIONS' => 'true',
+        'NIXPACKS_NODE_VERSION' => '22',
+        'RAILPACK_NODE_VERSION' => '20',
+    ] as $key => $value) {
+        createApplicationEnvironmentVariable($application, [
+            'key' => $key,
+            'value' => $value,
+            'is_preview' => $isPreview,
+        ]);
+    }
+
+    [$job, $reflection] = makeControlVarFilteringJob($application, $server, [
+        'pull_request_id' => $pullRequestId,
+    ]);
+
+    /** @var Collection $runtimeEnvs */
+    $runtimeEnvs = invokeDeploymentJobMethod($job, $reflection, 'generate_runtime_environment_variables');
+
+    expect($runtimeEnvs)->toContain(
+        'APP_NAME='.escapeComposeEnvFileValue('coolify'),
+        'NIXPACKS_PHP_ROOT_DIR='.escapeComposeEnvFileValue('/app/public'),
+        'NIXPACKS_PHP_FALLBACK_PATH='.escapeComposeEnvFileValue('/index.php'),
+        'NIXPACKS_SPA_OUTPUT_DIR='.escapeComposeEnvFileValue('dist'),
+        'RAILPACK_SKIP_MIGRATIONS='.escapeComposeEnvFileValue('true'),
+    );
+    expect($runtimeEnvs->contains(fn (string $env) => str($env)->startsWith('NIXPACKS_NODE_VERSION=')))->toBeFalse();
+    expect($runtimeEnvs->contains(fn (string $env) => str($env)->startsWith('RAILPACK_NODE_VERSION=')))->toBeFalse();
+})->with([
+    'production' => [0, false],
+    'preview' => [42, true],
+]);
+
+it('keeps buildpack variables read at container start out of generic build args', function () {
+    [$application, $server] = makeDeploymentControlVarFixture();
+
+    createApplicationEnvironmentVariable($application, [
+        'key' => 'NIXPACKS_PHP_ROOT_DIR',
+        'value' => '/app/public',
+    ]);
+    createApplicationEnvironmentVariable($application, [
+        'key' => 'RAILPACK_SKIP_MIGRATIONS',
+        'value' => 'true',
+    ]);
+
+    [$job, $reflection] = makeControlVarFilteringJob($application, $server);
+
+    invokeDeploymentJobMethod($job, $reflection, 'generate_env_variables');
+
+    /** @var Collection $envArgs */
+    $envArgs = readDeploymentJobProperty($job, $reflection, 'env_args');
+
+    expect($envArgs->has('NIXPACKS_PHP_ROOT_DIR'))->toBeFalse();
+    expect($envArgs->has('RAILPACK_SKIP_MIGRATIONS'))->toBeFalse();
+});
+
+it('creates missing Laravel defaults as preview variables for preview deployments', function () {
+    [$application, $server] = makeDeploymentControlVarFixture(['build_pack' => 'nixpacks']);
+
+    $keys = ['NIXPACKS_PHP_ROOT_DIR', 'NIXPACKS_PHP_FALLBACK_PATH'];
+    foreach (array_combine($keys, ['/app/web', '/app.php']) as $key => $value) {
+        createApplicationEnvironmentVariable($application, ['key' => $key, 'value' => $value]);
+    }
+    $application->environment_variables_preview()->whereIn('key', $keys)->delete();
+
+    [$job, $reflection] = makeControlVarFilteringJob($application, $server, ['pull_request_id' => 42]);
+
+    [$fallbackPath, $rootDir] = invokeDeploymentJobMethod($job, $reflection, 'laravel_finetunes');
+
+    expect($fallbackPath->is_preview)->toBeTrue()
+        ->and($fallbackPath->value)->toBe('/index.php')
+        ->and($rootDir->is_preview)->toBeTrue()
+        ->and($rootDir->value)->toBe('/app/public')
+        ->and($application->environment_variables()->whereIn('key', $keys)->pluck('value', 'key')->all())->toBe([
+            'NIXPACKS_PHP_ROOT_DIR' => '/app/web',
+            'NIXPACKS_PHP_FALLBACK_PATH' => '/app.php',
+        ])
+        ->and($application->environment_variables_preview()->whereIn('key', $keys)->count())->toBe(2);
+});
+
 it('filters buildpack control vars from dockerfile arg injection', function () {
    [$application, $server] = makeDeploymentControlVarFixture();