fix(s3): allow uppercase letters in S3 bucket names

S3-compatible and legacy buckets may include uppercase letters. Relax the bucket name pattern, validation messages, and tests so those names are accepted while still rejecting invalid characters and formats.

tests/Unit/Project/Database/ImportCheckFileButtonTest.php

@@ -39,6 +39,7 @@ test('validateBucketName accepts valid bucket names', function () {
     expect($method->invoke($component, 'my-bucket'))->toBeTrue();
     expect($method->invoke($component, 'mybucket123'))->toBeTrue();
     expect($method->invoke($component, 'my.bucket.name'))->toBeTrue();
+    expect($method->invoke($component, 'Legacy-Bucket'))->toBeTrue();
 });
 
 test('validateBucketName rejects invalid bucket names', function () {
@@ -54,7 +55,6 @@ test('validateBucketName rejects invalid bucket names', function () {
     expect($method->invoke($component, "bucket\nid"))->toBeFalse();
     expect($method->invoke($component, 'bucket name'))->toBeFalse(); // Space not allowed in bucket
     expect($method->invoke($component, 'my_bucket'))->toBeFalse();
-    expect($method->invoke($component, 'Bucket-Name'))->toBeFalse();
     expect($method->invoke($component, '192.168.1.1'))->toBeFalse();
 });
 

tests/Unit/S3StorageTest.php

@@ -1,6 +1,7 @@
 <?php
 
 use App\Models\S3Storage;
+use Illuminate\Filesystem\FilesystemAdapter;
 use Illuminate\Support\Facades\Storage;
 use Tests\TestCase;
 
@@ -67,7 +68,7 @@ test('S3Storage model fillable attributes are configured correctly', function ()
 });
 
 test('S3Storage connection validation uses short s3 client timeouts', function () {
-    $disk = Mockery::mock();
+    $disk = Mockery::mock(FilesystemAdapter::class);
     $disk->expects('files')->once()->andReturn([]);
 
     Storage::expects('build')
@@ -87,7 +88,7 @@ test('S3Storage connection validation uses short s3 client timeouts', function (
         'region' => 'us-east-1',
         'key' => null,
         'secret' => null,
-        'bucket' => 'test-bucket',
+        'bucket' => 'Test-Bucket',
         'endpoint' => 'https://s3.amazonaws.com',
     ]);
 
@@ -97,7 +98,7 @@ test('S3Storage connection validation uses short s3 client timeouts', function (
 });
 
 test('S3Storage connection validation returns friendly timeout error', function () {
-    $disk = Mockery::mock();
+    $disk = Mockery::mock(FilesystemAdapter::class);
     $disk->expects('files')
         ->once()
         ->andThrow(new RuntimeException('cURL error 28: Operation timed out after 15000 milliseconds'));
@@ -142,5 +143,4 @@ test('S3Storage testConnection rejects invalid bucket before building client', f
     'backticks' => ['lab`id`'],
     'newline' => ["lab\nid"],
     'underscore' => ['lab_bucket'],
-    'uppercase' => ['LabBucket'],
 ]);

tests/Unit/ValidS3BucketNameTest.php

@@ -18,6 +18,7 @@ it('accepts valid s3 bucket names', function (string $bucket) {
 })->with([
     'short' => ['abc'],
     'simple' => ['coolify-backups'],
+    'legacy uppercase' => ['CoolifyBackups'],
     'dots' => ['coolify.backups'],
     'digits' => ['backup-123'],
     'max length' => [str_repeat('a', 63)],
@@ -28,7 +29,6 @@ it('rejects invalid s3 bucket names and injection payloads', function (string $b
 })->with([
     'too short' => ['ab'],
     'too long' => [str_repeat('a', 64)],
-    'uppercase' => ['CoolifyBackups'],
     'underscore' => ['coolify_backups'],
     'leading hyphen' => ['-coolify-backups'],
     'trailing hyphen' => ['coolify-backups-'],