starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-10-06 14:07:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(s3): allow uppercase letters in S3 bucket names

Browse Source 
S3-compatible and legacy buckets may include uppercase letters. Relax the bucket name pattern, validation messages, and tests so those names are accepted while still rejecting invalid characters and formats.
This commit is contained in:
Andras Bacsai
2026-09-10 15:12:53 +02:00
parent 3f1235158d
commit d24ee35824
9 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/Project/Database/ImportCheckFileButtonTest.php
+1 -1
View File
@@ -39,6 +39,7 @@ test('validateBucketName accepts valid bucket names', function () {
expect($method->invoke($component, 'my-bucket'))->toBeTrue();
expect($method->invoke($component, 'mybucket123'))->toBeTrue();
expect($method->invoke($component, 'my.bucket.name'))->toBeTrue();
expect($method->invoke($component, 'Legacy-Bucket'))->toBeTrue();
});
test('validateBucketName rejects invalid bucket names', function () {
@@ -54,7 +55,6 @@ test('validateBucketName rejects invalid bucket names', function () {
expect($method->invoke($component, "bucket\nid"))->toBeFalse();
expect($method->invoke($component, 'bucket name'))->toBeFalse(); // Space not allowed in bucket
expect($method->invoke($component, 'my_bucket'))->toBeFalse();
expect($method->invoke($component, 'Bucket-Name'))->toBeFalse();
expect($method->invoke($component, '192.168.1.1'))->toBeFalse();
});