starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-11-06 13:10:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(upgrade): prevent duplicate upgrades and stalled progress polling

Browse Source 
Block new upgrades while a recent upgrade is running, allowing retries after 15 minutes without a status update.

Add request timeouts and polling guards to keep upgrade progress responsive during restarts.
This commit is contained in:
Andras Bacsai
2026-10-09 08:01:20 +02:00
parent 3f953d1dce
commit df953bdcd1
6 changed files with 184 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Unit/UpdateCoolifyTest.php
+47
View File
@@ -40,6 +40,19 @@ function updateCoolifyTestCreateRootServerAndSettings(array $settings = []): voi
Once::flush();
}
function updateCoolifyTestActionWithStatus(string $status): UpdateCoolify
{
return new class($status) extends UpdateCoolify
{
public function __construct(private string $status) {}
protected function readUpgradeStatus(): ?string
{
return $this->status;
}
};
}
afterEach(function () {
Mockery::close();
});
@@ -316,3 +329,37 @@ it('prevents downgrade even with manual update', function () {
expect($e->getMessage())->toContain('4.0.0');
}
});
it('does not start a second upgrade while a recent upgrade status is in progress', function () {
Queue::fake();
config([
'app.env' => 'testing',
'constants.coolify.version' => '4.0.9',
'constants.ssh.mux_enabled' => false,
]);
updateCoolifyTestCreateRootServerAndSettings();
Http::fake(['*' => Http::response(['coolify' => ['v4' => ['version' => '4.0.10']]], 200)]);
$action = updateCoolifyTestActionWithStatus('3|Pulling Docker images|'.now()->subMinutes(2)->toIso8601String());
expect(fn () => $action->handle(manual_update: true))
->toThrow(Exception::class, 'Another Coolify upgrade is already running');
expect(Activity::query()->count())->toBe(0)
->and(InstanceSettings::findOrFail(0)->new_version_available)->toBeFalsy();
});
it('starts an upgrade when the previous upgrade status is older than the lock expiry', function () {
Queue::fake();
config([
'app.env' => 'testing',
'constants.coolify.version' => '4.0.9',
'constants.ssh.mux_enabled' => false,
]);
updateCoolifyTestCreateRootServerAndSettings();
Http::fake(['*' => Http::response(['coolify' => ['v4' => ['version' => '4.0.10']]], 200)]);
updateCoolifyTestActionWithStatus('3|Pulling Docker images|'.now()->subMinutes(16)->toIso8601String())
->handle(manual_update: true);
expect(RemoteProcessCommand::read(Activity::query()->latest('id')->first()))
->toContain("bash /data/coolify/source/upgrade.sh '4.0.10'");
});