starred/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-11-06 13:10:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(ports): skip the PORT mismatch warning when readonly labels are disabled

Browse Source 
Closes #10941

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Andras Bacsai
2026-10-26 13:24:36 +01:00
co-authored by Claude Opus 5.5
parent 271849c88e
commit ea1b701a94
4 changed files with 95 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Feature/ApplicationDeploymentControlVarFilteringTest.php
+21
View File
@@ -2029,3 +2029,24 @@ it('keeps heredoc bodies unchanged when it adds build secrets to a Dockerfile',
"RUN --mount=type=secret,id=API_URL,env=API_URL python -c 'print(1)'",
]);
});
it('warns in the deployment log when PORT does not match ports_exposes', function () {
[$application, $server] = makeDeploymentControlVarFixture(['ports_exposes' => '80']);
createApplicationEnvironmentVariable($application, ['key' => 'PORT', 'value' => '3000']);
[$job, $reflection] = makeControlVarFilteringJob($application, $server);
invokeDeploymentJobMethod($job, $reflection, 'generate_runtime_environment_variables');
expect(collect($job->recordedLogEntries)->contains(fn (string $entry) => str_contains($entry, 'PORT environment variable (3000)')))->toBeTrue();
});
it('does not warn about a PORT mismatch when readonly labels are disabled', function () {
[$application, $server] = makeDeploymentControlVarFixture(['ports_exposes' => '80']);
$application->settings()->update(['is_container_label_readonly_enabled' => false]);
createApplicationEnvironmentVariable($application, ['key' => 'PORT', 'value' => '3000']);
[$job, $reflection] = makeControlVarFilteringJob($application, $server);
invokeDeploymentJobMethod($job, $reflection, 'generate_runtime_environment_variables');
expect(collect($job->recordedLogEntries)->contains(fn (string $entry) => str_contains($entry, 'PORT environment variable')))->toBeFalse();
});