mirror of
https://github.com/coollabsio/coolify.git
synced 2026-10-07 14:36:44 -04:00
Andras Bacsai
554b79e8dd
- Proxy: list and delete Traefik ACME certificates from the server proxy page via new TraefikAcmeService and Get/DeleteTraefikCertificate actions - DNS: track ownership and cross-resource references for managed DNS records so records are only deleted when no longer referenced; release records asynchronously on resource deletion via ReleaseManagedDnsRecordsJob and ManagedDnsRecordCleanup; harden Cloudflare provider deletion results - Databases: fail closed on start when prerequisites or the CA certificate are missing (DatabaseStartException, Server::ensureCaCertificate) and clean up stale start activities via ResourceStartActivity - Webhooks: throttle repeated manual webhook signature failures for GitHub, GitLab, Gitea and Bitbucket - Deployments: improve compose build-context handling and compose file load error reporting - Install scripts: rework terminal UI output in install.sh (stable and nightly) - Misc: settings sidebar accordion fixes, log drain toggle rollback, add Serverside to README sponsors - Add migrations and tests covering the above
80 lines
3.6 KiB
PHP
80 lines
3.6 KiB
PHP
<?php
|
|
|
|
use App\Models\Application;
|
|
use App\Models\InstanceSettings;
|
|
use App\Models\PrivateKey;
|
|
use App\Models\Server;
|
|
use App\Models\StandaloneDocker;
|
|
use App\Models\Team;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Log;
|
|
use Illuminate\Support\Facades\Process;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function () {
|
|
InstanceSettings::forceCreate(['id' => 0]);
|
|
config(['constants.ssh.mux_enabled' => false]);
|
|
Log::spy();
|
|
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create(['team_id' => $team->id, 'private_key_id' => PrivateKey::factory()->create(['team_id' => $team->id])->id]);
|
|
$destination = StandaloneDocker::query()->where('server_id', $server->id)->firstOrFail();
|
|
$this->application = Application::factory()->create([
|
|
'build_pack' => 'dockercompose',
|
|
'git_repository' => 'https://github.com/coollabsio/private-repo',
|
|
'git_branch' => 'main',
|
|
'base_directory' => '/',
|
|
'docker_compose_location' => '/docker-compose.yml',
|
|
'destination_id' => $destination->id,
|
|
'destination_type' => $destination->getMorphClass(),
|
|
]);
|
|
$this->gitError = "Cloning into 'checkout'...\nfatal: unable to access 'https://x-access-token:ghs_SECRET123@github.com/coollabsio/private-repo.git/': The requested URL returned error: 403 <b>denied</b>";
|
|
});
|
|
|
|
function fakeComposeLoadServer(?string $failingStep, string $errorOutput): void
|
|
{
|
|
Process::fake(function ($process) use ($failingStep, $errorOutput) {
|
|
$command = is_array($process->command) ? implode(' ', $process->command) : $process->command;
|
|
if ($failingStep !== null && str_contains($command, $failingStep)) {
|
|
return Process::result(errorOutput: $errorOutput, exitCode: 128);
|
|
}
|
|
|
|
return Process::result(output: str_contains($command, 'git --version') ? 'git version 2.43.0' : '');
|
|
});
|
|
}
|
|
|
|
it('shows and logs why the Compose file could not be read, without credentials', function () {
|
|
fakeComposeLoadServer('sparse-checkout', $this->gitError);
|
|
|
|
expect(fn () => $this->application->loadComposeFile())
|
|
->toThrow(function (RuntimeException $exception) {
|
|
expect($exception->getMessage())
|
|
->toContain('Failed to read the Docker Compose file from the repository.')
|
|
->toContain('The requested URL returned error: 403 <b>denied</b>')
|
|
->toContain('https://***@github.com/')
|
|
->not->toContain('ghs_SECRET123')
|
|
->not->toContain('<b>');
|
|
});
|
|
|
|
Log::shouldHaveReceived('warning')->withArgs(fn (string $message, array $context) => $message === 'Failed to read the Docker Compose file from the repository.'
|
|
&& $context['application_uuid'] === $this->application->uuid
|
|
&& str_contains($context['error'], 'The requested URL returned error: 403')
|
|
&& ! str_contains(json_encode($context), 'ghs_SECRET123'));
|
|
});
|
|
|
|
it('shows and logs why the Git source could not be read, without credentials', function () {
|
|
fakeComposeLoadServer('ls-remote', $this->gitError);
|
|
|
|
expect(fn () => $this->application->loadComposeFile())
|
|
->toThrow(function (RuntimeException $exception) {
|
|
expect($exception->getMessage())
|
|
->toContain('Failed to read Git source. Please verify repository access and try again.')
|
|
->toContain('The requested URL returned error: 403')
|
|
->not->toContain('ghs_SECRET123');
|
|
});
|
|
|
|
Log::shouldHaveReceived('warning')->withArgs(fn (string $message, array $context) => $message === 'Failed to read Git source.'
|
|
&& ! str_contains(json_encode($context), 'ghs_SECRET123'));
|
|
});
|