mirror of
https://github.com/coollabsio/coolify.git
synced 2026-11-14 08:42:38 -04:00
Andras Bacsai
45d165e82e
Docker publishes the proxy port on [::] too and forwards it to the container's IPv6 address when the network has IPv6 enabled. nginx listened only on IPv4, so every IPv6 connection was reset. Add listen [::]:<port> when the destination network has IPv6 enabled. Networks without IPv6 keep the IPv4-only listener. Fixes #12133
85 lines
3.3 KiB
PHP
85 lines
3.3 KiB
PHP
<?php
|
|
|
|
use App\Actions\Database\StartDatabaseProxy;
|
|
use App\Models\Environment;
|
|
use App\Models\Project;
|
|
use App\Models\Server;
|
|
use App\Models\StandaloneDocker;
|
|
use App\Models\StandalonePostgresql;
|
|
use App\Models\Team;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Notification;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function () {
|
|
Notification::fake();
|
|
});
|
|
|
|
test('database proxy is disabled on port already allocated error', function () {
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create(['team_id' => $team->id]);
|
|
$destination = StandaloneDocker::query()->where('server_id', $server->id)->firstOrFail();
|
|
$project = Project::factory()->create(['team_id' => $team->id]);
|
|
$environment = Environment::factory()->create(['project_id' => $project->id]);
|
|
|
|
$database = StandalonePostgresql::create([
|
|
'name' => 'postgres',
|
|
'image' => 'postgres:16-alpine',
|
|
'postgres_user' => 'postgres',
|
|
'postgres_password' => 'password',
|
|
'postgres_db' => 'postgres',
|
|
'environment_id' => $environment->id,
|
|
'destination_id' => $destination->id,
|
|
'destination_type' => $destination->getMorphClass(),
|
|
'is_public' => true,
|
|
'public_port' => 5432,
|
|
]);
|
|
|
|
expect($database->is_public)->toBeTrue();
|
|
|
|
$action = new StartDatabaseProxy;
|
|
|
|
// Use reflection to test the private method directly
|
|
$method = new ReflectionMethod($action, 'isNonTransientError');
|
|
|
|
expect($method->invoke($action, 'Bind for 0.0.0.0:5432 failed: port is already allocated'))->toBeTrue();
|
|
expect($method->invoke($action, 'address already in use'))->toBeTrue();
|
|
expect($method->invoke($action, 'some other error'))->toBeFalse();
|
|
});
|
|
|
|
test('isNonTransientError detects port conflict patterns', function () {
|
|
$action = new StartDatabaseProxy;
|
|
$method = new ReflectionMethod($action, 'isNonTransientError');
|
|
|
|
expect($method->invoke($action, 'Bind for 0.0.0.0:5432 failed: port is already allocated'))->toBeTrue()
|
|
->and($method->invoke($action, 'address already in use'))->toBeTrue()
|
|
->and($method->invoke($action, 'Bind for 0.0.0.0:3306 failed: port is already allocated'))->toBeTrue()
|
|
->and($method->invoke($action, 'network timeout'))->toBeFalse()
|
|
->and($method->invoke($action, 'connection refused'))->toBeFalse();
|
|
});
|
|
|
|
test('buildProxyTimeoutConfig normalizes invalid values to default', function (?int $input, string $expected) {
|
|
$action = new StartDatabaseProxy;
|
|
$method = new ReflectionMethod($action, 'buildProxyTimeoutConfig');
|
|
|
|
expect($method->invoke($action, $input))->toBe($expected);
|
|
})->with([
|
|
[null, 'proxy_timeout 3600s;'],
|
|
[0, 'proxy_timeout 3600s;'],
|
|
[-10, 'proxy_timeout 3600s;'],
|
|
[120, 'proxy_timeout 120s;'],
|
|
]);
|
|
|
|
test('buildListenConfig adds an IPv6 listener only when the network has IPv6 enabled', function (bool $ipv6Enabled, array $expectedListeners) {
|
|
$action = new StartDatabaseProxy;
|
|
$method = new ReflectionMethod($action, 'buildListenConfig');
|
|
|
|
$listeners = array_map('trim', explode("\n", $method->invoke($action, 28197, $ipv6Enabled)));
|
|
|
|
expect($listeners)->toBe($expectedListeners);
|
|
})->with([
|
|
'IPv4 only network' => [false, ['listen 28197;']],
|
|
'IPv6 enabled network' => [true, ['listen 28197;', 'listen [::]:28197;']],
|
|
]);
|