mirror of
https://github.com/coollabsio/coolify.git
synced 2026-11-14 16:52:45 -04:00
A non-root SSH user cannot open redirects, expand globs, or cd into /data/coolify (9999:root 0700). Several remote commands relied on that and failed on non-root servers. - Write README files with `tee` instead of shell redirects in database starts and application deployments - Clear Postgres init scripts with `find` instead of a glob - Split the proxy config backfill if/else so each branch gets sudo - Start the log drain with `docker compose -f` instead of `cd` - Wrap the preserved-repository compose start in `sh -c` for non-root - Stage clone archives outside /data/coolify via StagesCloneArchives - Extend the sudo parser and add non-root command tests
190 lines
7.0 KiB
PHP
190 lines
7.0 KiB
PHP
<?php
|
|
|
|
namespace App\Services\ServerTransfer;
|
|
|
|
use App\Models\Server;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Illuminate\Support\Facades\Log;
|
|
use RuntimeException;
|
|
use Throwable;
|
|
|
|
class ServerTransferClaimer
|
|
{
|
|
/**
|
|
* Take management of a server on this Coolify instance and bind Sentinel to it.
|
|
*
|
|
* Database ownership (metadata + Sentinel settings) is committed in one transaction so a
|
|
* mid-flight failure rolls back.
|
|
*
|
|
* @return array{
|
|
* server_uuid: string,
|
|
* claim: array<string, mixed>,
|
|
* message: string
|
|
* }
|
|
*/
|
|
public function claim(Server $server): array
|
|
{
|
|
if ($server->id === 0) {
|
|
throw new RuntimeException('Cannot claim the Coolify host itself.');
|
|
}
|
|
|
|
$instanceUrl = rtrim((string) (instanceSettings()->fqdn ?: config('app.url')), '/');
|
|
if ($instanceUrl === '') {
|
|
throw new RuntimeException('Instance URL (FQDN or APP_URL) must be set before claiming a server.');
|
|
}
|
|
|
|
$exportId = data_get($server->server_metadata, 'transfer.export_id');
|
|
|
|
$claim = [
|
|
'instance_url' => $instanceUrl,
|
|
'server_uuid' => $server->uuid,
|
|
'team_id' => $server->team_id,
|
|
'claimed_at' => now()->toIso8601String(),
|
|
'export_id' => $exportId,
|
|
'schema_version' => ServerTransferBundle::SCHEMA_VERSION,
|
|
];
|
|
|
|
return DB::transaction(function () use ($server, $claim, $instanceUrl) {
|
|
$server = Server::query()->with('settings')->lockForUpdate()->findOrFail($server->id);
|
|
|
|
if ($server->settings) {
|
|
$server->settings->sentinel_custom_url = $instanceUrl;
|
|
$server->settings->ensureValidSentinelToken();
|
|
$server->settings->is_sentinel_enabled = true;
|
|
if (! $server->team->serverOverflow()) {
|
|
$server->settings->force_disabled = false;
|
|
}
|
|
$server->settings->save();
|
|
}
|
|
|
|
$metadata = $server->server_metadata ?? [];
|
|
$metadata['transfer'] = array_merge((array) data_get($metadata, 'transfer', []), [
|
|
'status' => 'claimed',
|
|
'claimed_at' => $claim['claimed_at'],
|
|
'claim' => $claim,
|
|
]);
|
|
$server->server_metadata = $metadata;
|
|
$server->save();
|
|
|
|
return [
|
|
'server_uuid' => $server->uuid,
|
|
'claim' => $claim,
|
|
'message' => 'This Coolify instance now manages the server.',
|
|
];
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Mark a server as transferred away from this instance (source side).
|
|
* Disables automations to prevent dual management.
|
|
*
|
|
* All database writes run in one transaction so partial disable state cannot stick on failure.
|
|
* Local SSH key cache cleanup runs after commit (filesystem; not transactional).
|
|
*
|
|
* $managementDisabled marks a manual "Disable management" action: the server is not moved yet,
|
|
* only ready to be transferred to another instance.
|
|
*
|
|
* @return array{server_uuid: string, message: string}
|
|
*/
|
|
public function markTransferred(Server $server, ?string $exportId = null, ?string $targetInstanceUrl = null, bool $managementDisabled = false): array
|
|
{
|
|
if ($server->id === 0) {
|
|
throw new RuntimeException('Cannot transfer the Coolify host itself.');
|
|
}
|
|
|
|
$result = DB::transaction(function () use ($server, $exportId, $targetInstanceUrl, $managementDisabled) {
|
|
$server = Server::query()->with('settings')->lockForUpdate()->findOrFail($server->id);
|
|
|
|
if ($server->settings) {
|
|
$server->settings->force_disabled = true;
|
|
$server->settings->is_sentinel_enabled = false;
|
|
$server->settings->save();
|
|
}
|
|
|
|
$metadata = $server->server_metadata ?? [];
|
|
$metadata['transfer'] = array_merge((array) data_get($metadata, 'transfer', []), [
|
|
'status' => 'transferred',
|
|
'export_id' => $exportId ?? data_get($metadata, 'transfer.export_id'),
|
|
'target_instance_url' => $targetInstanceUrl,
|
|
'transferred_at' => now()->toIso8601String(),
|
|
'management_disabled' => $managementDisabled,
|
|
]);
|
|
$server->server_metadata = $metadata;
|
|
$server->save();
|
|
|
|
return [
|
|
'server_uuid' => $server->uuid,
|
|
'message' => 'Server marked as transferred. Automations disabled on this instance.',
|
|
];
|
|
});
|
|
|
|
$this->clearLocalSshArtifacts($server);
|
|
|
|
return $result;
|
|
}
|
|
|
|
/**
|
|
* Best-effort local SSH mux/key cleanup after transfer (filesystem; not part of DB rollback).
|
|
* forceDisableServer is idempotent for force_disabled and also clears cached SSH key material.
|
|
*/
|
|
private function clearLocalSshArtifacts(Server $server): void
|
|
{
|
|
try {
|
|
$server->refresh();
|
|
$server->forceDisableServer();
|
|
} catch (Throwable $e) {
|
|
Log::warning('Failed to clear local SSH artifacts after transfer', [
|
|
'server_uuid' => $server->uuid,
|
|
'error' => $e->getMessage(),
|
|
]);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Write export bundle to the managed host mailbox (air-gapped transfer).
|
|
*
|
|
* @param array<string, mixed> $bundle
|
|
* @return array{path: string, written: bool}
|
|
*/
|
|
public function writeMailbox(Server $server, array $bundle, ?string $passphrase = null): array
|
|
{
|
|
ServerTransferBundle::assertValid($bundle);
|
|
|
|
$exportId = (string) data_get($bundle, 'export_id', new_public_id());
|
|
$filename = "server-transfer-{$exportId}.coolify.json";
|
|
$path = ServerTransferBundle::MAILBOX_DIR.'/'.$filename;
|
|
|
|
$payload = $passphrase
|
|
? ServerTransferBundle::encryptWithPassphrase($bundle, $passphrase)
|
|
: $bundle;
|
|
|
|
$json = json_encode($payload, JSON_THROW_ON_ERROR | JSON_UNESCAPED_SLASHES);
|
|
$b64 = base64_encode($json);
|
|
|
|
$written = false;
|
|
try {
|
|
instant_remote_process([
|
|
'mkdir -p '.escapeshellarg(ServerTransferBundle::MAILBOX_DIR),
|
|
// tee, not a redirect: the SSH user's shell opens a redirect, and a non-root user cannot enter /data/coolify.
|
|
'echo '.escapeshellarg($b64).' | base64 -d | tee '.escapeshellarg($path).' > /dev/null',
|
|
'chmod 600 '.escapeshellarg($path),
|
|
'chown 9999:root '.escapeshellarg($path).' || true',
|
|
], $server, true);
|
|
$written = true;
|
|
} catch (Throwable $e) {
|
|
Log::warning('Failed to write server transfer mailbox', [
|
|
'server_uuid' => $server->uuid,
|
|
'error' => $e->getMessage(),
|
|
]);
|
|
if (! app()->runningUnitTests()) {
|
|
throw $e;
|
|
}
|
|
}
|
|
|
|
return [
|
|
'path' => $path,
|
|
'written' => $written,
|
|
];
|
|
}
|
|
}
|