Deprecate the UniFi Protect Detected Object sensor (#83480)

Co-authored-by: J. Nick Koston <nick@koston.org>

tests/components/unifiprotect/test_repairs.py

@@ -4,10 +4,11 @@ from __future__ import annotations
 
 from copy import copy
 from http import HTTPStatus
-from unittest.mock import Mock
+from unittest.mock import Mock, patch
 
-from pyunifiprotect.data import Version
+from pyunifiprotect.data import Camera, Version
 
+from homeassistant.components.automation import DOMAIN as AUTOMATION_DOMAIN
 from homeassistant.components.repairs.issue_handler import (
     async_process_repairs_platforms,
 )
@@ -15,8 +16,12 @@ from homeassistant.components.repairs.websocket_api import (
     RepairsFlowIndexView,
     RepairsFlowResourceView,
 )
+from homeassistant.components.script import DOMAIN as SCRIPT_DOMAIN
 from homeassistant.components.unifiprotect.const import DOMAIN
+from homeassistant.const import SERVICE_RELOAD, Platform
 from homeassistant.core import HomeAssistant
+from homeassistant.helpers import entity_registry as er
+from homeassistant.setup import async_setup_component
 
 from .utils import MockUFPFixture, init_entry
 
@@ -124,3 +129,198 @@ async def test_ea_warning_fix(
     data = await resp.json()
 
     assert data["type"] == "create_entry"
+
+
+async def test_deprecate_smart_default(
+    hass: HomeAssistant, ufp: MockUFPFixture, hass_ws_client, doorbell: Camera
+):
+    """Test Deprecate Sensor repair does not exist by default (new installs)."""
+
+    await init_entry(hass, ufp, [doorbell])
+
+    await async_process_repairs_platforms(hass)
+    ws_client = await hass_ws_client(hass)
+
+    await ws_client.send_json({"id": 1, "type": "repairs/list_issues"})
+    msg = await ws_client.receive_json()
+
+    assert msg["success"]
+    issue = None
+    for i in msg["result"]["issues"]:
+        if i["issue_id"] == "deprecate_smart_sensor":
+            issue = i
+    assert issue is None
+
+
+async def test_deprecate_smart_no_automations(
+    hass: HomeAssistant, ufp: MockUFPFixture, hass_ws_client, doorbell: Camera
+):
+    """Test Deprecate Sensor repair exists for existing installs."""
+
+    registry = er.async_get(hass)
+    registry.async_get_or_create(
+        Platform.SENSOR,
+        DOMAIN,
+        f"{doorbell.mac}_detected_object",
+        config_entry=ufp.entry,
+    )
+
+    await init_entry(hass, ufp, [doorbell])
+
+    await async_process_repairs_platforms(hass)
+    ws_client = await hass_ws_client(hass)
+
+    await ws_client.send_json({"id": 1, "type": "repairs/list_issues"})
+    msg = await ws_client.receive_json()
+
+    assert msg["success"]
+    issue = None
+    for i in msg["result"]["issues"]:
+        if i["issue_id"] == "deprecate_smart_sensor":
+            issue = i
+    assert issue is None
+
+
+async def _load_automation(hass: HomeAssistant, entity_id: str):
+    assert await async_setup_component(
+        hass,
+        AUTOMATION_DOMAIN,
+        {
+            AUTOMATION_DOMAIN: [
+                {
+                    "alias": "test1",
+                    "trigger": [
+                        {"platform": "state", "entity_id": entity_id},
+                        {
+                            "platform": "event",
+                            "event_type": "state_changed",
+                            "event_data": {"entity_id": entity_id},
+                        },
+                    ],
+                    "condition": {
+                        "condition": "state",
+                        "entity_id": entity_id,
+                        "state": "on",
+                    },
+                    "action": [
+                        {
+                            "service": "test.script",
+                            "data": {"entity_id": entity_id},
+                        },
+                    ],
+                },
+            ]
+        },
+    )
+
+
+async def test_deprecate_smart_automation(
+    hass: HomeAssistant, ufp: MockUFPFixture, hass_ws_client, doorbell: Camera
+):
+    """Test Deprecate Sensor repair exists for existing installs."""
+
+    registry = er.async_get(hass)
+    entry = registry.async_get_or_create(
+        Platform.SENSOR,
+        DOMAIN,
+        f"{doorbell.mac}_detected_object",
+        config_entry=ufp.entry,
+    )
+    await _load_automation(hass, entry.entity_id)
+    await init_entry(hass, ufp, [doorbell])
+
+    await async_process_repairs_platforms(hass)
+    ws_client = await hass_ws_client(hass)
+
+    await ws_client.send_json({"id": 1, "type": "repairs/list_issues"})
+    msg = await ws_client.receive_json()
+
+    assert msg["success"]
+    issue = None
+    for i in msg["result"]["issues"]:
+        if i["issue_id"] == "deprecate_smart_sensor":
+            issue = i
+    assert issue is not None
+
+    with patch(
+        "homeassistant.config.load_yaml_config_file",
+        autospec=True,
+        return_value={AUTOMATION_DOMAIN: []},
+    ):
+        await hass.services.async_call(AUTOMATION_DOMAIN, SERVICE_RELOAD, blocking=True)
+    await hass.async_block_till_done()
+
+    await ws_client.send_json({"id": 2, "type": "repairs/list_issues"})
+    msg = await ws_client.receive_json()
+
+    assert msg["success"]
+    issue = None
+    for i in msg["result"]["issues"]:
+        if i["issue_id"] == "deprecate_smart_sensor":
+            issue = i
+    assert issue is None
+
+
+async def _load_script(hass: HomeAssistant, entity_id: str):
+    assert await async_setup_component(
+        hass,
+        SCRIPT_DOMAIN,
+        {
+            SCRIPT_DOMAIN: {
+                "test": {
+                    "sequence": {
+                        "service": "test.script",
+                        "data": {"entity_id": entity_id},
+                    }
+                }
+            },
+        },
+    )
+
+
+async def test_deprecate_smart_script(
+    hass: HomeAssistant, ufp: MockUFPFixture, hass_ws_client, doorbell: Camera
+):
+    """Test Deprecate Sensor repair exists for existing installs."""
+
+    registry = er.async_get(hass)
+    entry = registry.async_get_or_create(
+        Platform.SENSOR,
+        DOMAIN,
+        f"{doorbell.mac}_detected_object",
+        config_entry=ufp.entry,
+    )
+    await _load_script(hass, entry.entity_id)
+    await init_entry(hass, ufp, [doorbell])
+
+    await async_process_repairs_platforms(hass)
+    ws_client = await hass_ws_client(hass)
+
+    await ws_client.send_json({"id": 1, "type": "repairs/list_issues"})
+    msg = await ws_client.receive_json()
+
+    assert msg["success"]
+    issue = None
+    for i in msg["result"]["issues"]:
+        if i["issue_id"] == "deprecate_smart_sensor":
+            issue = i
+    assert issue is not None
+
+    with patch(
+        "homeassistant.config.load_yaml_config_file",
+        autospec=True,
+        return_value={SCRIPT_DOMAIN: {}},
+    ):
+        await hass.services.async_call(SCRIPT_DOMAIN, SERVICE_RELOAD, blocking=True)
+    await hass.config_entries.async_reload(ufp.entry.entry_id)
+    await hass.async_block_till_done()
+
+    await ws_client.send_json({"id": 2, "type": "repairs/list_issues"})
+    msg = await ws_client.receive_json()
+
+    assert msg["success"]
+    issue = None
+    for i in msg["result"]["issues"]:
+        if i["issue_id"] == "deprecate_smart_sensor":
+            issue = i
+    assert issue is None