Prefer explicit parametrize in litterrobot tests (#163155)

This commit is contained in:
epenet
2026-02-16 14:27:58 +01:00
committed by GitHub
parent 2d2ea3d31c
commit 8dc9937ba4
+18 -10
View File
@@ -24,10 +24,6 @@ from .conftest import setup_integration
VACUUM_UNIQUE_ID = "LR3C012345-litter_box"
COMPONENT_SERVICE_DOMAIN = {
SERVICE_SET_SLEEP_MODE: DOMAIN,
}
async def test_vacuum(
hass: HomeAssistant, entity_registry: er.EntityRegistry, mock_account: MagicMock
@@ -106,23 +102,35 @@ async def test_activities(
@pytest.mark.parametrize(
("service", "command", "extra"),
("service_domain", "service", "command", "extra"),
[
(SERVICE_START, "start_cleaning", None),
(SERVICE_STOP, "set_power_status", None),
(VACUUM_DOMAIN, SERVICE_START, "start_cleaning", None),
(VACUUM_DOMAIN, SERVICE_STOP, "set_power_status", None),
(
DOMAIN,
SERVICE_SET_SLEEP_MODE,
"set_sleep_mode",
{"data": {"enabled": True, "start_time": "22:30"}},
),
(SERVICE_SET_SLEEP_MODE, "set_sleep_mode", {"data": {"enabled": True}}),
(SERVICE_SET_SLEEP_MODE, "set_sleep_mode", {"data": {"enabled": False}}),
(
DOMAIN,
SERVICE_SET_SLEEP_MODE,
"set_sleep_mode",
{"data": {"enabled": True}},
),
(
DOMAIN,
SERVICE_SET_SLEEP_MODE,
"set_sleep_mode",
{"data": {"enabled": False}},
),
],
)
async def test_commands(
hass: HomeAssistant,
mock_account: MagicMock,
caplog: pytest.LogCaptureFixture,
service_domain: str,
service: str,
command: str,
extra: dict[str, Any],
@@ -140,7 +148,7 @@ async def test_commands(
issues = extra.get("issues", set())
await hass.services.async_call(
COMPONENT_SERVICE_DOMAIN.get(service, VACUUM_DOMAIN),
service_domain,
service,
data,
blocking=True,