From ae42f4150f186742351bea8d2051cf5dfd61a596 Mon Sep 17 00:00:00 2001 From: Erwin Douna Date: Wed, 30 Sep 2026 08:39:17 +0200 Subject: [PATCH] Tell Copilot expired YAML import removal isn't breaking (#183680) --- .github/copilot-instructions.md | 1 + script/gen_copilot_instructions.py | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 077c8b42ffc8..355d778615d7 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -9,6 +9,7 @@ - When reviewing changes under `homeassistant/components/` or `tests/components/`, use the `ha-integration-knowledge` skill as the primary reference. - Flag comments that over-explain straightforward code, narrate the obvious, or read like AI commentary (multi-sentence justifications for a single line). - A Pull Request with a dependency version bump should only contain changes required for the version bump. If the PR includes other changes, request that they are removed from the PR. +- Do not ask to mark a Pull Request as a breaking change when it removes a YAML import whose deprecation period has ended; the deprecation already announced the removal. - Check that the PR description is complete and filled in according to the PR template included below. Every section and checklist item from the template must be present, except the `## Breaking change` section which is optional. No content from the template should be missing, except for HTML comments and Markdown link reference definitions (lines of the form `[name]: url`), which do not render and cannot be verified from the description. Even unchecked checkboxes or empty sections must be present. This is a hard requirement. - Skip the PR template check for pull requests generated by automated dependency bots. These are identifiable by their description: Renovate PRs contain "This PR was generated by [Mend Renovate]" and Dependabot PRs contain "Dependabot commands and options". All other review instructions still apply to these PRs. diff --git a/script/gen_copilot_instructions.py b/script/gen_copilot_instructions.py index 6cce05bf22dd..6611610aaea8 100755 --- a/script/gen_copilot_instructions.py +++ b/script/gen_copilot_instructions.py @@ -20,6 +20,7 @@ COPILOT_SPECIFIC_INSTRUCTIONS = """ - When reviewing changes under `homeassistant/components/` or `tests/components/`, use the `ha-integration-knowledge` skill as the primary reference. - Flag comments that over-explain straightforward code, narrate the obvious, or read like AI commentary (multi-sentence justifications for a single line). - A Pull Request with a dependency version bump should only contain changes required for the version bump. If the PR includes other changes, request that they are removed from the PR. +- Do not ask to mark a Pull Request as a breaking change when it removes a YAML import whose deprecation period has ended; the deprecation already announced the removal. - Check that the PR description is complete and filled in according to the PR template included below. Every section and checklist item from the template must be present, except the `## Breaking change` section which is optional. No content from the template should be missing, except for HTML comments and Markdown link reference definitions (lines of the form `[name]: url`), which do not render and cannot be verified from the description. Even unchecked checkboxes or empty sections must be present. This is a hard requirement. - Skip the PR template check for pull requests generated by automated dependency bots. These are identifiable by their description: Renovate PRs contain "This PR was generated by [Mend Renovate]" and Dependabot PRs contain "Dependabot commands and options". All other review instructions still apply to these PRs.