Make Hydrawise initialize data immediately (#101936)

tests/components/hydrawise/test_binary_sensor.py

@@ -17,11 +17,6 @@ async def test_states(
     freezer: FrozenDateTimeFactory,
 ) -> None:
     """Test binary_sensor states."""
-    # Make the coordinator refresh data.
-    freezer.tick(SCAN_INTERVAL + timedelta(seconds=30))
-    async_fire_time_changed(hass)
-    await hass.async_block_till_done()
-
     connectivity = hass.states.get("binary_sensor.home_controller_connectivity")
     assert connectivity is not None
     assert connectivity.state == "on"

tests/components/hydrawise/test_init.py

@@ -1,6 +1,6 @@
 """Tests for the Hydrawise integration."""
 
-from unittest.mock import Mock, patch
+from unittest.mock import Mock
 
 from requests.exceptions import HTTPError
 
@@ -15,6 +15,7 @@ from tests.common import MockConfigEntry
 
 async def test_setup_import_success(hass: HomeAssistant, mock_pydrawise: Mock) -> None:
     """Test that setup with a YAML config triggers an import and warning."""
+    mock_pydrawise.update_controller_info.return_value = True
     mock_pydrawise.customer_id = 12345
     mock_pydrawise.status = "unknown"
     config = {"hydrawise": {CONF_ACCESS_TOKEN: "_access-token_"}}
@@ -29,29 +30,22 @@ async def test_setup_import_success(hass: HomeAssistant, mock_pydrawise: Mock) -
 
 
 async def test_connect_retry(
-    hass: HomeAssistant, mock_config_entry: MockConfigEntry
+    hass: HomeAssistant, mock_config_entry: MockConfigEntry, mock_pydrawise: Mock
 ) -> None:
     """Test that a connection error triggers a retry."""
-    with patch("pydrawise.legacy.LegacyHydrawise") as mock_api:
-        mock_api.side_effect = HTTPError
-        mock_config_entry.add_to_hass(hass)
-        await hass.config_entries.async_setup(mock_config_entry.entry_id)
-        await hass.async_block_till_done()
-
-        mock_api.assert_called_once()
-        assert mock_config_entry.state is ConfigEntryState.SETUP_RETRY
+    mock_pydrawise.update_controller_info.side_effect = HTTPError
+    mock_config_entry.add_to_hass(hass)
+    await hass.config_entries.async_setup(mock_config_entry.entry_id)
+    await hass.async_block_till_done()
+    assert mock_config_entry.state is ConfigEntryState.SETUP_RETRY
 
 
 async def test_setup_no_data(
-    hass: HomeAssistant, mock_config_entry: MockConfigEntry
+    hass: HomeAssistant, mock_config_entry: MockConfigEntry, mock_pydrawise: Mock
 ) -> None:
     """Test that no data from the API triggers a retry."""
-    with patch("pydrawise.legacy.LegacyHydrawise") as mock_api:
-        mock_api.return_value.controller_info = {}
-        mock_api.return_value.controller_status = None
-        mock_config_entry.add_to_hass(hass)
-        await hass.config_entries.async_setup(mock_config_entry.entry_id)
-        await hass.async_block_till_done()
-
-        mock_api.assert_called_once()
-        assert mock_config_entry.state is ConfigEntryState.SETUP_RETRY
+    mock_pydrawise.update_controller_info.return_value = False
+    mock_config_entry.add_to_hass(hass)
+    await hass.config_entries.async_setup(mock_config_entry.entry_id)
+    await hass.async_block_till_done()
+    assert mock_config_entry.state is ConfigEntryState.SETUP_RETRY

tests/components/hydrawise/test_sensor.py

@@ -1,14 +1,11 @@
 """Test Hydrawise sensor."""
 
-from datetime import timedelta
-
 from freezegun.api import FrozenDateTimeFactory
 import pytest
 
-from homeassistant.components.hydrawise.const import SCAN_INTERVAL
 from homeassistant.core import HomeAssistant
 
-from tests.common import MockConfigEntry, async_fire_time_changed
+from tests.common import MockConfigEntry
 
 
 @pytest.mark.freeze_time("2023-10-01 00:00:00+00:00")
@@ -18,11 +15,6 @@ async def test_states(
     freezer: FrozenDateTimeFactory,
 ) -> None:
     """Test sensor states."""
-    # Make the coordinator refresh data.
-    freezer.tick(SCAN_INTERVAL + timedelta(seconds=30))
-    async_fire_time_changed(hass)
-    await hass.async_block_till_done()
-
     watering_time1 = hass.states.get("sensor.zone_one_watering_time")
     assert watering_time1 is not None
     assert watering_time1.state == "0"
@@ -33,4 +25,4 @@ async def test_states(
 
     next_cycle = hass.states.get("sensor.zone_one_next_cycle")
     assert next_cycle is not None
-    assert next_cycle.state == "2023-10-04T19:52:27+00:00"
+    assert next_cycle.state == "2023-10-04T19:49:57+00:00"

tests/components/hydrawise/test_switch.py

@@ -1,16 +1,14 @@
 """Test Hydrawise switch."""
 
-from datetime import timedelta
 from unittest.mock import Mock
 
 from freezegun.api import FrozenDateTimeFactory
 
-from homeassistant.components.hydrawise.const import SCAN_INTERVAL
 from homeassistant.components.switch import DOMAIN as SWITCH_DOMAIN
 from homeassistant.const import ATTR_ENTITY_ID, SERVICE_TURN_OFF, SERVICE_TURN_ON
 from homeassistant.core import HomeAssistant
 
-from tests.common import MockConfigEntry, async_fire_time_changed
+from tests.common import MockConfigEntry
 
 
 async def test_states(
@@ -19,11 +17,6 @@ async def test_states(
     freezer: FrozenDateTimeFactory,
 ) -> None:
     """Test switch states."""
-    # Make the coordinator refresh data.
-    freezer.tick(SCAN_INTERVAL + timedelta(seconds=30))
-    async_fire_time_changed(hass)
-    await hass.async_block_till_done()
-
     watering1 = hass.states.get("switch.zone_one_manual_watering")
     assert watering1 is not None
     assert watering1.state == "off"