* Improve Voip pipeline stability
It appears the pipeline is being unexpectedly cancelled in some
instances. In order to mitigate this issue hang ups will be detected
using a separate task rather than relying on timeouts in the STT read
method. Also reading STT events will be retried once if it is cancelled.
The pipeline will also catch and log any CancelledErrors to help with
further debugging.
* Update Voip tests
* Remove unnecessary changes
Remove unnecessary logging and cancelled error handling in wyoming STT.
* Remove comment about clearing system prompt
The test no longer checks for clearing the system prompt. Since that
logic exists completely in the assist_satellite component I think it is
reasonable to only test that logic in the unit tests for that component.
* Re-raise cancellation
Re-raise CancelledError if the current task is cancelling in the check hangup task
Co-authored-by: J. Nick Koston <nick@koston.org>
* Re-raise CancelledError in pipeline as well
* Fix formatting issue
* Remove unnecessary logging
* Add MockResultStream import to tests
This was presumably missed while merging
* Cancel check hangup task on disconnect
* Add myself as codeowner for VoIP
* Update CODEOWNERS
---------
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
* Improve Voip pipeline stability
It appears the pipeline is being unexpectedly cancelled in some
instances. In order to mitigate this issue hang ups will be detected
using a separate task rather than relying on timeouts in the STT read
method. Also reading STT events will be retried once if it is cancelled.
The pipeline will also catch and log any CancelledErrors to help with
further debugging.
* Update Voip tests
* Remove unnecessary changes
Remove unnecessary logging and cancelled error handling in wyoming STT.
* Remove comment about clearing system prompt
The test no longer checks for clearing the system prompt. Since that
logic exists completely in the assist_satellite component I think it is
reasonable to only test that logic in the unit tests for that component.
* Re-raise cancellation
Re-raise CancelledError if the current task is cancelling in the check hangup task
Co-authored-by: J. Nick Koston <nick@koston.org>
* Re-raise CancelledError in pipeline as well
* Fix formatting issue
* Remove unnecessary logging
* Add MockResultStream import to tests
This was presumably missed while merging
* Cancel check hangup task on disconnect
* Add myself as codeowner for VoIP
* Update CODEOWNERS
---------
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Norbert RittelandGitHub
Paulus Schoutsen
JaminandPaulus Schoutsen
Pete SageandPaulus Schoutsen
Jan BouwhuisandPaulus Schoutsen
MichaelandPaulus Schoutsen
Martin HjelmareandPaulus Schoutsen
Paul BotteinandPaulus Schoutsen
Josef ZweckandPaulus Schoutsen
Luke LashleyandPaulus Schoutsen
Åke StrandbergandPaulus Schoutsen
Allen PorterandPaulus Schoutsen
ElizandPaulus Schoutsen
Luca De PetrilloandPaulus Schoutsen
Erik MontnemeryandGitHub
epenetandGitHub