rmvtransport: make filters always effective
In the `rmvtransport` integration, the three config attributes
`destination`, `lines`, and `time_offset` all act as filters. The
expectation is that if multiple filters are given, all of them take
effect.
However, as a consequence of using `elif` in the loop body, if a
`destination` filter has been configured, then both the `lines` and the
`time_offset` filters are ignored and have no effect.
Replace the `elif` with an `if` clause to allow all filter settings to
work as intended.
CC: @cgtobi
* hand down device serial into common entity
* fix platforms
* Revert "fix platforms"
This reverts commit 067af2b567.
* handle event loop issue
* hand in serial
* Revert "Revert "fix platforms""
This reverts commit 9bbb55ee6d.
* fix get serial call
* handle other exceptions
* also check device model for migration
* merge entity and device migration
* add test fixture without serial
* adjust test cases
* add dummy fixture
* remove commented code
* modify migration
* use continue
* break comment
* Dont launch SSE client for core firmware 0.9.9
* Dont offer updates on core firmware 0.9.9
* Add correct firmware done event for legacy v2 firmware
* test update legacy v2 firmware
* Dont raise issue for firmware v2
* Update Aseko to support new API
* Apply suggestions from code review
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Use self.unit instead of self._unit
* Refactor sensor setup entry
* Keep same unique id and identifier
* Revert rename free_chlorine translation key
* Remove new heating entity to keep PR small
* Fix keep same unique id
---------
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Use correct app credentials when europe is checked
* Rework to add china as well
* Use our own package since the maintainer of the original package is not responding
* Revert to using rewardone's package
* Import app credentials where needed instead of __init__
* Rework region selector
* Bump config entry minor and add migration
* Address comments
* Add vpn_status sensor
* update test fixures with new attributes
* Add vpn enabled switch
vpn strings
* Add vpn switch to test
* update snapshots
* Add vpn status to disabled by default test
* Turn Ring Doorbell and Chime volumes into number entities.
* turn RingOther volumes into numbers as well
* fix linter issues
* move other volume strings into `number` section
* add back old volume sensors but deprecate them
* add tests for `ring.number`
* add back strings for sensors that have just become deprecated
* remove deprecated volume sensors from test
* Revert "remove deprecated volume sensors from test"
This reverts commit fc95af66e7.
* create entities for deprecated sensors so that tests still run
* remove print
* add entities immediately
* move `RingNumberEntityDescription` above `RingNumber` and remove unused import
* remove irrelevant comment about history
* fix not using `setter_fn`
* add missing icons for other volume entities
* rename `entity` -> `entity_id` in number tests
* fix typing in number test
* use constants for `hass.services.async_call()`
* use `@refresh_after` decorator instead of delaying updates manually
* move descriptors above entity class
* Use snapshot to test states.
* add missing snapshot file for number platform
* Update homeassistant/components/ring/number.py
Co-authored-by: Steven B. <51370195+sdb9696@users.noreply.github.com>
---------
Co-authored-by: Steven B. <51370195+sdb9696@users.noreply.github.com>
* Add platform number.
* Remove number user_limit.
* Change LED to led in number snapshot.
* Update homeassistant/components/lektrico/number.py
---------
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* feat: initial implementation of sensor platform
* refactor(tests): await setup of config_entry in parent function
* feat(tests): add tests for laundrify sensor platform
* refactor: set name property for laundrify binary_sensor
* refactor(tests): add missing type hints
* refactor(tests): remove global change of the logging level
* refactor: address minor changes from code review
* refactor(tests): transform setup_config_entry into fixture
* refactor: leverage entity descriptions to define common entity properties
* refactor: change native unit to Wh
* fix(tests): use fixture to create the config entry
* fix: remove redundant raise of LaundrifyDeviceException
* fix(tests): raise a LaundrifyDeviceException to test the update failure behavior
* refactor(tests): merge several library fixtures into a single one
* refactor(tests): create a separate UpdateCoordinator instead of using the internal
* refactor(tests): avoid using LaundrifyPowerSensor
* refactor: simplify value retrieval by directly accessing the coordinator
* refactor: remove non-raising code from try-block
* refactor(sensor): revert usage of entity descriptions
* refactor(sensor): consolidate common attributes and init func to LaundrifyBaseSensor
* refactor(sensor): instantiate DeviceInfo obj instead of using dict
* refactor(tests): use freezer to trigger coordinator update
* refactor(tests): assert on entity state instead of coordinator
* refactor(tests): make use of freezer
* chore(tests): typo in comment
* Add new integration for WMS WebControl pro using local API
Warema recently released a new local API for their WMS hub
called "WebControl pro". This integration makes use of the
new local API via a new dedicated Python library pywmspro.
For now this integration only supports awnings as covers.
But pywmspro is device-agnostic to ease future extensions.
* Incorporated review feedback from joostlek
Thanks a lot!
* Incorporated more review feedback from joostlek
Thanks a lot!
* Incorporated more review feedback from joostlek
Thanks a lot!
* Fix
* Follow-up fix
* Improve handling of DHCP discovery
* Further test improvements suggested by joostlek, thanks!
---------
Co-authored-by: Joostlek <joostlek@outlook.com>
Jan BouwhuisandGitHub
Steven B.andGitHub
Claudia PellegrinoandGitHub
Erik MontnemeryandGitHub
Paul BotteinandGitHub
Christopher FennerandGitHub
MichaelandGitHub
Mr. BubblesandGitHub
TimLandGitHub
G JohanssonandGitHub
Michael HansenandGitHub
cnicoandGitHub
Jan-Philipp BeneckeandGitHub
Antoine ReversatandGitHub
Mike DegatanoandGitHub
Marc HörskenandGitHub
jesperraemaekersandGitHub
Noah HusbyandGitHub
Bouwe WesterdijkandGitHub
xLarryandGitHub