mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-08-28 18:24:17 -05:00
Stefan HallerandClaude Opus 4.8
f84ada4941
When loading the files of a commit we passed --no-renames, so a rename showed up as a separate delete and add rather than a single R entry. That made it impossible to work with a rename that also modifies the file: the modifications were spread across a full deletion and a full addition instead of appearing as the handful of lines that actually changed. The staging view already shows renames and lets you stage their hunks, so there was no good reason for the patch builder to differ; the flag was only there because the commit-file parser couldn't cope with the rename record format. Switch the commit-file loader and the per-file diff to --find-renames, teach the parser about the rename record (a status followed by two paths), and carry the previous path through the patch builder so the diff for a rename is loaded with both paths, which is what makes git emit the rename in the first place. A whole-file selection keeps the rename in the header, so the rename moves or is discarded together with the file's contents. A partial selection instead strips the rename metadata and points the header at the new path, so applying the patch only changes the contents and leaves the rename in place; the blob index line is kept so that a 3-way apply can still fall back to a blob merge. Discarding a renamed file from a commit now discards both the new and the old path, so the new file is removed and the old one is restored. Changing the rename similarity threshold refreshes the commit files panel too, not just the files panel, so that a rename can turn into a delete and add or back. It is disabled while building a patch, however, because the patch builder caches each file's diff by path and would desync if a rename changed into a delete and add underneath it. Finally, copying a file's diff from the commit files panel now passes both paths for a rename, so the copied diff shows the rename instead of a new-file add. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
81 lines
2.3 KiB
Go
81 lines
2.3 KiB
Go
package git_commands
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/jesseduffield/lazygit/pkg/commands/models"
|
|
"github.com/jesseduffield/lazygit/pkg/commands/oscommands"
|
|
"github.com/jesseduffield/lazygit/pkg/common"
|
|
)
|
|
|
|
type CommitFileLoader struct {
|
|
*common.Common
|
|
cmd oscommands.ICmdObjBuilder
|
|
}
|
|
|
|
func NewCommitFileLoader(common *common.Common, cmd oscommands.ICmdObjBuilder) *CommitFileLoader {
|
|
return &CommitFileLoader{
|
|
Common: common,
|
|
cmd: cmd,
|
|
}
|
|
}
|
|
|
|
// GetFilesInDiff get the specified commit files
|
|
func (self *CommitFileLoader) GetFilesInDiff(from string, to string, reverse bool) ([]*models.CommitFile, error) {
|
|
cmdArgs := NewGitCmd("diff").
|
|
Config("diff.noprefix=false").
|
|
Arg("--submodule").
|
|
Arg("--no-ext-diff").
|
|
Arg("--name-status").
|
|
Arg("-z").
|
|
Arg(fmt.Sprintf("--find-renames=%d%%", self.UserConfig().Git.RenameSimilarityThreshold)).
|
|
ArgIf(reverse, "-R").
|
|
Arg(from).
|
|
Arg(to).
|
|
ToArgv()
|
|
|
|
filenames, err := self.cmd.New(cmdArgs).DontLog().RunWithOutput()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return getCommitFilesFromFilenames(filenames), nil
|
|
}
|
|
|
|
// filenames string is something like "MM\x00file1\x00MU\x00file2\x00AA\x00file3\x00"
|
|
// so we need to split it by the null character and then map each status-name pair
|
|
// to a commit file. Renames (and copies) are special: their status is followed by
|
|
// two paths (the old one and the new one) rather than one, e.g.
|
|
// "R100\x00old\x00new\x00".
|
|
func getCommitFilesFromFilenames(filenames string) []*models.CommitFile {
|
|
fields := strings.Split(strings.TrimRight(filenames, "\x00"), "\x00")
|
|
if len(fields) == 1 {
|
|
return []*models.CommitFile{}
|
|
}
|
|
|
|
commitFiles := make([]*models.CommitFile, 0, len(fields)/2)
|
|
for i := 0; i < len(fields)-1; {
|
|
changeStatus := fields[i]
|
|
if changeStatus[0] == 'R' || changeStatus[0] == 'C' {
|
|
// The status has a similarity score appended (e.g. "R100"); drop it
|
|
// so the rest of the code only has to deal with a plain "R" or "C".
|
|
commitFiles = append(commitFiles, &models.CommitFile{
|
|
ChangeStatus: changeStatus[:1],
|
|
PreviousPath: fields[i+1],
|
|
Path: fields[i+2],
|
|
})
|
|
i += 3
|
|
} else {
|
|
// typical result looks like 'A my_file' meaning my_file was added
|
|
commitFiles = append(commitFiles, &models.CommitFile{
|
|
ChangeStatus: changeStatus,
|
|
Path: fields[i+1],
|
|
})
|
|
i += 2
|
|
}
|
|
}
|
|
|
|
return commitFiles
|
|
}
|