mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-08-28 02:24:49 -05:00
Stefan HallerandClaude Opus 5
29d05e23f9
Since scrolling the selection into view became opt-in, five places have had to be fixed by hand after the fact, none of them with a test. Cover them now: making the scrolling automatic has to keep all five working, and once it does, the hand-added scroll calls can go. Two of them assert that the selection is visible rather than on an exact scroll position, because the panel they look at changes height along the way (filtering mode switches to half screen), or because what matters is only that the commit we jumped to can be seen. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
40 lines
987 B
Go
40 lines
987 B
Go
package ui
|
|
|
|
import (
|
|
"github.com/jesseduffield/lazygit/pkg/config"
|
|
. "github.com/jesseduffield/lazygit/pkg/integration/components"
|
|
)
|
|
|
|
var MenuScrollPositionIsReset = NewIntegrationTest(NewIntegrationTestArgs{
|
|
Description: "A menu that is opened after a scrolled down one starts at the top again",
|
|
ExtraCmdArgs: []string{},
|
|
Skip: false,
|
|
SetupConfig: func(config *config.AppConfig) {},
|
|
SetupRepo: func(shell *Shell) {
|
|
shell.CreateFile("myfile", "myfile")
|
|
},
|
|
Run: func(t *TestDriver, keys config.KeybindingConfig) {
|
|
t.Views().Files().
|
|
IsFocused().
|
|
Press(keys.Universal.OptionMenu)
|
|
|
|
t.Views().Menu().
|
|
IsFocused().
|
|
// The first line is a section header, so the first item is at index 1
|
|
SelectedLineIdx(1).
|
|
OriginY(0).
|
|
Press(keys.Universal.GotoBottom).
|
|
OriginYAtLeast(1).
|
|
PressEscape()
|
|
|
|
t.Views().Files().
|
|
IsFocused().
|
|
Press(keys.Universal.OptionMenu)
|
|
|
|
t.Views().Menu().
|
|
IsFocused().
|
|
SelectedLineIdx(1).
|
|
OriginY(0)
|
|
},
|
|
})
|