mirror of
https://github.com/jesseduffield/lazygit.git
synced 2026-08-28 10:15:32 -05:00
`b` on a merge conflict is meant to keep both sides. With the diff3 conflict style git additionally renders the common ancestor between the two sides, and the old ALL selection kept everything between the outermost markers, dragging that ancestor into the resolved file. Rename the selection from ALL to BOTH and restrict it to the top and bottom hunks so the common base is dropped. Without the diff3 style there is no ancestor section, so the behaviour there is unchanged. The user-facing keybinding config was already named pickBothHunks; only the internal enum, handler, translation and log string still said "all". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
336 lines
9.0 KiB
Go
336 lines
9.0 KiB
Go
package controllers
|
|
|
|
import (
|
|
"os"
|
|
|
|
"github.com/jesseduffield/lazygit/pkg/gocui"
|
|
"github.com/jesseduffield/lazygit/pkg/gui/context"
|
|
"github.com/jesseduffield/lazygit/pkg/gui/mergeconflicts"
|
|
"github.com/jesseduffield/lazygit/pkg/gui/types"
|
|
)
|
|
|
|
type MergeConflictsController struct {
|
|
baseController
|
|
c *ControllerCommon
|
|
}
|
|
|
|
var _ types.IController = &MergeConflictsController{}
|
|
|
|
func NewMergeConflictsController(
|
|
c *ControllerCommon,
|
|
) *MergeConflictsController {
|
|
return &MergeConflictsController{
|
|
baseController: baseController{},
|
|
c: c,
|
|
}
|
|
}
|
|
|
|
func (self *MergeConflictsController) GetKeybindings(opts types.KeybindingsOpts) []*types.Binding {
|
|
bindings := []*types.Binding{
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.Select),
|
|
Handler: self.withRenderAndFocus(self.HandlePickHunk),
|
|
Description: self.c.Tr.PickHunk,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Main.PickBothHunks),
|
|
Handler: self.withRenderAndFocus(self.HandlePickBothHunks),
|
|
Description: self.c.Tr.PickBothHunks,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.PrevItem),
|
|
Handler: self.withRenderAndFocus(self.PrevConflictHunk),
|
|
Description: self.c.Tr.SelectPrevHunk,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.NextItem),
|
|
Handler: self.withRenderAndFocus(self.NextConflictHunk),
|
|
Description: self.c.Tr.SelectNextHunk,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Main.PrevHunk),
|
|
Handler: self.withRenderAndFocus(self.PrevConflict),
|
|
Description: self.c.Tr.PrevConflict,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Main.NextHunk),
|
|
Handler: self.withRenderAndFocus(self.NextConflict),
|
|
Description: self.c.Tr.NextConflict,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.Undo),
|
|
Handler: self.withRenderAndFocus(self.HandleUndo),
|
|
Description: self.c.Tr.Undo,
|
|
Tooltip: self.c.Tr.UndoMergeResolveTooltip,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.Edit),
|
|
Handler: self.HandleEditFile,
|
|
Description: self.c.Tr.EditFile,
|
|
Tooltip: self.c.Tr.EditFileTooltip,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.OpenFile),
|
|
Handler: self.HandleOpenFile,
|
|
Description: self.c.Tr.OpenFile,
|
|
Tooltip: self.c.Tr.OpenFileTooltip,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.ScrollLeft),
|
|
Handler: self.withRenderAndFocus(self.HandleScrollLeft),
|
|
Description: self.c.Tr.ScrollLeft,
|
|
Tag: "navigation",
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.ScrollRight),
|
|
Handler: self.withRenderAndFocus(self.HandleScrollRight),
|
|
Description: self.c.Tr.ScrollRight,
|
|
Tag: "navigation",
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Files.OpenMergeOptions),
|
|
Handler: self.openMergeConflictMenu,
|
|
Description: self.c.Tr.ViewMergeConflictOptions,
|
|
Tooltip: self.c.Tr.ViewMergeConflictOptionsTooltip,
|
|
OpensMenu: true,
|
|
DisplayOnScreen: true,
|
|
},
|
|
{
|
|
Keys: opts.GetKeys(opts.Config.Universal.Return),
|
|
Handler: self.Escape,
|
|
Description: self.c.Tr.ReturnToFilesPanel,
|
|
},
|
|
}
|
|
|
|
return bindings
|
|
}
|
|
|
|
func (self *MergeConflictsController) GetMouseKeybindings(opts types.KeybindingsOpts) []*gocui.ViewMouseBinding {
|
|
return []*gocui.ViewMouseBinding{
|
|
{
|
|
ViewName: self.context().GetViewName(),
|
|
Key: gocui.MouseWheelUp,
|
|
Handler: func(gocui.ViewMouseBindingOpts) error {
|
|
return self.HandleScrollUp()
|
|
},
|
|
},
|
|
{
|
|
ViewName: self.context().GetViewName(),
|
|
Key: gocui.MouseWheelDown,
|
|
Handler: func(gocui.ViewMouseBindingOpts) error {
|
|
return self.HandleScrollDown()
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func (self *MergeConflictsController) GetOnFocus() func(types.OnFocusOpts) {
|
|
return func(types.OnFocusOpts) {
|
|
self.c.Views().MergeConflicts.Wrap = false
|
|
|
|
self.c.Helpers().MergeConflicts.Render()
|
|
|
|
self.context().SetSelectedLineRange()
|
|
}
|
|
}
|
|
|
|
func (self *MergeConflictsController) GetOnFocusLost() func(types.OnFocusLostOpts) {
|
|
return func(types.OnFocusLostOpts) {
|
|
self.context().SetUserScrolling(false)
|
|
self.context().GetState().ResetConflictSelection()
|
|
self.c.Views().MergeConflicts.Wrap = true
|
|
}
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandleScrollUp() error {
|
|
self.context().SetUserScrolling(true)
|
|
self.context().GetViewTrait().ScrollUp(self.c.UserConfig().Gui.ScrollHeight)
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandleScrollDown() error {
|
|
self.context().SetUserScrolling(true)
|
|
self.context().GetViewTrait().ScrollDown(self.c.UserConfig().Gui.ScrollHeight)
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) Context() types.Context {
|
|
return self.context()
|
|
}
|
|
|
|
func (self *MergeConflictsController) context() *context.MergeConflictsContext {
|
|
return self.c.Contexts().MergeConflicts
|
|
}
|
|
|
|
func (self *MergeConflictsController) Escape() error {
|
|
self.c.Context().Pop()
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandleEditFile() error {
|
|
lineNumber := self.context().GetState().GetSelectedLine()
|
|
return self.c.Helpers().Files.EditFileAtLine(self.context().GetState().GetPath(), lineNumber)
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandleOpenFile() error {
|
|
return self.c.Helpers().Files.OpenFile(self.context().GetState().GetPath())
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandleScrollLeft() error {
|
|
self.context().GetViewTrait().ScrollLeft()
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandleScrollRight() error {
|
|
self.context().GetViewTrait().ScrollRight()
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandleUndo() error {
|
|
state := self.context().GetState()
|
|
|
|
ok := state.Undo()
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
self.c.LogAction("Restoring file to previous state")
|
|
self.c.LogCommand(self.c.Tr.Log.HandleUndo, false)
|
|
if err := os.WriteFile(state.GetPath(), []byte(state.GetContent()), 0o644); err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) PrevConflictHunk() error {
|
|
self.context().SetUserScrolling(false)
|
|
self.context().GetState().SelectPrevConflictHunk()
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) NextConflictHunk() error {
|
|
self.context().SetUserScrolling(false)
|
|
self.context().GetState().SelectNextConflictHunk()
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) NextConflict() error {
|
|
self.context().SetUserScrolling(false)
|
|
self.context().GetState().SelectNextConflict()
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) PrevConflict() error {
|
|
self.context().SetUserScrolling(false)
|
|
self.context().GetState().SelectPrevConflict()
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandlePickHunk() error {
|
|
return self.pickSelection(self.context().GetState().Selection())
|
|
}
|
|
|
|
func (self *MergeConflictsController) HandlePickBothHunks() error {
|
|
return self.pickSelection(mergeconflicts.BOTH)
|
|
}
|
|
|
|
func (self *MergeConflictsController) pickSelection(selection mergeconflicts.Selection) error {
|
|
ok, err := self.resolveConflict(selection)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
if self.context().GetState().AllConflictsResolved() {
|
|
self.onLastConflictResolved()
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (self *MergeConflictsController) resolveConflict(selection mergeconflicts.Selection) (bool, error) {
|
|
self.context().SetUserScrolling(false)
|
|
|
|
state := self.context().GetState()
|
|
|
|
ok, content, err := state.ContentAfterConflictResolve(selection)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
if !ok {
|
|
return false, nil
|
|
}
|
|
|
|
var logStr string
|
|
switch selection {
|
|
case mergeconflicts.TOP:
|
|
logStr = "Picking top hunk"
|
|
case mergeconflicts.MIDDLE:
|
|
logStr = "Picking middle hunk"
|
|
case mergeconflicts.BOTTOM:
|
|
logStr = "Picking bottom hunk"
|
|
case mergeconflicts.BOTH:
|
|
logStr = "Picking both hunks"
|
|
}
|
|
self.c.LogAction("Resolve merge conflict")
|
|
self.c.LogCommand(logStr, false)
|
|
state.PushContent(content)
|
|
return true, os.WriteFile(state.GetPath(), []byte(content), 0o644)
|
|
}
|
|
|
|
func (self *MergeConflictsController) onLastConflictResolved() {
|
|
// as part of refreshing files, we handle the situation where a file has had
|
|
// its merge conflicts resolved.
|
|
self.c.Refresh(types.RefreshOptions{Mode: types.ASYNC, Scope: []types.RefreshableView{types.FILES}})
|
|
}
|
|
|
|
func (self *MergeConflictsController) openMergeConflictMenu() error {
|
|
filepath := self.context().GetState().GetPath()
|
|
return self.c.Helpers().WorkingTree.CreateMergeConflictMenu([]string{filepath})
|
|
}
|
|
|
|
func (self *MergeConflictsController) withRenderAndFocus(f func() error) func() error {
|
|
return self.withLock(func() error {
|
|
if err := f(); err != nil {
|
|
return err
|
|
}
|
|
|
|
self.context().RenderAndFocus()
|
|
return nil
|
|
})
|
|
}
|
|
|
|
func (self *MergeConflictsController) withLock(f func() error) func() error {
|
|
return func() error {
|
|
self.context().GetMutex().Lock()
|
|
defer self.context().GetMutex().Unlock()
|
|
|
|
if self.context().GetState() == nil {
|
|
return nil
|
|
}
|
|
|
|
return f()
|
|
}
|
|
}
|