Stefan HallerandClaude Opus 4.8 c21ce61729 Synchronize ViewBufferManager.Close with a starting task ...

Close read and called stopCurrentTask with no lock, while NewTask's
goroutine assigns it (and constructs the sync.Once it closes over) under
waitingMutex. On shutdown Close runs while a render task spawned by the
last layout is still starting, so the two raced on the field and the
once (three DATA RACE blocks under -race, e.g. cherry_pick).

Read stopCurrentTask once under waitingMutex and call the captured value
instead of re-reading the field, which establishes the happens-before
the once needs. This can't deadlock: no task holds waitingMutex across a
blocking UI-thread hop, so Close can always take it, and a task wedged in
such a hop is still bounded by the existing 3s timeout.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-09 14:28:29 +02:00

..

async_handler_test.go

Copy gocui files into lazygit repo under pkg/gocui

2026-04-30 14:29:08 +02:00

async_handler.go

Copy gocui files into lazygit repo under pkg/gocui

2026-04-30 14:29:08 +02:00

tasks_test.go

Abstract task command over *exec.Cmd

2026-07-03 18:47:15 +02:00

tasks.go

Synchronize ViewBufferManager.Close with a starting task

2026-07-09 14:28:29 +02:00