Files
lazygit/vendor/mvdan.cc/gofumpt/gofmt.go
T

838 lines
25 KiB
Go

// Copyright 2009 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
import (
"bytes"
"context"
"flag"
"fmt"
"go/ast"
"go/parser"
"go/scanner"
"go/token"
"io"
"io/fs"
"math/rand"
"os"
"path/filepath"
"regexp"
"runtime"
"runtime/pprof"
"strconv"
"strings"
"sync"
// NOTE(gofumpt): x/mod/modfile is used to read each file's go.mod for the
// default -lang and -modpath, and to honor `ignore` directives.
"golang.org/x/mod/modfile"
"golang.org/x/sync/semaphore"
// NOTE(gofumpt): the format package exposes gofumpt's added rules and
// simplification as a public Go API. diff and go/printer are vendored
// copies frozen at a specific Go version, so gofumpt's output is
// reproducible regardless of the user's Go toolchain.
gformat "mvdan.cc/gofumpt/format"
"mvdan.cc/gofumpt/internal/govendor/diff"
"mvdan.cc/gofumpt/internal/govendor/go/printer"
gversion "mvdan.cc/gofumpt/internal/version"
)
// NOTE(gofumpt): regenerate the vendored Go source under internal/govendor,
// then re-format it with the freshly built gofumpt binary.
//go:generate go run gen_govendor.go
//go:generate go run . -w internal/govendor
var (
// main operation modes
list = flag.Bool("l", false, "")
write = flag.Bool("w", false, "")
doDiff = flag.Bool("d", false, "")
allErrors = flag.Bool("e", false, "")
// debugging
cpuprofile = flag.String("cpuprofile", "", "")
// NOTE(gofumpt): gofumpt's own flags.
// -lang sets the target Go language version for version-gated rules
// (e.g. octal literal syntax requires go1.13); defaulted from go.mod.
// -modpath sets the current module path so import grouping can treat
// imports sharing that prefix as third-party; defaulted from go.mod.
// -extra opts in to non-default rules like group_params.
// -version prints the gofumpt build version (set via -ldflags=main.version=).
langVersion = flag.String("lang", "", "")
modulePath = flag.String("modpath", "", "")
extraRules gformat.Extra
showVersion = flag.Bool("version", false, "")
// NOTE(gofumpt): -r and -s are kept only to print a friendly error.
// -r was dropped in favor of `gofmt -r`; -s is always on (gofumpt always
// simplifies).
rewriteRule = flag.String("r", "", "")
simplifyAST = flag.Bool("s", false, "")
// errors
// NOTE(gofumpt): sentinel used to drive exit code 1 when -d found
// formatting differences. Upstream gofmt does not change its exit code
// on -d; gofumpt's -d acts like `diff` so CI checks can rely on the
// nonzero exit. See reporter.Report below.
errFormattingDiffers = fmt.Errorf("formatting differs from gofumpt's")
)
func init() { flag.Var(&extraRules, "extra", "") }
// NOTE(gofumpt): set via -ldflags=main.version=... at release time so that
// `gofumpt -version` reports a meaningful string for prebuilt binaries.
var version = ""
// Keep these in sync with go/format/format.go.
const (
tabWidth = 8
printerMode = printer.UseSpaces | printer.TabIndent | printerNormalizeNumbers
// printerNormalizeNumbers means to canonicalize number literal prefixes
// and exponents while printing. See https://golang.org/doc/go1.13#gofmt.
//
// This value is defined in go/printer specifically for go/format and cmd/gofmt.
printerNormalizeNumbers = 1 << 30
)
// fdSem guards the number of concurrently-open file descriptors.
//
// For now, this is arbitrarily set to 200, based on the observation that many
// platforms default to a kernel limit of 256. Ideally, perhaps we should derive
// it from rlimit on platforms that support that system call.
//
// File descriptors opened from outside of this package are not tracked,
// so this limit may be approximate.
var fdSem = make(chan bool, 200)
// NOTE(gofumpt): upstream gofmt declares `rewrite` here for the -r flag; we
// dropped that.
var parserMode parser.Mode
// newFileSet returns a fresh token.FileSet for parsing a single file.
//
// NOTE(gofumpt): we reserve base 1 with a dummy ten-byte file so that
// token.NoPos+1 cannot be a valid position in any real file added later.
// Some of gofumpt's added rules construct positions via token.NoPos+1;
// without this guard, tests starting from an empty FileSet would silently
// map NoPos+1 to a valid offset and hide bugs like #166.
func newFileSet() *token.FileSet {
fset := token.NewFileSet()
fset.AddFile("gofumpt_base.go", 1, 10)
return fset
}
func usage() {
fmt.Fprintf(os.Stderr, `usage: gofumpt [flags] [path ...]
-version show version and exit
-d display diffs instead of rewriting files
-e report all errors (not just the first 10 on different lines)
-l list files whose formatting differs from gofumpt's
-w write result to (source) file instead of stdout
-extra enable extra rules, e.g. -extra=group_params,clothe_returns
-lang str target Go version in the form "go1.X" (default from go.mod)
-modpath str Go module path containing the source file (default from go.mod)
`)
}
func initParserMode() {
// NOTE(gofumpt): always SkipObjectResolution. Upstream only sets it when
// -r is unused (object resolution is needed for the rewrite engine), but
// gofumpt has no -r flag, so we can always skip it for speed.
parserMode = parser.ParseComments | parser.SkipObjectResolution
if *allErrors {
parserMode |= parser.AllErrors
}
}
// NOTE(gofumpt): split out from upstream's isGoFile. Upstream combined the
// name check with `!f.IsDir()`, but gofumpt's WalkDir callback already
// distinguishes directories, and explicit non-.go arguments are formatted too,
// so the name-only test is needed independently.
func isGoFilename(name string) bool {
return !strings.HasPrefix(name, ".") && strings.HasSuffix(name, ".go")
}
// NOTE(gofumpt): generated-file detection. gofumpt's added rules are not
// applied to generated Go files unless they are passed explicitly on the
// command line; this avoids churning machine-written code that humans don't
// edit. See processFile below for the `explicit || !isGenerated(file)` gate.
var rxCodeGenerated = regexp.MustCompile(`^// Code generated .* DO NOT EDIT\.$`)
func isGenerated(file *ast.File) bool {
for _, cg := range file.Comments {
if cg.Pos() > file.Package {
return false
}
for _, line := range cg.List {
if rxCodeGenerated.MatchString(line.Text) {
return true
}
}
}
return false
}
// A sequencer performs concurrent tasks that may write output, but emits that
// output in a deterministic order.
type sequencer struct {
maxWeight int64
sem *semaphore.Weighted // weighted by input bytes (an approximate proxy for memory overhead)
prev <-chan *reporterState // 1-buffered
}
// newSequencer returns a sequencer that allows concurrent tasks up to maxWeight
// and writes tasks' output to out and err.
func newSequencer(maxWeight int64, out, err io.Writer) *sequencer {
sem := semaphore.NewWeighted(maxWeight)
prev := make(chan *reporterState, 1)
prev <- &reporterState{out: out, err: err}
return &sequencer{
maxWeight: maxWeight,
sem: sem,
prev: prev,
}
}
// exclusive is a weight that can be passed to a sequencer to cause
// a task to be executed without any other concurrent tasks.
const exclusive = -1
// Add blocks until the sequencer has enough weight to spare, then adds f as a
// task to be executed concurrently.
//
// If the weight is either negative or larger than the sequencer's maximum
// weight, Add blocks until all other tasks have completed, then the task
// executes exclusively (blocking all other calls to Add until it completes).
//
// f may run concurrently in a goroutine, but its output to the passed-in
// reporter will be sequential relative to the other tasks in the sequencer.
//
// If f invokes a method on the reporter, execution of that method may block
// until the previous task has finished. (To maximize concurrency, f should
// avoid invoking the reporter until it has finished any parallelizable work.)
//
// If f returns a non-nil error, that error will be reported after f's output
// (if any) and will cause a nonzero final exit code.
func (s *sequencer) Add(weight int64, f func(*reporter) error) {
if weight < 0 || weight > s.maxWeight {
weight = s.maxWeight
}
if err := s.sem.Acquire(context.TODO(), weight); err != nil {
// Change the task from "execute f" to "report err".
weight = 0
f = func(*reporter) error { return err }
}
r := &reporter{prev: s.prev}
next := make(chan *reporterState, 1)
s.prev = next
// Start f in parallel: it can run until it invokes a method on r, at which
// point it will block until the previous task releases the output state.
go func() {
if err := f(r); err != nil {
r.Report(err)
}
next <- r.getState() // Release the next task.
s.sem.Release(weight)
}()
}
// AddReport prints an error to s after the output of any previously-added
// tasks, causing the final exit code to be nonzero.
func (s *sequencer) AddReport(err error) {
s.Add(0, func(*reporter) error { return err })
}
// GetExitCode waits for all previously-added tasks to complete, then returns an
// exit code for the sequence suitable for passing to os.Exit.
func (s *sequencer) GetExitCode() int {
c := make(chan int, 1)
s.Add(0, func(r *reporter) error {
c <- r.ExitCode()
return nil
})
return <-c
}
// A reporter reports output, warnings, and errors.
type reporter struct {
prev <-chan *reporterState
state *reporterState
}
// reporterState carries the state of a reporter instance.
//
// Only one reporter at a time may have access to a reporterState.
type reporterState struct {
out, err io.Writer
exitCode int
}
// getState blocks until any prior reporters are finished with the reporter
// state, then returns the state for manipulation.
func (r *reporter) getState() *reporterState {
if r.state == nil {
r.state = <-r.prev
}
return r.state
}
// Warnf emits a warning message to the reporter's error stream,
// without changing its exit code.
func (r *reporter) Warnf(format string, args ...any) {
fmt.Fprintf(r.getState().err, format, args...)
}
// Write emits a slice to the reporter's output stream.
//
// Any error is returned to the caller, and does not otherwise affect the
// reporter's exit code.
func (r *reporter) Write(p []byte) (int, error) {
return r.getState().out.Write(p)
}
// Report emits a non-nil error to the reporter's error stream,
// changing its exit code to a nonzero value.
func (r *reporter) Report(err error) {
if err == nil {
panic("Report with nil error")
}
st := r.getState()
if err == errFormattingDiffers {
st.exitCode = 1
} else {
scanner.PrintError(st.err, err)
st.exitCode = 2
}
}
func (r *reporter) ExitCode() int {
return r.getState().exitCode
}
// If info == nil, we are formatting stdin instead of a file.
// If in == nil, the source is the contents of the file with the given filename.
//
// NOTE(gofumpt): the `explicit` parameter (added vs upstream) tracks whether
// this file was named directly on the command line. Explicit files always get
// the gofumpt rules applied (even generated files); walked files do not when
// they look generated. It also forces non-.go explicit args to be formatted.
func processFile(filename string, info fs.FileInfo, in io.Reader, r *reporter, explicit bool) error {
src, err := readFile(filename, info, in)
if err != nil {
return err
}
fileSet := newFileSet()
// If we are formatting stdin, we accept a program fragment in lieu of a
// complete source file.
fragmentOk := info == nil
file, sourceAdj, indentAdj, err := parse(fileSet, filename, src, fragmentOk)
if err != nil {
return err
}
ast.SortImports(fileSet, file)
// NOTE(gofumpt): from here until the call to format() below is the
// gofumpt-specific work upstream gofmt does not do: resolve -lang and
// -modpath defaults from the file's containing go.mod, then run
// gformat.File to apply the added rules (and simplification, which
// gofumpt always runs in lieu of the dropped -s flag). Apply gofumpt's
// changes before we print the code in gofumpt's format.
// If either -lang or -modpath aren't set, fetch them from go.mod.
lang := *langVersion
modpath := *modulePath
if lang == "" || modpath == "" {
path, err := filepath.Abs(filename)
if err != nil {
return err
}
if mod := loadModule(filepath.Dir(path)); mod != nil {
if lang == "" {
if mod.file.Go == nil {
// If the go directive is missing, go 1.16 is assumed.
// https://go.dev/ref/mod#go-mod-file-go
lang = "go1.16"
} else {
lang = "go" + mod.file.Go.Version
}
}
if m := mod.file.Module; m != nil && modpath == "" {
modpath = m.Mod.Path
}
}
}
// We always apply the gofumpt formatting rules to explicit files, including stdin.
// Otherwise, we don't apply them on generated files.
// We also skip walking vendor directories entirely, but that happens elsewhere.
if explicit || !isGenerated(file) {
gformat.File(fileSet, file, gformat.Options{
LangVersion: lang,
ModulePath: modpath,
Extra: extraRules,
})
}
res, err := format(fileSet, file, sourceAdj, indentAdj, src, printer.Config{Mode: printerMode, Tabwidth: tabWidth})
if err != nil {
return err
}
if !bytes.Equal(src, res) {
// formatting has changed
if *list {
fmt.Fprintln(r, filename)
}
if *write {
if info == nil {
panic("-w should not have been allowed with stdin")
}
perm := info.Mode().Perm()
if err := writeFile(filename, src, res, perm, info.Size()); err != nil {
return err
}
}
if *doDiff {
newName := filepath.ToSlash(filename)
oldName := newName + ".orig"
r.Write(diff.Diff(oldName, src, newName, res))
return errFormattingDiffers
}
}
if !*list && !*write && !*doDiff {
_, err = r.Write(res)
}
return err
}
// readFile reads the contents of filename, described by info.
// If in is non-nil, readFile reads directly from it.
// Otherwise, readFile opens and reads the file itself,
// with the number of concurrently-open files limited by fdSem.
func readFile(filename string, info fs.FileInfo, in io.Reader) ([]byte, error) {
if in == nil {
fdSem <- true
var err error
f, err := os.Open(filename)
if err != nil {
return nil, err
}
in = f
defer func() {
f.Close()
<-fdSem
}()
}
// Compute the file's size and read its contents with minimal allocations.
//
// If we have the FileInfo from filepath.WalkDir, use it to make
// a buffer of the right size and avoid ReadAll's reallocations.
//
// If the size is unknown (or bogus, or overflows an int), fall back to
// a size-independent ReadAll.
size := -1
if info != nil && info.Mode().IsRegular() && int64(int(info.Size())) == info.Size() {
size = int(info.Size())
}
if size+1 <= 0 {
// The file is not known to be regular, so we don't have a reliable size for it.
var err error
src, err := io.ReadAll(in)
if err != nil {
return nil, err
}
return src, nil
}
// We try to read size+1 bytes so that we can detect modifications: if we
// read more than size bytes, then the file was modified concurrently.
// (If that happens, we could, say, append to src to finish the read, or
// proceed with a truncated buffer — but the fact that it changed at all
// indicates a possible race with someone editing the file, so we prefer to
// stop to avoid corrupting it.)
src := make([]byte, size+1)
n, err := io.ReadFull(in, src)
switch err {
case nil, io.EOF, io.ErrUnexpectedEOF:
// io.ReadFull returns io.EOF (for an empty file) or io.ErrUnexpectedEOF
// (for a non-empty file) if the file was changed unexpectedly. Continue
// with comparing file sizes in those cases.
default:
return nil, err
}
if n < size {
return nil, fmt.Errorf("error: size of %s changed during reading (from %d to %d bytes)", filename, size, n)
} else if n > size {
return nil, fmt.Errorf("error: size of %s changed during reading (from %d to >=%d bytes)", filename, size, len(src))
}
return src[:n], nil
}
func main() {
// Arbitrarily limit in-flight work to 2MiB times the number of threads.
//
// The actual overhead for the parse tree and output will depend on the
// specifics of the file, but this at least keeps the footprint of the process
// roughly proportional to GOMAXPROCS.
maxWeight := (2 << 20) * int64(runtime.GOMAXPROCS(0))
s := newSequencer(maxWeight, os.Stdout, os.Stderr)
// call gofmtMain in a separate function
// so that it can use defer and have them
// run before the exit.
gofmtMain(s)
os.Exit(s.GetExitCode())
}
func gofmtMain(s *sequencer) {
flag.Usage = usage
flag.Parse()
// NOTE(gofumpt): friendly handling of the dropped -s and -r flags so users
// migrating from gofmt get a clear message rather than "flag provided but
// not defined". -s is always on; -r is delegated to `gofmt -r`.
if *simplifyAST {
fmt.Fprintf(os.Stderr, "warning: -s is deprecated as it is always enabled\n")
}
if *rewriteRule != "" {
fmt.Fprintf(os.Stderr, `the rewrite flag is no longer available; use "gofmt -r" instead`+"\n")
os.Exit(2)
}
// NOTE(gofumpt): print the gofumpt version if the user asks for it.
// -version dumps the build version and any embedded build-info fields
// (see internal/version), useful for bug reports and `//gofumpt:diagnose`.
if *showVersion {
fmt.Println(gversion.String(version))
return
}
if *cpuprofile != "" {
fdSem <- true
f, err := os.Create(*cpuprofile)
if err != nil {
s.AddReport(fmt.Errorf("creating cpu profile: %s", err))
return
}
defer func() {
f.Close()
<-fdSem
}()
pprof.StartCPUProfile(f)
defer pprof.StopCPUProfile()
}
initParserMode()
args := flag.Args()
if len(args) == 0 {
if *write {
s.AddReport(fmt.Errorf("error: cannot use -w with standard input"))
return
}
s.Add(0, func(r *reporter) error {
// TODO: test explicit==true
return processFile("<standard input>", nil, os.Stdin, r, true)
})
return
}
// NOTE(gofumpt): the argument-walking loop below is rewritten vs upstream.
// Upstream branched on os.Stat (file vs dir); gofumpt always uses
// filepath.WalkDir and tracks `explicit := path == arg` so that:
// - explicit non-.go and explicit generated files are still formatted;
// - vendor/testdata directories and go.mod `ignore` entries are skipped
// during walks but honored when named directly (so `gofumpt -w vendor`
// still works);
// - the explicit bit propagates into processFile to gate gofumpt rules.
for _, arg := range args {
// Walk each given argument as a directory tree.
// If the argument is not a directory, it's always formatted as a Go file.
// If the argument is a directory, we walk it, ignoring non-Go files.
arg = filepath.Clean(arg) // ensure consistency
if err := filepath.WalkDir(arg, func(path string, d fs.DirEntry, err error) error {
explicit := path == arg
switch {
case err != nil:
return err
case d.IsDir():
if !explicit && shouldIgnore(path) {
return filepath.SkipDir
}
return nil // simply recurse into directories
case explicit:
// non-directories given as explicit arguments are always formatted
case !isGoFilename(d.Name()):
return nil // skip walked non-Go files
}
info, err := d.Info()
if err != nil {
return err
}
s.Add(fileWeight(path, info), func(r *reporter) error {
return processFile(path, info, nil, r, explicit)
})
return nil
}); err != nil {
s.AddReport(err)
}
}
}
// NOTE(gofumpt): everything from here to the end of the file is gofumpt-only.
// shouldIgnore implements skipping `vendor` and `testdata` directories during
// walks, plus honoring Go 1.25's `ignore` directives in go.mod. These are
// skipped during recursive walks but still formatted when named explicitly.
func shouldIgnore(path string) bool {
switch filepath.Base(path) {
case "vendor", "testdata":
return true
}
path, err := filepath.Abs(path)
if err != nil {
return false // unclear how this could happen; don't ignore in any case
}
mod := loadModule(path)
if mod == nil {
return false // no module file to declare ignore paths
}
relPath, err := filepath.Rel(mod.absDir, path)
if err != nil {
return false // unclear how this could happen; don't ignore in any case
}
relPath = normalizePath(relPath)
for _, ignore := range mod.file.Ignore {
if matchIgnore(ignore.Path, relPath) {
return true
}
}
return false
}
// normalizePath adds slashes to the front and end of the given path.
func normalizePath(path string) string {
path = filepath.ToSlash(path) // ensure Windows support
if !strings.HasPrefix(path, "/") {
path = "/" + path
}
if !strings.HasSuffix(path, "/") {
path += "/"
}
return path
}
func matchIgnore(ignore, relPath string) bool {
ignore, rooted := strings.CutPrefix(ignore, "./")
ignore = normalizePath(ignore)
// Note that we only match the directory to be ignored itself,
// and not any directories underneath it.
// This way, using `gofumpt -w ignored` allows `ignored/subdir` to be formatted.
if rooted {
return relPath == ignore
}
return strings.HasSuffix(relPath, ignore)
}
// NOTE(gofumpt): module loading is gofumpt-only. The go.mod is consulted for
// the default -lang (Go language version, used by version-gated rules), the
// default -modpath (so imports sharing the module prefix are grouped as
// third-party), and the `ignore` directives consumed by shouldIgnore above.
// Results are cached per directory; loadModule walks up to find an enclosing
// go.mod just like the go command would.
//
// A nil entry means the directory is not part of a Go module,
// or a go.mod file was found but it's invalid.
// A non-nil entry means this directory, or a parent, is in a valid Go module.
var cachedModuleByDir sync.Map // map[dirString]*cachedModfile
type cachedModule struct {
absDir string // the directory where the go.mod file was found
file *modfile.File
}
func loadModule(dir string) *cachedModule {
if cached, ok := cachedModuleByDir.Load(dir); ok {
mf, _ := cached.(*cachedModule)
return mf
}
mod := func() *cachedModule {
path := filepath.Join(dir, "go.mod")
fdSem <- true
data, err := os.ReadFile(path)
<-fdSem
if err != nil {
// If the file is missing, or we can't read this directory at all
// (e.g. permission denied on a directory listed in `ignore`), keep
// walking up to find an enclosing go.mod.
parent := filepath.Dir(dir)
if parent == "." {
panic("loadModule was not given an absolute path?")
}
if parent == dir {
return nil // reached the filesystem root
}
return loadModule(parent) // try the parent directory
}
file, err := modfile.Parse(filepath.Join(dir, "go.mod"), data, nil)
if err != nil {
return nil // invalid go.mod file
}
return &cachedModule{
absDir: dir,
file: file,
}
}()
if mod != nil {
cachedModuleByDir.Store(dir, mod)
} else {
cachedModuleByDir.Store(dir, nil)
}
return mod
}
func fileWeight(path string, info fs.FileInfo) int64 {
if info == nil {
return exclusive
}
if info.Mode().Type() == fs.ModeSymlink {
var err error
info, err = os.Stat(path)
if err != nil {
return exclusive
}
}
if !info.Mode().IsRegular() {
// For non-regular files, FileInfo.Size is system-dependent and thus not a
// reliable indicator of weight.
return exclusive
}
return info.Size()
}
// writeFile updates a file with the new formatted data.
func writeFile(filename string, orig, formatted []byte, perm fs.FileMode, size int64) error {
// Make a temporary backup file before rewriting the original file.
bakname, err := backupFile(filename, orig, perm)
if err != nil {
return err
}
fdSem <- true
defer func() { <-fdSem }()
fout, err := os.OpenFile(filename, os.O_WRONLY, perm)
if err != nil {
// We couldn't even open the file, so it should
// not have changed.
os.Remove(bakname)
return err
}
defer fout.Close() // for error paths
restoreFail := func(err error) {
fmt.Fprintf(os.Stderr, "gofumpt: %s: error restoring file to original: %v; backup in %s\n", filename, err, bakname)
}
n, err := fout.Write(formatted)
if err == nil && int64(n) < size {
err = fout.Truncate(int64(n))
}
if err != nil {
// Rewriting the file failed.
if n == 0 {
// Original file unchanged.
os.Remove(bakname)
return err
}
// Try to restore the original contents.
no, erro := fout.WriteAt(orig, 0)
if erro != nil {
// That failed too.
restoreFail(erro)
return err
}
if no < n {
// Original file is shorter. Truncate.
if erro = fout.Truncate(int64(no)); erro != nil {
restoreFail(erro)
return err
}
}
if erro := fout.Close(); erro != nil {
restoreFail(erro)
return err
}
// Original contents restored.
os.Remove(bakname)
return err
}
if err := fout.Close(); err != nil {
restoreFail(err)
return err
}
// File updated.
os.Remove(bakname)
return nil
}
// backupFile writes data to a new file named filename<number> with permissions perm,
// with <number> randomly chosen such that the file name is unique. backupFile returns
// the chosen file name.
func backupFile(filename string, data []byte, perm fs.FileMode) (string, error) {
fdSem <- true
defer func() { <-fdSem }()
nextRandom := func() string {
return strconv.Itoa(rand.Int())
}
dir, base := filepath.Split(filename)
var (
bakname string
f *os.File
)
for {
bakname = filepath.Join(dir, base+"."+nextRandom())
var err error
f, err = os.OpenFile(bakname, os.O_RDWR|os.O_CREATE|os.O_EXCL, perm)
if err == nil {
break
}
if !os.IsExist(err) {
return "", err
}
}
// write data to backup file
_, err := f.Write(data)
if err1 := f.Close(); err == nil {
err = err1
}
return bakname, err
}