Stefan HallerandClaude Opus 4.8 d36ce51559 Capture suggestions inputs on the UI thread ...

RefreshSuggestions dispatched to an AsyncHandler worker that read
State.FindSuggestions and the prompt's TextArea (via GetPromptInput)
from the worker goroutine. The main thread rewrites both in
preparePromptPanel when it (re)creates a prompt panel, so an in-flight
suggestions worker races those writes -- two data races surfaced under
-race (filter_by_path/reword_commit_in_filtering_mode).

Capture both on the UI thread (RefreshSuggestions is only ever called
from UI-thread handlers) before dispatching to the worker. This is also
more correct: we search for the input as it was when dispatched, which
is what this request's AsyncHandler id corresponds to.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-07-17 12:35:54 +02:00

..

context

Capture suggestions inputs on the UI thread

2026-07-17 12:35:54 +02:00

controllers

Refresh once when dropping multiple stash entries

2026-07-17 12:35:54 +02:00

filetree

…

mergeconflicts

…

modes

…

patch_exploring

…

popup

Retire WithWaitingStatusSync

2026-07-17 12:32:32 +02:00

presentation

…

services/custom_commands

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

status

Lock the status list when reading it

2026-07-08 18:24:18 +02:00

style

…

types

Remove the now-dead PopupMutex

2026-07-17 12:35:54 +02:00

background.go

Fix data race on the triggerFetch field

2026-07-10 17:16:46 +02:00

command_log_panel.go

Write the command log on the UI thread

2026-07-09 08:41:10 +02:00

context_config.go

…

context.go

…

controllers.go

…

dummies.go

…

editors.go

Capture suggestions inputs on the UI thread

2026-07-17 12:35:54 +02:00

extras_panel.go

…

global_handlers.go

Read lines based on scroll position instead of a fixed per-notch delta

2026-07-09 09:32:35 +02:00

gui_common.go

Read lines based on scroll position instead of a fixed per-notch delta

2026-07-09 09:32:35 +02:00

gui_driver.go

Fix a deadlock between task.Done() and the integration test's idle wait

2026-07-15 15:01:04 +02:00

gui.go

Remove the now-dead PopupMutex

2026-07-17 12:35:54 +02:00

information_panel.go

…

keybindings.go

…

layout.go

Don't show a transient view whose window is not part of the layout

2026-07-17 12:07:24 +02:00

main_panels.go

…

menu_panel.go

…

options_map.go

…

pty.go

Snapshot the view width for command-task rendering on the UI thread

2026-07-17 12:35:54 +02:00

recent_repos_panel.go

…

side_panels_test.go

Assign the transient contexts' initial windows from the side panel config

2026-07-17 12:07:24 +02:00

side_panels.go

Assign the transient contexts' initial windows from the side panel config

2026-07-17 12:07:24 +02:00

tasks_adapter.go

Snapshot the view width for command-task rendering on the UI thread

2026-07-17 12:35:54 +02:00

test_mode.go

Wait for the event loop to exit in integration tests

2026-07-17 12:35:54 +02:00

view_helpers.go

Render content-only when a task reads more lines into a view

2026-07-09 09:32:35 +02:00

views.go

…