Stefan HallerandClaude Fable 5 d52c0a604f Give task commands a Terminate method instead of exposing their process ...

The task stop path terminates the still-running command by pulling its
*os.Process out of the Cmd interface and applying one global strategy
(TerminateProcessGracefully) to it. That shape can't accommodate the
upcoming fix for orphaned process trees on Windows: there, stopping a
pty task requires terminating the entire process tree via a job object
whose handle lives with the pty, not with the process. And the two Cmd
implementations genuinely need different strategies anyway: a
process-group kill (the likely future fix for #5675 on Unix) is only
safe for pty children, which run as session leaders, while plain
commands share lazygit's own process group.

So let each Cmd implementation decide how to terminate itself, and drop
GetProcess, which had no other callers. No change in behavior.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-08-04 07:03:27 +02:00

..

async_handler_test.go

Copy gocui files into lazygit repo under pkg/gocui

2026-04-30 14:29:08 +02:00

async_handler.go

Copy gocui files into lazygit repo under pkg/gocui

2026-04-30 14:29:08 +02:00

tasks_test.go

Reset the view origin for a new task on the UI thread

2026-07-17 12:35:54 +02:00

tasks.go

Give task commands a Terminate method instead of exposing their process

2026-08-04 07:03:27 +02:00