Stefan HallerandClaude Opus 4.8 8c7a41c559 Fold ViewSelectionController into MainViewController ...

ViewSelectionController owned the focused main view's line navigation (up/down
move the selection or scroll, page up/down, goto top/bottom). It was extracted
long ago in case other scrollable views (e.g. a focused command log) would reuse
it, but none ever did — it's only attached to Normal and NormalSecondary, the
two focused main views MainViewController already controls.

Keeping the navigation in a separate controller is now in the way: the next
change makes up/down hunk-aware (move by hunk when hunk-select mode is on),
which needs the selection mode that lives in MainViewController. Rather than
teach the generic-looking ViewSelectionController about that mode, fold its
bindings and handlers into MainViewController and delete it. Behavior-preserving.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-08-08 12:58:59 +02:00

..

context

Stage the selected diff line from the focused main view

2026-08-08 12:58:59 +02:00

controllers

Fold ViewSelectionController into MainViewController

2026-08-08 12:58:59 +02:00

filetree

Make the conflict marker size a parameter of our marker matching

2026-08-08 12:43:42 +02:00

mergeconflicts

Recognize conflict markers that have no label

2026-08-08 12:43:42 +02:00

modes

…

patch_exploring

Recover diff-line identity by parsing the buffer, behind a swappable seam

2026-08-08 12:58:59 +02:00

popup

Decouple hiding the working tree state from blocking input

2026-08-05 17:29:20 +02:00

presentation

Show a Github PR's combined checks state in branches list and main view

2026-08-02 13:06:21 +02:00

services/custom_commands

…

status

…

style

…

types

Stage the selected diff line from the focused main view

2026-08-08 12:58:59 +02:00

background.go

…

command_log_panel.go

Adapt links

2026-07-31 08:42:51 +02:00

context_config.go

…

context.go

…

controllers.go

Fold ViewSelectionController into MainViewController

2026-08-08 12:58:59 +02:00

dummies.go

…

editors.go

…

extras_panel.go

…

global_handlers.go

…

gui_common.go

…

gui_driver.go

Keep the destination visible while commits move

2026-07-31 08:37:28 +02:00

gui.go

Replace gui.showSelectionInFocusedMainView config with on-demand selection

2026-08-08 12:58:59 +02:00

information_panel.go

…

keybindings.go

…

layout.go

Don't scroll a view up to fill blank space while its content is loading

2026-08-08 12:58:59 +02:00

main_panels.go

Reset other main views' scroll after copying content, not before

2026-08-08 12:58:59 +02:00

menu_panel.go

…

options_map.go

…

pty_test.go

Prevent stale index.lock files from diffs rendered through a pty on Windows

2026-08-04 06:53:53 +02:00

pty.go

Rename the diff-line-metadata OSC from 456 to 1717

2026-08-08 12:58:59 +02:00

recent_repos_panel.go

…

side_panels_test.go

…

side_panels.go

…

tasks_adapter_test.go

…

tasks_adapter.go

Reset the scroll to the top at first paint, not when the task starts

2026-08-08 12:58:59 +02:00

test_mode.go

…

test_timeout_norace.go

…

test_timeout_race.go

…

view_helpers.go

Restore the focused main view by patch identity on escape

2026-08-08 12:58:59 +02:00

views.go

…