Stefan HallerandClaude Fable 5 fc975f32a8 Block input while the refresh after a stash operation is in flight ...

Popping or dropping a stash shifts the indices of the entries below it,
and renaming re-creates the stash at the top, shifting all the others.
The stash model is only rebuilt by the refresh, which finishes in the
background, so acting on the next entry in quick succession — pressing
the key, confirming the popup, and pressing again right away — reads the
stale pre-operation indices and targets the wrong stash. Note that the
confirmation popup is no protection here: the race starts when the
confirm handler runs, and the next keypress can easily beat the refresh.

Use RefreshBlockingInput so a quick follow-up keypress is buffered and
replayed once the refreshed stash list is in place.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-22 08:31:11 +02:00

..

helpers

Add RefreshBlockingInput to buffer keypresses until a refresh has landed

2026-07-22 08:31:11 +02:00

attach.go

…

base_controller.go

…

basic_commits_controller.go

Move the new-worktree keybinding from worktrees to universal

2026-07-03 18:53:05 +02:00

bisect_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

branches_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

command_log_controller.go

…

commit_description_controller.go

…

commit_message_controller.go

…

commits_files_controller.go

Block input during the worker commit-surgery ops

2026-07-17 12:32:32 +02:00

common.go

…

confirmation_controller.go

…

context_lines_controller.go

…

custom_patch_options_menu_action.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

diffing_menu_action.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

edit_config_action.go

Extract editConfig into a shared EditConfigAction

2026-06-24 22:03:57 +02:00

files_controller.go

Don't auto-forward branches when the repo was switched during the fetch

2026-07-20 17:07:39 +02:00

filter_controller.go

…

filtering_menu_action.go

Make RefreshOptions.Then a func() error, queue it via OnUIThread

2026-07-07 18:09:33 +02:00

git_flow_controller.go

…

global_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

jump_to_side_window_controller.go

Stop requiring jumpToBlock to have exactly five entries

2026-06-23 14:15:18 +02:00

list_controller_trait.go

…

list_controller.go

…

local_commits_controller_test.go

…

local_commits_controller.go

Block input while the refresh after moving a rebase todo is in flight

2026-07-22 08:31:11 +02:00

main_view_controller.go

…

menu_controller.go

…

menu_key.go

…

merge_conflicts_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

options_menu_action.go

…

patch_building_controller.go

Run the sync commit-surgery ops on a worker with input blocked

2026-07-17 12:32:32 +02:00

patch_explorer_controller_test.go

…

patch_explorer_controller.go

…

prompt_controller.go

…

quit_actions.go

Refuse a repo switch while a foreground operation is in flight

2026-07-07 18:09:33 +02:00

reflog_commits_controller.go

…

remote_branches_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

remotes_controller_test.go

…

remotes_controller.go

Update comments that still describe the removed blocking refresh mode

2026-07-21 22:23:58 +02:00

rename_similarity_threshold_controller.go

Show renamed files in the custom patch builder

2026-07-04 13:05:09 +02:00

screen_mode_actions.go

…

scroll_off_margin_test.go

…

scroll_off_margin.go

…

search_controller.go

…

search_prompt_controller.go

…

shell_command_action.go

…

side_window_controller.go

…

snake_controller.go

…

staging_controller.go

Add RefreshBlockingInput to buffer keypresses until a refresh has landed

2026-07-22 08:31:11 +02:00

stash_controller.go

Block input while the refresh after a stash operation is in flight

2026-07-22 08:31:11 +02:00

status_controller.go

Extract editConfig into a shared EditConfigAction

2026-06-24 22:03:57 +02:00

sub_commits_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

submodules_controller.go

Capture the files, reflog, branches and stash refresh inputs

2026-07-07 18:10:45 +02:00

suggestions_controller.go

…

switch_to_diff_files_controller.go

Move post-COMMIT_FILES-refresh work into Then

2026-07-07 18:09:33 +02:00

switch_to_focused_main_view_controller.go

…

switch_to_sub_commits_controller.go

…

sync_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

tags_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

toggle_whitespace_action.go

…

undo_controller.go

Capture the commits refresh's inputs on the UI thread

2026-07-07 18:10:45 +02:00

vertical_scroll_controller.go

Read lines based on scroll position instead of a fixed per-notch delta

2026-07-09 09:32:35 +02:00

view_selection_controller.go

Read lines based on scroll position instead of a fixed per-notch delta

2026-07-09 09:32:35 +02:00

workspace_reset_controller.go

Remove the RefreshMode field

2026-07-17 12:32:32 +02:00

worktrees_controller.go

Offer to delete the branch when removing a worktree

2026-07-03 19:04:44 +02:00