Neovim's generated keyset types `fg`, `bg`, `sp`, `ctermfg`, `ctermbg`,
and `link` as `integer|string`, and `nvim_set_hl` accepts an integer for
each. Verified against the pinned 0.12.4:
nvim_set_hl(0, "X", { fg = 16711680, ctermfg = 1 })
Nixvim declared all six through `mkNullOrStr`, so those values failed to
evaluate even though the highlight submodule is freeform and would
otherwise have passed them through.
Widen them to `either int str`. An integer means a different thing per
attribute, so say which in each description: `fg`, `bg`, and `sp` take a
24-bit RGB value, `ctermfg` and `ctermbg` take a palette index, and
`link` takes a highlight group id.
`mkNullOrStr` has no remaining use in this file, so drop the import.
`mkNullOrStr` is `maybeRaw str`, so the string attributes of the
highlight submodule already take raw Lua. `5ae4714e` added that for
strings only, which left every boolean and `blend` on a plain type that
rejects it.
Wrap those in `maybeRaw` as well, so computing any highlight attribute
in Lua no longer needs a workaround for the ones that happen to be
booleans.
Modules with a false default did not expose the user option.
Users could not force standard setup generation.
Keep null as the built-in fallback.
Omit the option when Lua configuration is unavailable.
Separate `overlay.nix` and `overlay.internal.nix`, to encapsulate the
`flake` argument. This allows non-flake users to import `./overlay.nix`
without providing a dummy `flake = null` attr.
The read-only `config.flake` option is only defined by `evalNixvim` when
`lib` is extended using the overlay in Nixvim's flake outputs.
Expose a user-facing callSetup option for mkNeovimPlugin users while keeping plugin defaults internal. Preserve optional setup semantics, document the override, and cover the new behavior with unit and failure tests.
Introduce thin wrappers around the `<configuration>.config.build.test`
option, intended to replace the legacy `mkTestDerivationFromNvim` and
`mkTestDerivationFromNixvimModule` functions.
Introduce thin wrappers around the `<configuration>.config.build.package`,
option intended to replace the legacy `makeNixvim` and
`makeNixvimWithModule` functions.
Using `callPackageWith` adds `override` and `overrideDerivation`
attributes to the result, which are not relevant to subsections of
Nixvim's lib section.
Implement our own, simplified, `call` using `intersectAttrs` and
`functionArgs`.
If users wish to modify parts of our lib section, they should extend the
top-level fixpoint to ensure everything stays in sync.
Previously, `lib/top-level.nix` used an `_isExtended` flag to indicate
whether the provided `lib` was already extended. This made bootstrapping
unclear and introduced the possibility of circular construction.
All construction now flows through the lib-overlay, removing
`_isExtended`. As a result, `lib/top-level.nix` always receives the
final extended lib.
The `<flake>.lib.nixvim` output is now defined as:
(lib.extend <nixvim>.lib.overlay).nixvim
The overlay now imports `top-level.nix` directly, making it the
canonical entrypoint for constructing Nixvim's section of the lib.
A clarifying doccomment was added to `lib/top-level.nix`.
Rename the overlay arguments from the conventional `final: prev:` to the
more explicit `lib: prevLib:`, reflecting that this overlay operates
only on the Nixpkgs lib, rather than a full package set.
Add a doccomment explaining how the overlay is intended to be applied
(via `lib.extend`) and what each argument represents.
Improved inline comments in the overlay.
Rename `lib/default.nix` to `lib/top-level.nix` to make its purpose
explicit and discourage importing it directly. Consumers should obtain
the extended lib via flake outputs or the overlay, rather than bypassing
the required bootstrapping logic.
This clarifies the file's role and avoids suggesting it is the primary
entrypoint to Nixvim's lib subsection.
Simplify the `enableExceptInTests` attribute, removing the
`_nixvimTests` argument.
We now do a full re-eval of the nixvim configuration before building the
test, giving us a central place to implement `enableExceptInTests` and
its eventual replacement(s).
This extends support for `enableExceptInTests` to all methods of getting
a nixvim test derivation. Previously, it only worked when using `mkTestDerivationFromNixvimModule`.
In `tests/main.nix`, we avoid the re-eval by doing the initial eval with
a "test mode" lib from the start.
This asserts that we don't accidentally end up with conflicting
definitions.
Such conflicts must be made explicit, e.g. using `mkForce` or `mkDefault`.
Austin Horstman
PierreBorineandAustin Horstman
Matt Sturgeon
FovirandAustin Horstman
Filippo AiraldiandMatt Sturgeon
Robert SliwinskiandAustin Horstman
saygo-pngandMatt Sturgeon
Gaetan LepageandAustin Horstman
fwastringandGaétan Lepage
Heitor AugustoandMatt Sturgeon
ArneandGaétan Lepage
Paul HinzeandGaétan Lepage
santoshxshresthaandMatt Sturgeon
Chelsea WilkinsonandAustin Horstman
Aidan WelchandMatt Sturgeon