From cf874732e09435876e4e6c7ec66bc145d7ab6b03 Mon Sep 17 00:00:00 2001 From: Jan De Dobbeleer Date: Sun, 9 Aug 2026 12:08:05 +0200 Subject: [PATCH] chore(apm): update dependencies --- .../skills/code-changes/references/deliver.md | 3 + .../skills/code-changes/references/plan.md | 12 ++++ .../skills/code-changes/references/verify.md | 16 ++++-- .agents/skills/golang/SKILL.md | 13 +++-- apm.lock.yaml | 56 +++++++++---------- 5 files changed, 64 insertions(+), 36 deletions(-) diff --git a/.agents/skills/code-changes/references/deliver.md b/.agents/skills/code-changes/references/deliver.md index f253870bf..2b7c07f48 100644 --- a/.agents/skills/code-changes/references/deliver.md +++ b/.agents/skills/code-changes/references/deliver.md @@ -24,6 +24,9 @@ Outcome first, then evidence. It contains: 3. Verification evidence: the gates that ran and the concrete functional results observed. 4. Loose ends explicitly left to the user (secrets to delete, manual validation steps, decisions deferred), each with the exact command or check when applicable. +5. What the change did not do that its own headline implies. If a commit says "drop X", state what + of X remains and why. If a capability was removed or replaced, name it as a removal, not as a + simplification. Never report an unverified step as done, and never bury a failure in the middle of a success story. diff --git a/.agents/skills/code-changes/references/plan.md b/.agents/skills/code-changes/references/plan.md index b78fe61b6..7f45e08bf 100644 --- a/.agents/skills/code-changes/references/plan.md +++ b/.agents/skills/code-changes/references/plan.md @@ -12,6 +12,18 @@ Write the spec down before delegating anything. It contains: - Files to touch, and the entry points to start from. - Constraints: style rules, patterns to follow (point at existing code), performance or compatibility requirements. +- The language, framework, and format skills covering the files this task touches. Load them in + this phase, before any code is written, and copy the rules that bind this task into the spec — + control flow, test structure, logging, comment style. A skill loaded at verification does not + prevent violations, it converts them into rework. +- When the change replaces working code (rewrite, port, engine swap, dependency change), enumerate + what the replaced code currently does by reading that code, not the request, and make that list + the acceptance criteria. Keybindings, auto-inserts, defaults, and error messages all count. + Anything on the list you intend to drop is a removal that needs the user's go before you write + the replacement — never a simplification you report afterward. +- Sample data, demo fixtures, and shipped defaults must be generic. Never promote a real person's, + client's, or the user's own data to the default state of the project, even when the source + material came from them — carry it as a private example instead. - Verification commands the implementer must run locally (build, tests, lint). - Explicit non-goals: what the task must NOT change. This is what keeps subagents from wandering. diff --git a/.agents/skills/code-changes/references/verify.md b/.agents/skills/code-changes/references/verify.md index 18b8a7c55..3894140fb 100644 --- a/.agents/skills/code-changes/references/verify.md +++ b/.agents/skills/code-changes/references/verify.md @@ -7,10 +7,13 @@ work by default. ## Quality gates - Build, full test suite, formatters, and linters — all must pass with zero errors. -- Apply the project's language skill when one exists (for example the Go skill's pre-commit - gate: `modernize`, `fieldalignment`, `go mod tidy`, `gofmt`, `golangci-lint`). -- Cross-compile when platform-specific files changed (`_windows.go`, `_unix.go`, and the like) — - the local OS linter skips the other platform's rules. +- Re-read the language and framework skills pinned in Phase 2 and review the final diff against + them by hand, then run whatever pre-commit gate each one defines. Linters do not cover control + flow, test structure, logging, or comment conventions — a green linter is not evidence the skill + was followed. +- Cross-compile or re-lint for every target platform when platform-specific files changed — the + local toolchain skips the other platform's rules. The language skill names how those files are + marked. ## Functional proof @@ -18,6 +21,11 @@ Tests passing is necessary, not sufficient. Run the real flow and confirm concre render the prompt, execute the command, hit the endpoint. Record the actual values observed — the final report quotes them as evidence, not adjectives. +Exercise the flow the way the user will reach it, not only the way the harness reaches it: the +built artifact rather than the dev server, a cold start rather than the running process, the entry +point they actually open. When a dev server or file watcher is in play, restart it before judging +behavior — a stale bundle produces confident, wrong verification. + When the user said they will do the manual validation, state exactly what they should check and what the expected result is. diff --git a/.agents/skills/golang/SKILL.md b/.agents/skills/golang/SKILL.md index e2ec167d9..30208871f 100644 --- a/.agents/skills/golang/SKILL.md +++ b/.agents/skills/golang/SKILL.md @@ -442,10 +442,14 @@ linters catch real bugs and style violations that will be flagged in CI or code After steps 1 through 3, always run `git diff` to review auto-applied changes before staging them. All four steps must complete with zero errors before the commit is created. -#### Platform-specific files (`_unix.go`, `_windows.go`, `_darwin.go`) +#### Platform-specific files (`_unix.go`, `_windows.go`, `_darwin.go`, `_js.go`) -If you add or modify a file with a platform-specific suffix, also cross-compile to catch -issues the local OS linter skips. On Windows, run: +These suffixes, and an explicit `//go:build` constraint, are how a file is bound to one target. +The toolchain type-checks and lints the files selected for the host and nothing else, so a +violation in another platform's file ships silently. + +If you add or modify such a file, also cross-compile to catch issues the local OS linter skips. +On Windows, run: ```powershell $env:GOOS = "linux"; go build ./...; $env:GOOS = "" @@ -458,7 +462,8 @@ GOOS=windows go build ./... ``` This catches import mismatches, missing symbols, and linter rules (like `modernize` -`strings.SplitSeq`) that apply on the non-host platform. +`strings.SplitSeq`) that apply on the non-host platform. Run `golangci-lint run` under the same +`GOOS` so the lint rules are covered too, not the build alone. #### Common golangci-lint violations to fix before committing diff --git a/apm.lock.yaml b/apm.lock.yaml index 373dac2bb..a3b04a7a2 100644 --- a/apm.lock.yaml +++ b/apm.lock.yaml @@ -1,5 +1,5 @@ lockfile_version: '1' -generated_at: '2026-08-03T11:20:07.846712+00:00' +generated_at: '2026-08-09T10:07:39.061154+00:00' apm_version: 0.26.0 dependencies: - repo_url: ast-grep/agent-skill @@ -26,7 +26,7 @@ dependencies: - repo_url: jandedobbeleer/agentic name: agentic-golang host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: 1.0.0 virtual_path: instructions/golang.instructions.md is_virtual: true @@ -40,7 +40,7 @@ dependencies: - repo_url: jandedobbeleer/agentic name: agentic-markdown host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: 1.0.0 virtual_path: instructions/markdown.instructions.md is_virtual: true @@ -54,7 +54,7 @@ dependencies: - repo_url: jandedobbeleer/agentic name: agentic-powershell host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: 1.0.0 virtual_path: instructions/powershell.instructions.md is_virtual: true @@ -68,7 +68,7 @@ dependencies: - repo_url: jandedobbeleer/agentic name: code-changes host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: unknown virtual_path: skills/code-changes is_virtual: true @@ -102,30 +102,30 @@ dependencies: .agents/skills/code-changes/SKILL.md: sha256:e8332f89a1b1c4bfbf897d563357a939bacd607116708062726720c0c74ec184 .agents/skills/code-changes/references/analyze.md: sha256:0a1e4825d315f44f58f13851716b42a9a6a54f6b7a6b17aa101b97d3d1fde75b .agents/skills/code-changes/references/delegate.md: sha256:cfb559d02fd17dd323d89261bea6fa4ce7a59a01ac616c06a43cf88173df2ba0 - .agents/skills/code-changes/references/deliver.md: sha256:f4c48a1adf3139ddb9259339c2919e533ee448b1a1e9b03a1393fc38ebebf0e4 + .agents/skills/code-changes/references/deliver.md: sha256:f4bdbb7f85966aa281c7831acaac981691882960fba14752ffe43e5a3a90cca7 .agents/skills/code-changes/references/escalate.md: sha256:b240512bcc3764ee82fbf880c11d74f4b73e4bee640e64d55ad62fea70484874 .agents/skills/code-changes/references/issue-triage.md: sha256:7e92dad2274802263787f22f80ca5dcf2a2614fd4460650b19cfc5ec904169c2 .agents/skills/code-changes/references/model-tiers.md: sha256:0d21f6f1456bd2ff7f97ece0e181660c9e6270eb1530ad81a6d5a1b324dc0111 - .agents/skills/code-changes/references/plan.md: sha256:d1bdd255c147cd3ea4aaadcbb0d6380c6753af930f23401a4be4473d17b4c165 + .agents/skills/code-changes/references/plan.md: sha256:6f299e0b7c5e7677277bc570d1b76e92f4387a8d37de4877447225e80db36801 .agents/skills/code-changes/references/pr-review-comments.md: sha256:ff3d4be9488c4363b55947ddea07dc350e52d26fe656b4155b5a621cdb37a1c9 .agents/skills/code-changes/references/supervise.md: sha256:6c17cd74c4cac7bfc73d7be7e271f1470662e569e26c6667a5b16a702bd6d9c3 - .agents/skills/code-changes/references/verify.md: sha256:347c831be88cf73e706717f667cc83c1cbd8867d886fecf8ed3bcd24cf69fff6 + .agents/skills/code-changes/references/verify.md: sha256:54530e1e5c4d54000b1046f141cd621e834aeb0c6176f95b76dca35a33c53fc9 .claude/skills/code-changes/SKILL.md: sha256:e8332f89a1b1c4bfbf897d563357a939bacd607116708062726720c0c74ec184 .claude/skills/code-changes/references/analyze.md: sha256:0a1e4825d315f44f58f13851716b42a9a6a54f6b7a6b17aa101b97d3d1fde75b .claude/skills/code-changes/references/delegate.md: sha256:cfb559d02fd17dd323d89261bea6fa4ce7a59a01ac616c06a43cf88173df2ba0 - .claude/skills/code-changes/references/deliver.md: sha256:f4c48a1adf3139ddb9259339c2919e533ee448b1a1e9b03a1393fc38ebebf0e4 + .claude/skills/code-changes/references/deliver.md: sha256:f4bdbb7f85966aa281c7831acaac981691882960fba14752ffe43e5a3a90cca7 .claude/skills/code-changes/references/escalate.md: sha256:b240512bcc3764ee82fbf880c11d74f4b73e4bee640e64d55ad62fea70484874 .claude/skills/code-changes/references/issue-triage.md: sha256:7e92dad2274802263787f22f80ca5dcf2a2614fd4460650b19cfc5ec904169c2 .claude/skills/code-changes/references/model-tiers.md: sha256:0d21f6f1456bd2ff7f97ece0e181660c9e6270eb1530ad81a6d5a1b324dc0111 - .claude/skills/code-changes/references/plan.md: sha256:d1bdd255c147cd3ea4aaadcbb0d6380c6753af930f23401a4be4473d17b4c165 + .claude/skills/code-changes/references/plan.md: sha256:6f299e0b7c5e7677277bc570d1b76e92f4387a8d37de4877447225e80db36801 .claude/skills/code-changes/references/pr-review-comments.md: sha256:ff3d4be9488c4363b55947ddea07dc350e52d26fe656b4155b5a621cdb37a1c9 .claude/skills/code-changes/references/supervise.md: sha256:6c17cd74c4cac7bfc73d7be7e271f1470662e569e26c6667a5b16a702bd6d9c3 - .claude/skills/code-changes/references/verify.md: sha256:347c831be88cf73e706717f667cc83c1cbd8867d886fecf8ed3bcd24cf69fff6 - content_hash: sha256:cdf846ddb0c18729b0c8845d3d6abf7c1970627b2e2a56bf537442e6d5f70237 + .claude/skills/code-changes/references/verify.md: sha256:54530e1e5c4d54000b1046f141cd621e834aeb0c6176f95b76dca35a33c53fc9 + content_hash: sha256:7d139c7ade1661932608375f7c46751c3664a8cc8e39b4cd7d24560da32dcca6 - repo_url: jandedobbeleer/agentic name: conventional-commit host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: unknown virtual_path: skills/conventional-commit is_virtual: true @@ -142,7 +142,7 @@ dependencies: - repo_url: jandedobbeleer/agentic name: golang host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: unknown virtual_path: skills/golang is_virtual: true @@ -153,13 +153,13 @@ dependencies: - .claude/skills/golang - .claude/skills/golang/SKILL.md deployed_file_hashes: - .agents/skills/golang/SKILL.md: sha256:7f902d05e2a53f97e261b1007ba2a529a8578d51b104d10f57f31e183f5d5b25 - .claude/skills/golang/SKILL.md: sha256:7f902d05e2a53f97e261b1007ba2a529a8578d51b104d10f57f31e183f5d5b25 - content_hash: sha256:02af077387c51e6a9b5e9d109f992b4284e84ebf2dbf8aea154eb2bad6ff3ddb + .agents/skills/golang/SKILL.md: sha256:89ff95bbb7d575eafb790bb079e7bdaf6392a71de67b1b835ff70bad1133af2d + .claude/skills/golang/SKILL.md: sha256:89ff95bbb7d575eafb790bb079e7bdaf6392a71de67b1b835ff70bad1133af2d + content_hash: sha256:db25f5feecfd446cb39eb18d32d4efb478fcd7c5452f7b3faf676ba4b6afdbde - repo_url: jandedobbeleer/agentic name: markdown host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: unknown virtual_path: skills/markdown is_virtual: true @@ -176,7 +176,7 @@ dependencies: - repo_url: jandedobbeleer/agentic name: powershell host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: unknown virtual_path: skills/powershell is_virtual: true @@ -193,7 +193,7 @@ dependencies: - repo_url: jandedobbeleer/agentic name: writing-clearly-and-concisely host: github.com - resolved_commit: 0fb21d044eadf675f78605dd30ab8f5c43a04cc1 + resolved_commit: b5f7b6fe301b714aa0281eb47d6cfbdf7bce0cb0 version: unknown virtual_path: skills/writing-clearly-and-concisely is_virtual: true @@ -334,7 +334,7 @@ deployments: owners: - jandedobbeleer/agentic/skills/code-changes active_owner: jandedobbeleer/agentic/skills/code-changes - content_hash: sha256:f4c48a1adf3139ddb9259339c2919e533ee448b1a1e9b03a1393fc38ebebf0e4 + content_hash: sha256:f4bdbb7f85966aa281c7831acaac981691882960fba14752ffe43e5a3a90cca7 - kind: project-relative target: claude value: .claude/skills/code-changes/references/escalate.md @@ -370,7 +370,7 @@ deployments: owners: - jandedobbeleer/agentic/skills/code-changes active_owner: jandedobbeleer/agentic/skills/code-changes - content_hash: sha256:d1bdd255c147cd3ea4aaadcbb0d6380c6753af930f23401a4be4473d17b4c165 + content_hash: sha256:6f299e0b7c5e7677277bc570d1b76e92f4387a8d37de4877447225e80db36801 - kind: project-relative target: claude value: .claude/skills/code-changes/references/pr-review-comments.md @@ -397,7 +397,7 @@ deployments: owners: - jandedobbeleer/agentic/skills/code-changes active_owner: jandedobbeleer/agentic/skills/code-changes - content_hash: sha256:347c831be88cf73e706717f667cc83c1cbd8867d886fecf8ed3bcd24cf69fff6 + content_hash: sha256:54530e1e5c4d54000b1046f141cd621e834aeb0c6176f95b76dca35a33c53fc9 - kind: project-relative target: claude value: .claude/skills/conventional-commit @@ -433,7 +433,7 @@ deployments: owners: - jandedobbeleer/agentic/skills/golang active_owner: jandedobbeleer/agentic/skills/golang - content_hash: sha256:7f902d05e2a53f97e261b1007ba2a529a8578d51b104d10f57f31e183f5d5b25 + content_hash: sha256:89ff95bbb7d575eafb790bb079e7bdaf6392a71de67b1b835ff70bad1133af2d - kind: project-relative target: claude value: .claude/skills/markdown @@ -622,7 +622,7 @@ deployments: owners: - jandedobbeleer/agentic/skills/code-changes active_owner: jandedobbeleer/agentic/skills/code-changes - content_hash: sha256:f4c48a1adf3139ddb9259339c2919e533ee448b1a1e9b03a1393fc38ebebf0e4 + content_hash: sha256:f4bdbb7f85966aa281c7831acaac981691882960fba14752ffe43e5a3a90cca7 - kind: project-relative target: copilot value: .agents/skills/code-changes/references/escalate.md @@ -658,7 +658,7 @@ deployments: owners: - jandedobbeleer/agentic/skills/code-changes active_owner: jandedobbeleer/agentic/skills/code-changes - content_hash: sha256:d1bdd255c147cd3ea4aaadcbb0d6380c6753af930f23401a4be4473d17b4c165 + content_hash: sha256:6f299e0b7c5e7677277bc570d1b76e92f4387a8d37de4877447225e80db36801 - kind: project-relative target: copilot value: .agents/skills/code-changes/references/pr-review-comments.md @@ -685,7 +685,7 @@ deployments: owners: - jandedobbeleer/agentic/skills/code-changes active_owner: jandedobbeleer/agentic/skills/code-changes - content_hash: sha256:347c831be88cf73e706717f667cc83c1cbd8867d886fecf8ed3bcd24cf69fff6 + content_hash: sha256:54530e1e5c4d54000b1046f141cd621e834aeb0c6176f95b76dca35a33c53fc9 - kind: project-relative target: copilot value: .agents/skills/conventional-commit @@ -721,7 +721,7 @@ deployments: owners: - jandedobbeleer/agentic/skills/golang active_owner: jandedobbeleer/agentic/skills/golang - content_hash: sha256:7f902d05e2a53f97e261b1007ba2a529a8578d51b104d10f57f31e183f5d5b25 + content_hash: sha256:89ff95bbb7d575eafb790bb079e7bdaf6392a71de67b1b835ff70bad1133af2d - kind: project-relative target: copilot value: .agents/skills/markdown