5 Commits

Include renames

Author	SHA1	Message	Date
3 people	2edec9a140	fix(deps): ship a zero-warning, minimal install (#1784) ... * fix(deps): ship a zero-warning, minimal install The published package declared 62 runtime `dependencies`, but `dist/cli.mjs` is a fully-bundled esbuild output that inlines almost all of them. End users therefore installed ~476 transitive packages — including three subtrees the bundle never needs at install time, each emitting an install warning: - node-domexception (deprecated) via google-auth-library - protobufjs (allow-scripts) via @grpc/* (already bundled into dist) - sharp (allow-scripts) native image module The repo's `overrides`/`allowScripts` silence these locally, but those are root-only npm settings and are ignored when the package is installed as a dependency — so end users saw the warnings. Core changes: - package.json: runtime dependencies trimmed 62 -> 3 (@orama/orama, @orama/plugin-data-persistence, @vscode/ripgrep). Bundled packages, plus the optional sharp/google-auth-library, move to devDependencies so they are built/tested but not shipped. - package.json: @anthropic-ai/sdk, @modelcontextprotocol/sdk, react and react-reconciler declared as OPTIONAL peerDependencies — externalized by the ./sdk bundle but bundled into the CLI. Optional peers keep the CLI install minimal and warning-free while still resolving for ./sdk consumers. - externals.ts: sharp, google-auth-library and @anthropic-ai/bedrock-sdk marked OPTIONAL_RUNTIME_EXTERNALS (loaded on demand, not shipped). - validate-externals.ts: runtime deps validate against externals; bundled deps validate against dependencies + devDependencies. - client.ts: load @anthropic-ai/bedrock-sdk via the runtime importer so esbuild no longer inlines it and hoists its static @aws-sdk import into the CLI bundle (that was a startup crash for default installs). Optional-dependency UX (consistent, actionable errors): - New src/utils/optionalRuntimeModule.ts exports importRuntimeModule and importOptionalRuntimeModule. The optional variant translates a missing package (code === 'ERR_MODULE_NOT_FOUND', specifier present in message) into "<feature> requires "<pkg>" ... Run `npm i -g <pkg>`". Generic so typed call sites keep their module types. - Routed ALL optional-package load sites through it (previously only one did): google-auth-library (client.ts, auth.ts, geminiAuth.ts), @anthropic-ai/foundry-sdk + @azure/identity (client.ts), and the @aws-sdk/* Bedrock paths (model/bedrock.ts, tokenEstimation.ts, aws.ts). - imageProcessor.ts: sharp-missing error now says `npm i -g sharp`. - docs/advanced-setup.md: new "Optional provider packages" table and a Vertex note documenting the on-demand installs. - Unit test for the helper (friendly error, success path, specifier match, raw passthrough). - knip.json: ignore google-auth-library (now loaded via runtime string). Verified on the current tree: - tsc, build/validate-externals, knip, and tests all pass. - npm pack + install --omit=dev adds 8 packages, zero deprecation/ allow-scripts/funding warnings; --version/--help/mcp list run. - With packages absent, CLAUDE_CODE_USE_BEDROCK and CLAUDE_CODE_USE_VERTEX print the friendly `npm i -g <pkg>` error (verified end-to-end). - ./sdk imports once its optional peers are present (24 exports, no warns). - Bundled ajv + ajv-formats validate with no ajv installed; no unguarded native runtime requires (fsevents absent in chokidar 4; bun:sqlite Bun-only). Trade-off: image reads, AWS Bedrock, Azure Foundry and GCP/Vertex now prompt a one-time `npm i -g <pkg>` instead of being shipped to every user. Co-Authored-By: OpenClaude <openclaude@gitlawb.com> Review fixes (CodeRabbit + jatmn): - validate-externals: the INTENTIONALLY_BUNDLED exemption is now scoped per bundle. The CLI exempts every bundled package; the SDK does NOT exempt packages declared as peerDependencies (keyed on package.json, an independent source of truth) so dropping react/@anthropic-ai/sdk from SDK_EXTERNALS now fails validation instead of silently passing. Added an explicit minimal- install contract check: bundled packages must be devDependencies-only — never in `dependencies`, and only the SDK-external subset may be optional peers. Validation logic extracted to scripts/externalsValidation.ts + tests. - FileReadTool oversized-image fallback now loads via the shared getImageProcessor() (not a raw import('sharp')) and re-throws ImageProcessorUnavailableError, so a missing processor surfaces the `npm i -g sharp` install hint instead of returning an over-budget image. - optionalRuntimeModule: match the missing specifier as a QUOTED token, not a raw substring, so a missing transitive package whose name contains the requested one (sharp vs sharp-libvips, @aws-sdk/client-bedrock vs @aws-sdk/client-bedrock-runtime) no longer triggers the wrong install hint. Predicate extracted to isMissingSpecifierError() with regression tests. - docs/advanced-setup.md: the Vertex auth section now shows both documented paths (gcloud ADC and a GOOGLE_APPLICATION_CREDENTIALS service-account file). Review fixes (round 2, CodeRabbit): - validate-externals: assert the optional-peer install contract — every peerDependency must be { optional: true } in peerDependenciesMeta (validateOptionalPeers), so losing that flag fails the build instead of silently reintroducing install warnings. - validate-externals: hard-check OPTIONAL_RUNTIME_EXTERNALS placement (validateOptionalRuntimeexternals). Anything esbuild can see statically must stay external in BOTH bundles (dropping sharp/google-auth-library now fails); the runtime-indirection-only subset (new RUNTIME_INDIRECTION_ONLY_EXTERNALS) must stay OUT of externals so esbuild never re-exposes their static imports. - Deeper-dig fix: @anthropic-ai/foundry-sdk was misclassified as INTENTIONALLY_BUNDLED, but it is loaded only through the Function indirection (esbuild never sees it, so it was never actually bundled) — its sole presence in dist is the specifier string. Per the PR's own "Azure Foundry now prompts" trade-off it is on-demand, so it now lives in OPTIONAL_RUNTIME_EXTERNALS + RUNTIME_INDIRECTION_ONLY_EXTERNALS (mirroring bedrock-sdk). sandbox-runtime is genuinely statically imported, so it stays bundled. - Provider-routing coverage (scripts/optionalRuntimeSpecifiers.test.ts): a static scan asserts every importOptionalRuntimeModule specifier is a declared OPTIONAL_RUNTIME_EXTERNAL and never also INTENTIONALLY_BUNDLED — the invariant that keeps a provider's optional package loadable on demand. - All new validators extracted to scripts/externalsValidation.ts with tests. Review fixes (round 3, CodeRabbit): - client.ts: gate the Vertex google-auth-library import behind the non-skip branch. CLAUDE_CODE_SKIP_VERTEX_AUTH (proxy/test) uses a mock GoogleAuth and must not require the optional package; it was loaded unconditionally before. - optionalRuntimeModule: drop the hard-coded `npm i -g`. The helper backs both the global CLI and project-local ./sdk consumers, so the hint is now context-neutral ("npm install <pkg>" / add -g for the global CLI). - validate-externals: every SDK_ONLY_EXTERNALS entry must STAY a peerDependency (a dropped peer leaves runtimeDeps while the SDK still externalizes it); and OPTIONAL_RUNTIME_EXTERNALS must never be shipped (fail on overlap with dependencies/peerDependencies). Both with tests + live-verified. - optionalRuntimeSpecifiers.test: pin the EXACT set of optionally-loaded specifiers instead of a >=5 count (a count passes even if a provider path regresses). - attachments: extract tryReadEditedImageAttachment() — background watched-file image attachments DEGRADE to null on any failure (incl. ImageProcessorUnavailableError) so a missing optional package never aborts a turn, while the explicit FileReadTool path still surfaces the install hint. Deterministic regression test (bad path -> null). - docs: Bedrock row notes profile-based auth also needs @aws-sdk/credential-providers; install-hint wording matches the new message. Review fixes (round 4, CodeRabbit): - attachments: stop sending the raw file path through the analytics bypass-cast (tengu_watched_file_compression_failed). Send only the safe file extension via getFileExtensionForAnalytics, matching the existing tengu_file_read_dedup pattern, so no usernames/project paths can leak. - externals.ts: corrected the OPTIONAL_RUNTIME_EXTERNALS header comment, which still claimed all entries "remain in COMMON_EXTERNALS" — no longer true since the indirection-only subset (bedrock/foundry) must stay OUT of the externals lists. (Other CodeRabbit comments on this push re-surface items already addressed in prior commits: the peerDependenciesMeta-optional check (validateOptionalPeers), the SDK-peers-present and optional-not-shipped validator rules, the exact-specifier-set test, the attachments degrade contract + test, and the context-neutral install hint are all present. The "assert every optional external is a devDependency" suggestion is intentionally NOT applied: @aws-sdk/* and @azure/identity are transitive devDeps via bedrock-sdk/foundry-sdk, so a blanket assertion would be incorrect; source resolution is covered by the build + tests that import these packages.) Review fixes (round 5, CodeRabbit): - attachments: stop leaking file paths via logError in the background-image degrade path. readImageWithTokenBudget can throw path-bearing messages (e.g. "Image file is empty: <path>") and logError persists message/stack, so log only the error TYPE name now. (Analytics payload was already sanitized.) - attachments: tryReadEditedImageAttachment takes an injectable reader so the degrade contract is tested for the EXACT error types — ImageProcessorUnavailableError and a path-bearing read error both degrade to null (not just ENOENT) — plus a success case. No mocking. - validate-externals: enforce the source-install half of the optional contract. Non-transitive OPTIONAL_RUNTIME_EXTERNALS must be devDependencies so `bun install` source builds resolve them. The new TRANSITIVE_OPTIONAL_EXTERNALS documents the exemption (@aws-sdk/* via @anthropic-ai/bedrock-sdk, @azure/identity via @anthropic-ai/foundry-sdk — provided transitively, not direct devDeps). A blanket "all optionals are devDeps" check would have wrongly failed on those. Tests + live-verified (dropping sharp from devDependencies now fails). Review fixes (round 6, CodeRabbit + jatmn): - optionalRuntimeSpecifiers.test: the call-site scan regex missed generic-annotated calls (importOptionalRuntimeModule<...>(...)) in model/bedrock.ts and tokenEstimation.ts, so the exact-set assertion was incomplete. Regex now allows an optional generic; EXPECTED_SPECIFIERS adds @aws-sdk/client-bedrock and @aws-sdk/client-bedrock-runtime (7 total). - importOptionalRuntimeModule default generic is now <T = unknown> (was any), so destructured imports are no longer silently any. Every call site now supplies its module type — typeof import('<pkg>') where the package is type-resolvable (bedrock-sdk, foundry-sdk, @aws-sdk/credential-providers, google-auth-library), and a named minimal-shape alias for @azure/identity (not a direct devDep, so typeof import can't resolve it). This gives compile-time verification of each provider's module contract (export names, shapes) — the structural answer to the "cover the provider branches" ask. - attachments: tryReadEditedImageAttachment takes injectable {read,log,track}; a new test asserts the sanitized-telemetry contract directly — the logError payload is path-free and the analytics payload carries only `ext`, never the edited-image path. * fix(deps): address optional runtime review findings * test(deps): isolate optional runtime importer mocks * fix(deps): clarify AWS optional auth labels * fix(deps): close optional runtime review gaps --------- Co-authored-by: jatmn <the@jat.mn>	2026-07-07 13:19:39 +08:00
3 people	fb40d49e68	feat: add repo map codebase intelligence (#1867) ... * feat: add Codebase Intelligence — repo map with PageRank-ranked structural summaries Adds a new module that builds a structural map of the repository by parsing source files with tree-sitter, building a cross-file reference graph weighted by IDF, ranking files with PageRank, and rendering a token-budgeted summary of the most important files and their signatures. Surface: - RepoMap tool the model can call on-demand, with focus_files / focus_symbols - /repomap slash command with --tokens, --focus, --stats, --invalidate - Auto-injection into session system context, gated by REPO_MAP=1 env var (compile-time feature('REPO_MAP') flag stays off in scripts/build.ts) How it works: git ls-files → tree-sitter WASM parse → extract defs/refs → IDF-weighted directed graph → PageRank → render top files until token budget Files imported by many others rank highest. Common symbol names (get, set, map, value) are down-weighted via IDF. Results cached to disk keyed by (path, mtime, size) — only changed files are re-parsed. Supported languages: TypeScript, JavaScript, Python. Tree-sitter tag queries are inlined as string constants in queries.ts so they ship inside dist/cli.mjs and work after npm install — the .scm source files are kept for readability/Aider attribution but are not required at runtime. A drift-guard test (queries.test.ts) asserts byte-equality between the inlined strings and the .scm source files. Dependencies added: web-tree-sitter, tree-sitter-wasms, graphology, graphology-pagerank, graphology-operators, js-tiktoken. * fix(repomap): invalidate rendered cache on file edits + Windows test fix - computeMapHash now folds per-file mtime+size into the cache key so a source edit (without changing the file list) no longer returns the prior rendered map. Adds a regression test that edits a file and confirms the second build reflects the new symbol without manual invalidateCache(). - queries.test.ts byte-for-byte drift guard normalizes CRLF -> LF when reading the .scm source so Windows checkouts pass. .gitattributes also pins *.scm to LF on future checkouts. - Externals: declare web-tree-sitter, tree-sitter-wasms, graphology*, and js-tiktoken in scripts/externals.ts so build validation passes. * fix(repomap): expand directory focus paths * fix(repomap): satisfy deadcode check * Fix repo map review findings * Resolve remaining repo map review findings * fix(repomap): address review findings * fix(repomap): address review findings * fix(repomap): resolve smoke and review follow-ups * fix(repomap): preserve cached tag order * fix(repomap): resolve review follow-ups * fix(repomap): satisfy query promise lint * Fix repo map context timeout cleanup * fix: address repo map review findings * fix: cancel timed-out repo map context builds * fix(repomap): preserve git file path whitespace * fix(repomap): handle graph and parsing edge cases * fix(repomap): preserve shell token positions * fix(repomap): respect configured cache home * fix(repomap): address review findings - Add explicit 10000ms timeout to the feature-flag-off context test to avoid cold-import flakes. - Add --focus-symbols flag to /repomap and forward it to buildRepoMap, matching the RepoMap tool. - Add parsing/command tests and docs coverage for --focus-symbols. --------- Co-authored-by: gnanam1990 <gnanasekaran.sekareee@gmail.com>	2026-07-07 11:09:41 +08:00
0xfandomandGitHub	3fb718f403	fix(worktree): base agent isolation worktree on parent HEAD, not origin/main (#1652) ... * fix(worktree): base agent isolation worktree on parent HEAD, not origin/main createAgentWorktree delegated to getOrCreateWorktree with no base, so the non-PR path checked out origin/<defaultBranch> whenever that remote-tracking ref existed locally. An isolated agent (isolation: "worktree") is expected to see the same committed state as the parent session, but instead got an older tree and missed files that exist only on the active branch. Resolve the parent session's HEAD from the session cwd and thread it through getOrCreateWorktree as a new `baseRef` option (used verbatim, then rev-parsed to a SHA). Falls back to the prior origin-based behavior when HEAD can't be resolved (e.g. a repo with no commits). EnterWorktree/PR worktree paths are unchanged. Fixes #1586 * test(worktree): make agent-base regression test hermetic; add explicit cwd seam The integration test went through createAgentWorktree's ambient getCwd(), which reads process-global cwd state. bun runs test files concurrently in one process and a sibling test mutates that global cwd, so the agent-base test raced and failed in the full suite (worktree based on origin/main, missing the feature-only file). Add an optional `cwd` to createAgentWorktree, used for both the canonical git-root and the parent-HEAD lookups (defaults to getCwd()). The test pins it explicitly so it no longer depends on the raced global cwd. Verified it passes isolated and in the full src/utils suite, and still fails on the pre-fix code. * test(worktree): isolate agent-base regression from leaked module mocks Per review: the regression test imported createAgentWorktree (and thus worktree.ts's execFileNoThrow.js dependency) at module load, so it could bind process-global bun mock.module state left by a neighboring suite before establishing its own isolation. Hold the shared mutation lock for the whole test so it never runs interleaved with suites that mock execFileNoThrow.js, and import the worktree module only after the lock is held, via a cache-busted dynamic import, so the binding resolves against the real module. * test(worktree): use execa and a longer timeout in the agent-base regression Per AGENTS.md, src/utils tests shell out via execa rather than child_process, so swap the git() helper to execaSync. The test also performs real git work (init, commit, branch, worktree add) that can exceed Bun's default 5s timeout on slower/Windows runners, so give it an explicit 15s budget. * test: stop two suites leaking partial module mocks process-wide Bun's mock.module is process-global and is not reverted by mock.restore(), so a partial-surface mock left active by one suite breaks any later suite that imports the same module — it sees a module missing the un-mocked exports and fails to link with "named export not found". - setupGitHubActions.test.ts mocked config.js with only saveGlobalConfig. Spread the real surface (as it already does for execFileNoThrow/browser) and restore it in afterEach, so config.js keeps its full surface for later suites. - osc.test.ts mocked execFileNoThrow.js and tempfile.js with partial stubs and never restored them. Spread the real surfaces and gate each overridden export on an active-suite flag, so when osc's tests aren't running the exports delegate to the real implementation instead of leaking stubs. This unblocks worktree.agentBase.test.ts (which loads worktree.ts → config.js / execFileNoThrow.js) when it runs after either suite. * Revert mock-isolation changes that regressed the full test suite The previous commit reworked the leaking config.js / execFileNoThrow.js mocks in setupGitHubActions.test.ts and osc.test.ts (and swapped the worktree test helper to execa). While it fixed the two-file reproductions, it regressed the full smoke-and-tests run: createAgentWorktree began failing with "not in a git repository" in the combined suite. Revert to the last green state while a more robust isolation approach (process-level isolation for the real-git test) is worked out. * test(worktree): run the agent-base regression in an isolated process The previous in-suite isolation attempts couldn't survive the full test run: createAgentWorktree shells out to git via execFileNoThrow.js, which other suites mock with `mock.module` — a process-global override Bun cannot reliably revert, so any leaked stub made the test fail with "not in a git repository" depending on suite ordering. Move the actual createAgentWorktree call into a standalone child process (worktree.agentBase.fixture.ts) that loads only the real modules, and keep the git repo setup and assertions in the test using real git directly. Nothing the shared test process mocks can reach the child, so the test is now order- and leak-independent. Verified passing in isolation, alongside the two leaking suites that previously broke it, and in the full suite. * test(worktree): register agent-base fixture as a knip entrypoint The agent-base regression runs createAgentWorktree in a standalone child process (worktree.agentBase.fixture.ts) to escape leaked module mocks. knip sees no static importer for it — it is spawned via execFileSync — and the deadcode check fails it as an unused file. It is a genuine process entrypoint, so add the *.fixture.ts glob to knip's entry list.	2026-06-25 06:23:48 +08:00
5 people	9c0d5c61e2	fix(deps): remove deprecated uuid install path by replacing vertex-sdk with local client (#1771) ... * fix(deps): remove deprecated uuid install path * fix(api): address PR #1232 review — type the local Vertex client surface Resolves the blocker raised by @Vasanthdev2004, @gnanam1990, and @jatmn: the in-repo AnthropicVertex replacement compiled under bun (no type-check) but added 4 `tsc --noEmit` errors that the upstream typed SDK did not. - Declare `messages`/`beta` as typed class fields (BaseAnthropic doesn't, but the upstream @anthropic-ai/vertex-sdk client did), so typed consumers — client.ts `new AnthropicVertex(...)` and the SDK calling `.messages` — keep the resource surface. (vertexClient.ts:145/146, test:53) - Widen the header-merge helpers to accept the base client's request header type (HeadersLike), and handle the NullableHeaders shape it actually passes so the merge stays correct, not just type-clean. (vertexClient.ts:182) Also drops the now-stale `@anthropic-ai/vertex-sdk` entries left behind by the dependency removal: - scripts/externals.ts INTENTIONALLY_BUNDLED (P3) - knip.json ignoreDependencies Testing: `tsc --noEmit` clean; vertex/client/gemini tests 51 pass; smoke green (INTENTIONALLY_BUNDLED back in sync, 57 entries); knip clean. Co-Authored-By: OpenClaude <openclaude@gitlawb.com> * fix(api): address CodeRabbit review on PR #1232 — auth precedence + coverage - Security (vertexClient.ts): merge resolved Google auth headers LAST so a caller-supplied Authorization / x-goog-user-project can't override the Vertex credential and send the wrong token upstream. Other request headers still pass through unchanged. - Tests (vertexClient.test.ts): add focused regression coverage for the previously-unguarded routing/auth branches — * streaming → :streamRawPredict path (+ model stripped, stream preserved) * count_tokens → count-tokens:rawPredict path rewrite * auth-header precedence: caller Authorization does NOT override the Vertex token (guards the fix above + exercises the NullableHeaders merge branch). Testing: tsc clean; vertexClient tests 5 pass; full src/services/api 840 pass; smoke + knip green. Co-Authored-By: OpenClaude <openclaude@gitlawb.com> * fix(api): validate and encode Vertex model before building the URL CodeRabbit follow-up on PR #1232: `model` was interpolated straight into the Vertex endpoint path, so a missing/non-string model would silently route to `.../models/undefined:rawPredict` instead of failing fast. Now throw a clear error on a missing/empty model and encodeURIComponent the value before building the path. Adds a focused test for the missing-model case. Testing: tsc clean; vertexClient tests 6 pass; smoke + knip green. Co-Authored-By: OpenClaude <openclaude@gitlawb.com> * fix(api): address remaining review items from PR #1232 - [P2] Fix count_tokens method guard: apply method==='post' to both paths - [P3] Remove unused accessToken option from AnthropicVertex - [P3] Narrow batches type on messages/beta resources with Omit * test: add count_tokens?beta=true routing regression test --------- Co-authored-by: Kevin Codex <kevin@gitlawb.com> Co-authored-by: OpenClaude <openclaude@gitlawb.com> Co-authored-by: Gravirei <gravirei@users.noreply.github.com>	2026-06-24 13:03:29 +08:00
3 people	f4c3be850e	chore: remove dead code and add knip gate to CI check (#1612) ... Delete 32 unreferenced source files (~4,000 lines) verified dead by import-specifier grep and knip: test-only token utilities, orphaned hooks (useTaskListWatcher, useSkillImprovementSurvey + its component), the removed DevBar and ConfigTool UIs, unregistered bundled skills (stuck, verifyContent), unused analytics sinks, the benchmark command, and stale migrations/helpers. Remove unused dependencies code-excerpt, stack-utils, and tsx from package.json plus their entries in build stub/external lists. Add knip with a tuned knip.json (entrypoints, build-time stub targets, subprocess-launched fixtures, and runtime-string-imported SDKs ignored; providerAutoDetect kept intentionally as provider pre-wiring) and wire `bun run deadcode` into the `check` script so dead code stays dead. Co-authored-by: OpenClaude <openclaude@gitlawb.com>	2026-06-14 10:13:37 +08:00