bckelley/cgm-remote-monitor
1
0
Fork 0
mirror of https://github.com/bckelley/cgm-remote-monitor.git synced 2026-08-24 03:14:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

Allow api3 behind reverse proxy (#5631)

Browse Source 
* Allow api3 behind reverse proxy

* fix test

Co-authored-by: Sulka Haro <sulka@sulka.net>
This commit is contained in:
Milos Kozak
2021-01-17 19:46:28 +02:00
committed by GitHub
co-authored by Sulka Haro
parent ccd591d4ef
commit f6f7e18888
2 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/api3/security.js
+5 -5
View File
@@ -56,10 +56,10 @@ function authenticate (opCtx) {
return resolve({ shiros: [ adminShiro ] });
}
if (req.protocol !== 'https') {
return reject(
opTools.sendJSONStatus(res, apiConst.HTTP.FORBIDDEN, apiConst.MSG.HTTP_403_NOT_USING_HTTPS));
}
// if (req.protocol !== 'https') {
// return reject(
// opTools.sendJSONStatus(res, apiConst.HTTP.FORBIDDEN, apiConst.MSG.HTTP_403_NOT_USING_HTTPS));
// }
const checkDateResult = checkDateHeader(opCtx);
if (checkDateResult !== true) {
@@ -123,4 +123,4 @@ module.exports = {
authenticate,
checkPermission,
demandPermission
};
};
tests/api3.security.test.js
+11 -11
View File
@@ -33,16 +33,16 @@ describe('Security of REST API3', function() {
});
it('should require HTTPS', async () => {
if (semver.gte(process.version, '10.0.0')) {
let res = await request(self.http.baseUrl) // hangs on 8.x.x (no reason why)
.get('/api/v3/test')
.expect(403);
res.body.status.should.equal(403);
res.body.message.should.equal(apiConst.MSG.HTTP_403_NOT_USING_HTTPS);
}
});
// it('should require HTTPS', async () => {
// if (semver.gte(process.version, '10.0.0')) {
// let res = await request(self.http.baseUrl) // hangs on 8.x.x (no reason why)
// .get('/api/v3/test')
// .expect(403);
//
// res.body.status.should.equal(403);
// res.body.message.should.equal(apiConst.MSG.HTTP_403_NOT_USING_HTTPS);
// }
// });
it('should require Date header', async () => {
@@ -186,4 +186,4 @@ describe('Security of REST API3', function() {
.expect(200);
});
});
});