mirror of
https://github.com/Chatterino/chatterino2.git
synced 2026-08-24 10:04:53 -05:00
fix: update message length when completing (#6856)
When the completer completes, we block all signals. However, we do want to broadcast a text-changed signal. Since we can't unblock individual signals, we unconditionally emit a signal after we unblock all signals. This might come with some side-effects when the user uses certain combinations of settings. I'm merging this in with the hope that these concerns, if any real ones exist, pop up as issues. Reported-by: 4rneee Reviewed-by: Mm2PL Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This commit is contained in:
@@ -16,6 +16,7 @@ Checks: "-*,
|
||||
clazy-*,
|
||||
-clazy-qstring-allocations,
|
||||
-clazy-missing-qobject-macro,
|
||||
-clazy-incorrect-emit,
|
||||
-clazy-ctor-missing-parent-argument,
|
||||
cppcoreguidelines-*,
|
||||
-cppcoreguidelines-pro-type-cstyle-cast,
|
||||
|
||||
@@ -181,6 +181,7 @@ void ResizingTextEdit::keyPressEvent(QKeyEvent *event)
|
||||
QSignalBlocker dontTriggerCursorMovement(this);
|
||||
this->completer_->complete();
|
||||
}
|
||||
this->textChanged();
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -210,6 +211,7 @@ void ResizingTextEdit::keyPressEvent(QKeyEvent *event)
|
||||
QSignalBlocker dontTriggerCursorMovement(this);
|
||||
this->completer_->complete();
|
||||
}
|
||||
this->textChanged();
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user