starred/chatterino2
1
0
Fork 0
mirror of https://github.com/Chatterino/chatterino2.git synced 2026-08-24 02:24:18 -05:00
Code Issues Packages Projects Releases Wiki Activity

tests: increase wait and timeout in OnceFlag.waitFor (#7121)

Browse Source 
In hopes to not land a PR for #7116, this increases the wait + timeout
as described in
https://github.com/Chatterino/chatterino2/issues/7116#issuecomment-5015316981.

I think the issue is that macOS runners on GitHub Actions are so
incredibly slow sometimes that we get these weird timings. And if that's
the cause, the overhead (e.g. from switching tasks) should be constant.
Then, if we increase the wait and timeout, we also increase the accepted
jitter (timeout - wait) from 100ms to 1s. So if the lag we get is at
about 150ms, that is now accepted.

Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This commit is contained in:
Nerixyz
2026-07-20 16:59:09 +00:00
committed by GitHub
parent d9886c8840
commit b2f1e12e62
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/src/OnceFlag.cpp
+3 -3
View File
@@ -41,7 +41,7 @@ TEST(OnceFlag, waitFor)
startedFlag.set();
startedAckFlag.wait();
std::this_thread::sleep_for(std::chrono::milliseconds{100});
std::this_thread::sleep_for(std::chrono::milliseconds{1000});
stoppedFlag.set();
});
@@ -49,10 +49,10 @@ TEST(OnceFlag, waitFor)
startedAckFlag.set();
auto start = std::chrono::system_clock::now();
ASSERT_TRUE(stoppedFlag.waitFor(std::chrono::milliseconds{200}));
ASSERT_TRUE(stoppedFlag.waitFor(std::chrono::milliseconds{2000}));
auto stop = std::chrono::system_clock::now();
ASSERT_LT(stop - start, std::chrono::milliseconds{200});
ASSERT_LT(stop - start, std::chrono::milliseconds{2000});
start = std::chrono::system_clock::now();
ASSERT_TRUE(stoppedFlag.waitFor(std::chrono::milliseconds{1000}));