use log.exception() instead of log.error() and log.warning() when logging exceptions

This commit is contained in:
arvidn
2025-10-28 14:18:41 +01:00
parent 8d53bbc103
commit 39764bb7c5
2 changed files with 7 additions and 7 deletions
+5 -5
View File
@@ -113,8 +113,8 @@ class Receiver:
async def trigger_callback(self, update: Optional[Delta] = None) -> None:
try:
await self._update_callback(self._connection.peer_node_id, update)
except Exception as e:
log.error(f"_update_callback: node_id {self.connection().peer_node_id}, raised {e}")
except Exception:
log.exception(f"_update_callback: node_id {self.connection().peer_node_id}")
def reset(self) -> None:
log.info(f"reset: node_id {self.connection().peer_node_id}, current_sync: {self._current_sync}")
@@ -181,13 +181,13 @@ class Receiver:
await method(message)
await send_response()
except InvalidIdentifierError as e:
log.warning(f"_process: node_id {self.connection().peer_node_id}, InvalidIdentifierError {e}")
log.exception(f"_process: node_id {self.connection().peer_node_id}")
await send_response(PlotSyncError(int16(e.error_code), f"{e}", e.expected_identifier))
except PlotSyncException as e:
log.warning(f"_process: node_id {self.connection().peer_node_id}, Error {e}")
log.exception(f"_process: node_id {self.connection().peer_node_id}")
await send_response(PlotSyncError(int16(e.error_code), f"{e}", None))
except Exception as e:
log.warning(f"_process: node_id {self.connection().peer_node_id}, Exception {e}")
log.exception(f"_process: node_id {self.connection().peer_node_id}")
await send_response(PlotSyncError(int16(ErrorCodes.unknown), f"{e}", None))
def _validate_identifier(self, identifier: PlotSyncIdentifier, start: bool = False) -> None:
+2 -2
View File
@@ -278,8 +278,8 @@ class PlotManager:
f"total_result.removed {len(total_result.removed)}, "
f"total_duration {total_result.duration:.2f} seconds"
)
except Exception as e:
log.error(f"_refresh_callback raised: {e} with the traceback: {traceback.format_exc()}")
except Exception:
log.exception("_refresh_callback raised")
self.reset()
def refresh_batch(self, plot_paths: list[Path], plot_directories: set[Path]) -> PlotRefreshResult: